From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108459 invoked by alias); 22 Nov 2017 18:16:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108432 invoked by uid 89); 22 Nov 2017 18:16:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout2.netcologne.de Received: from cc-smtpout2.netcologne.de (HELO cc-smtpout2.netcologne.de) (89.1.8.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Nov 2017 18:16:23 +0000 Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202]) by cc-smtpout2.netcologne.de (Postfix) with ESMTP id 7F514126D2; Wed, 22 Nov 2017 19:16:21 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin2.netcologne.de (Postfix) with ESMTP id 7C21611E01; Wed, 22 Nov 2017 19:16:21 +0100 (CET) Received: from [78.35.131.92] (helo=cc-smtpin2.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 5a15bef5-02b8-7f0000012729-7f000001ed27-1 for ; Wed, 22 Nov 2017 19:16:21 +0100 Received: from [192.168.178.20] (xdsl-78-35-131-92.netcologne.de [78.35.131.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA; Wed, 22 Nov 2017 19:16:19 +0100 (CET) Subject: Re: [PATCH] Use __BYTE_ORDER__ predefined macro instead of runtime check To: Janne Blomqvist , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <1511354047-32527-1-git-send-email-blomqvist.janne@gmail.com> From: Thomas Koenig Message-ID: <984714d2-9243-c60a-adb8-7b92cd9cae3e@netcologne.de> Date: Wed, 22 Nov 2017 18:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511354047-32527-1-git-send-email-blomqvist.janne@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg02071.txt.bz2 Hi janne, > Regtested on x86_64-pc-linux-gnu, Ok for trunk? Jerry already OK'd this, so you can commit if you want. What you could do is to hide the macro invocation behind a macro in libgfortran.h, something like #define BIG_ENDIAN (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__) Also, I have opened PR libfortran/83097 for this, you can mention this in the ChangeLog entry. Regards Thomas