From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 4A7BE385843D for ; Wed, 8 Dec 2021 17:35:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A7BE385843D Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBE3D1042; Wed, 8 Dec 2021 09:35:06 -0800 (PST) Received: from [192.168.1.19] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 756D03F73D; Wed, 8 Dec 2021 09:35:06 -0800 (PST) Subject: Re: [PATCH 2/2][GCC] arm: Declare MVE types internally via pragma To: Murray Steele Cc: gcc-patches@gcc.gnu.org References: <55ba6a8c-4dda-c023-0e93-a052e4830d06@arm.com> <342ef4e3-6013-2d67-adc8-6310febe2f52@foss.arm.com> <2a59e081-0a5f-5b9b-c398-d89c6c217822@arm.com> <9ccc226a-fdf7-d465-6074-b6a78d16b316@arm.com> <060230b8-22b0-36eb-2594-c469efaabf35@arm.com> <3ad22fca-fa13-04ea-f114-01e8c52dd280@foss.arm.com> From: Richard Earnshaw Message-ID: <9849efef-a0db-825a-2473-8f71dc2412b6@foss.arm.com> Date: Wed, 8 Dec 2021 17:34:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3498.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 17:35:10 -0000 On 08/12/2021 15:39, Murray Steele via Gcc-patches wrote: > Hi, > > Thank you for the feedback, I'll make the noted changes to the changelog and > add the missing end-of-namespace comments. > > On 08/12/2021 15:23, Richard Earnshaw wrote: > >> diff --git a/gcc/config/arm/arm-mve-builtins.def b/gcc/config/arm/arm-mve-builtins.def >> new file mode 100644 >> index 0000000000000000000000000000000000000000..02a46bec3e4cba6add9bce4021c732e15aa8b012 >> --- /dev/null >> +++ b/gcc/config/arm/arm-mve-builtins.def >> @@ -0,0 +1,41 @@ >> >> +#ifndef DEF_MVE_TYPE >> +#define DEF_MVE_TYPE(A, B) >> +#endif >> >> When would this file ever be included when this macro wasn't defined? Better to require the caller to define this by using #error if it's missing. >> >> then... >> >> + >> +#undef DEF_MVE_TYPE >> >> This isn't needed anymore, because caller should undef it after use. > > > I'd added this because later patches that build from this series will most > likely need to define further DEF_MVE_* macros, in the style of the current > SVE implementation. You are right that it is unnecessary for right now though, > and I'll remove it too. The best thing to do in that case then is to require the caller to explicitly define DEF_MVE_TYPE as a NOP when it isn't required. It means a bit more churn at each call site, but I think it's more robust longer term as it is clear which operations are going to be extracted. R. > > Thanks again, > > Murray >