From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 706CF3858CDA for ; Tue, 2 Jul 2024 08:08:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 706CF3858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 706CF3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719907703; cv=none; b=r7v4XG+uw+ve/a2vNIp8DTf5r9YvZoJRGGkSJ2x41WCosRyuW2uZRMRVx8XfWtEKS7NC5jf+lllQ9b/D56qy2QnHWG8KQE+JN+ff6xQOT/Az8lcBPbhgzX6Nv6A74H3/kvJtERlqRdKWOtyDHmwNIlp3H+wd7bacnGCly8Sjloo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719907703; c=relaxed/simple; bh=juNEWcYmETXMnxV5QbfM3Rx8zY7PO+01Bhs4cDk6lv4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RCunKCuZh1xhSGesvweUR06fX/OUzdvQjAgGH9tJImijzf7i3WF0tZvOt6scuZI6yla4aVpakqrpoNh+AMzV7YYe9l8/adTt5a0AE0WzlkXGUE8Qs91qY3esdvqnvHRWYs2NAuK2ITECBcJ/4QzGkgJ9gHcuhyzg5F4W2iAKSmc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4627wI36023038; Tue, 2 Jul 2024 08:08:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:references:cc:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=T cl3NToJudACd0tYxmKMa9jkSzdYKzNRuoOLjFhJFyk=; b=XjkZvZmJXOCxvHv0c 0n21TVwl+kV35xSC7Ivim8M5PpBOFXM9201dqM/mp5ww1Azl3cwIgGgwRRt+kkNS /lK4jezt5Yj6+L3x/RsakLj2C4z2myq6w1DfMbhBbebkV4mcHh+uCnSVvrLGAc19 3/LqFYOZ1fJjtdIV91ZPQxzMJr0r0y5eHUprOXTpDvDLB/HGME87qep+pi/6cPsH 3s5GNLJFB36xmqUJjenimDRsN3zR3a/G8ebjGwKGboxER/w4sfpKQZ8X63STQWA/ G2IqfFgtcNYdGPTP+VptTPS3vdiY53pSL3KbwYC0gA8epNpspb1MPMRrAbcQPqT+ JJpPg== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 404dmj80vr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jul 2024 08:08:11 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4626IXmU005961; Tue, 2 Jul 2024 08:08:11 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 402vku40jy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jul 2024 08:08:10 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 462885Li52232534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Jul 2024 08:08:07 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8F19F20043; Tue, 2 Jul 2024 08:08:05 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B38C2004D; Tue, 2 Jul 2024 08:08:04 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 2 Jul 2024 08:08:03 +0000 (GMT) Message-ID: <985d6bfb-6b2b-7d8a-ba06-521f94a51f03@linux.ibm.com> Date: Tue, 2 Jul 2024 16:08:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH V2] rs6000: load high and low part of 128bit vector independently [PR110040] Content-Language: en-US To: jeevitha References: <1a62a215-98e2-4e3b-9059-681189157d0a@linux.vnet.ibm.com> <18dfc483-0815-4ede-aa20-0833a83d9671@linux.ibm.com> Cc: GCC Patches , Segher Boessenkool , Peter Bergner From: "Kewen.Lin" In-Reply-To: <18dfc483-0815-4ede-aa20-0833a83d9671@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: XQMzt-Z57nRG7POQ8qMht5mvXzK5Mi46 X-Proofpoint-ORIG-GUID: XQMzt-Z57nRG7POQ8qMht5mvXzK5Mi46 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-02_04,2024-07-02_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015 mlxlogscore=999 impostorscore=0 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407020059 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeevitha, on 2024/6/19 20:39, jeevitha wrote: > Hi All, > > Updated the patch based on review comments. This patch passed bootstrap > and regression testing on powerpc64le-linux with no regressions. > > PR110040 exposes an issue concerning moves from vector registers to GPRs. > There are two moves, one for upper 64 bits and the other for the lower > 64 bits. In the problematic test case, we are only interested in storing > the lower 64 bits. However, the instruction for copying the upper 64 bits > is still emitted and is dead code. This patch adds a splitter that splits > apart the two move instructions so that DCE can remove the dead code after > splitting. > > 2024-06-19 Jeevitha Palanisamy > > gcc/ > PR target/110040 > * config/rs6000/vsx.md (split pattern for V1TI to DI move): Defined. Nit: s/Defined/New define/ > > gcc/testsuite/ > PR target/110040 > * gcc.target/powerpc/pr110040-1.c: New testcase. > * gcc.target/powerpc/pr110040-2.c: New testcase. > > > diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md > index f135fa079bd..f1979815df6 100644 > --- a/gcc/config/rs6000/vsx.md > +++ b/gcc/config/rs6000/vsx.md > @@ -6706,3 +6706,20 @@ > "vmsumcud %0,%1,%2,%3" > [(set_attr "type" "veccomplex")] > ) > + > +(define_split > + [(set (match_operand:V1TI 0 "gpc_reg_operand") > + (match_operand:V1TI 1 "vsx_register_operand"))] > + "reload_completed > + && TARGET_DIRECT_MOVE_64BIT > + && int_reg_operand (operands[0], V1TImode) > + && vsx_register_operand (operands[1], V1TImode)" > + [(pc)] > +{ > + rtx src_op = gen_rtx_REG (V2DImode, REGNO (operands[1])); > + rtx dest_op0 = gen_rtx_REG (DImode, REGNO (operands[0])); > + rtx dest_op1 = gen_rtx_REG (DImode, REGNO (operands[0]) + 1); > + emit_insn (gen_vsx_extract_v2di (dest_op0, src_op, const0_rtx)); > + emit_insn (gen_vsx_extract_v2di (dest_op1, src_op, const1_rtx)); > + DONE; > +}) > diff --git a/gcc/testsuite/gcc.target/powerpc/pr110040-1.c b/gcc/testsuite/gcc.target/powerpc/pr110040-1.c > new file mode 100644 > index 00000000000..0a521e9e51d > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/pr110040-1.c > @@ -0,0 +1,15 @@ > +/* PR target/110040 */ > +/* { dg-do compile } */ > +/* { dg-require-effective-target int128 } */ > +/* { dg-require-effective-target powerpc_vsx } */ > +/* { dg-options "-O2 -mdejagnu-cpu=power9" } */ > +/* { dg-final { scan-assembler-not {\mmfvsrd\M} } } */ > + > +#include > + > +void > +foo (signed long *dst, vector signed __int128 src) > +{ > + *dst = (signed long) src[0]; > +} > + > diff --git a/gcc/testsuite/gcc.target/powerpc/pr110040-2.c b/gcc/testsuite/gcc.target/powerpc/pr110040-2.c > new file mode 100644 > index 00000000000..d2ef471d666 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/pr110040-2.c > @@ -0,0 +1,16 @@ > +/* PR target/110040 */ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ > +/* { dg-require-effective-target int128 } */ > +/* { dg-require-effective-target powerpc_vsx } */ > +/* { dg-final { scan-assembler-not {\mmfvsrd\M} } } */ > + > +/* Note: __builtin_altivec_tr_stxvrwx requires the -mcpu=power10 option */ It's a bit obscure here that the used bif name is "vec_xst_trunc" but this comment says "__builtin_altivec_tr_stxvrwx", I can understand it's copied from the actual error message but it also mentions "vec_xst_trunc" there when erroring. Maybe just say "/* builtin vec_xst_trunc requires power10. */" to avoid any confusion here. OK for trunk with these nits tweaked, thanks! BR, Kewen > + > +#include > + > +void > +foo (signed int *dst, vector signed __int128 src) > +{ > + __builtin_vec_xst_trunc (src, 0, dst); > +} > >