public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, testsuite] Add -fno-sched-pressure to a couple sms-*.c tests for powerpc
@ 2016-12-20 17:27 Pat Haugen
  2016-12-20 18:17 ` Segher Boessenkool
  0 siblings, 1 reply; 2+ messages in thread
From: Pat Haugen @ 2016-12-20 17:27 UTC (permalink / raw)
  To: GCC Patches; +Cc: Segher Boessenkool

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

gcc.dg/sms-3.c and gcc.dg/sms-6.c fail on powerpc when -fsched-pressure is used. The -fsched-pressure option changes the value returned by rs6000_issue_rate which in turn affects the computed initiation interval in the SMS code and leads to failure to modulo schedule the single loop in sms-3.c and 1 of the 3 loops in sms-6.c. This patch adds that option for powerpc and is a precursor to a patch I'll submit shortly that enables -fsched-pressure by default for the rs6000 port.

I have verified the updated tests pass both before and after my patch to enable -fsched-pressure is applied. Ok for trunk?

-Pat


testsuite/ChangeLog:
2016-12-20  Pat Haugen  <pthaugen@us.ibm.com>

	* gcc.dg/sms-3.c: Add -fno-sched-pressure for powerpc.
	* gcc.dg/sms-6.c: Likewise.

[-- Attachment #2: sms-tests.diff --]
[-- Type: text/x-patch, Size: 1165 bytes --]

Index: gcc.dg/sms-3.c
===================================================================
--- gcc.dg/sms-3.c	(revision 243651)
+++ gcc.dg/sms-3.c	(working copy)
@@ -1,5 +1,6 @@
 /* { dg-do run } */
 /* { dg-options "-O2 -fmodulo-sched -funroll-loops -fdump-rtl-sms --param sms-min-sc=1 -fmodulo-sched-allow-regmoves" } */
+/* { dg-options "-O2 -fmodulo-sched -funroll-loops -fdump-rtl-sms --param sms-min-sc=1 -fmodulo-sched-allow-regmoves -fno-sched-pressure" { target powerpc*-*-* } } */
 
 extern void abort (void);
 
Index: gcc.dg/sms-6.c
===================================================================
--- gcc.dg/sms-6.c	(revision 243651)
+++ gcc.dg/sms-6.c	(working copy)
@@ -1,7 +1,7 @@
 /* { dg-do run } */
 /* { dg-require-effective-target size32plus } */
 /* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms --param sms-min-sc=1" } */
-/* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms --param sms-min-sc=1 -fmodulo-sched-allow-regmoves" { target powerpc*-*-* } } */
+/* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms --param sms-min-sc=1 -fmodulo-sched-allow-regmoves -fno-sched-pressure" { target powerpc*-*-* } } */
 
 extern void abort (void);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, testsuite] Add -fno-sched-pressure to a couple sms-*.c tests for powerpc
  2016-12-20 17:27 [PATCH, testsuite] Add -fno-sched-pressure to a couple sms-*.c tests for powerpc Pat Haugen
@ 2016-12-20 18:17 ` Segher Boessenkool
  0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2016-12-20 18:17 UTC (permalink / raw)
  To: Pat Haugen; +Cc: GCC Patches

On Tue, Dec 20, 2016 at 11:26:02AM -0600, Pat Haugen wrote:
> gcc.dg/sms-3.c and gcc.dg/sms-6.c fail on powerpc when -fsched-pressure is used. The -fsched-pressure option changes the value returned by rs6000_issue_rate which in turn affects the computed initiation interval in the SMS code and leads to failure to modulo schedule the single loop in sms-3.c and 1 of the 3 loops in sms-6.c. This patch adds that option for powerpc and is a precursor to a patch I'll submit shortly that enables -fsched-pressure by default for the rs6000 port.
> 
> I have verified the updated tests pass both before and after my patch to enable -fsched-pressure is applied. Ok for trunk?

Yes please.  Thanks,


Segher


> testsuite/ChangeLog:
> 2016-12-20  Pat Haugen  <pthaugen@us.ibm.com>
> 
> 	* gcc.dg/sms-3.c: Add -fno-sched-pressure for powerpc.
> 	* gcc.dg/sms-6.c: Likewise.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-12-20 17:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-20 17:27 [PATCH, testsuite] Add -fno-sched-pressure to a couple sms-*.c tests for powerpc Pat Haugen
2016-12-20 18:17 ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).