From: "Martin Liška" <mliska@suse.cz>
To: Luis Machado <luis.machado@linaro.org>,
law@redhat.com, Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [stage1][PATCH] Add gcc_assert that &global_options are not dirty modified.
Date: Thu, 18 Jun 2020 17:40:16 +0200 [thread overview]
Message-ID: <98b743ce-b5b4-7d9c-91c5-d5528b31b518@suse.cz> (raw)
In-Reply-To: <4ee4da50-70b6-9a27-1e54-693a1a6ba390@linaro.org>
I see the following ICE for aarch64 kernel build:
$ cat neon.i
#pragma GCC push_options
#pragma GCC target "arch=armv8.2-a+bf16"
#pragma GCC pop_options
$ ./xgcc -B. ~/Programming/testcases/neon.i -c -mbranch-protection=pac-ret
/home/marxin/Programming/testcases/neon.i:3:9: internal compiler error: ‘global_options’ are modified in local context
3 | #pragma GCC pop_options
| ^~~
0x1111f73 cl_optimization_compare(gcc_options*, gcc_options*)
/dev/shm/objdir3/gcc/options-save.c:11996
0xb02ff4 handle_pragma_pop_options
/home/marxin/Programming/gcc/gcc/c-family/c-pragma.c:1090
0xb03953 c_invoke_pragma_handler(unsigned int)
/home/marxin/Programming/gcc/gcc/c-family/c-pragma.c:1512
0xa5ae39 c_parser_pragma
/home/marxin/Programming/gcc/gcc/c/c-parser.c:12544
0xa3f9fc c_parser_external_declaration
/home/marxin/Programming/gcc/gcc/c/c-parser.c:1754
0xa3f5c8 c_parser_translation_unit
/home/marxin/Programming/gcc/gcc/c/c-parser.c:1646
0xa7db4d c_parse_file()
/home/marxin/Programming/gcc/gcc/c/c-parser.c:21822
0xafd0b6 c_common_parse_file()
/home/marxin/Programming/gcc/gcc/c-family/c-opts.c:1190
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
#1 0x0000000001111f74 in cl_optimization_compare (ptr1=0x2d5e3f0, ptr2=0x2cc7760 <global_options>) at options-save.c:11996
11996 internal_error ("%<global_options%> are modified in local context");
(gdb) p ptr2->x_aarch64_branch_protection_string
$2 = 0x2cf52e0 "pac-ret"
(gdb) p ptr1->x_aarch64_branch_protection_string
$3 = 0x2d3c190 "pac-ret"
│11995 if (ptr1->x_aarch64_branch_protection_string != ptr2->x_aarch64_branch_protection_string)
>│11996 internal_error ("%<global_options%> are modified in local context");
This is bogus as these are 2 strings that are equal. Let me fix it.
Martin
next prev parent reply other threads:[~2020-06-18 15:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 8:56 Martin Liška
2020-03-19 9:09 ` Jakub Jelinek
2020-03-19 15:32 ` Martin Liška
2020-03-19 15:47 ` Jakub Jelinek
2020-03-19 16:13 ` Martin Sebor
2020-03-20 15:40 ` Martin Liška
2020-03-20 15:43 ` Jakub Jelinek
2020-03-20 15:55 ` Martin Liška
2020-05-21 12:04 ` Martin Liška
2020-06-09 21:01 ` Jeff Law
2020-06-18 11:32 ` Luis Machado
2020-06-18 12:21 ` Martin Liška
2020-06-18 15:02 ` Jeff Law
2020-06-18 15:36 ` Martin Liška
2020-06-24 7:44 ` Martin Liška
2020-06-18 15:40 ` Martin Liška [this message]
2020-06-18 15:47 ` Luis Machado
2020-06-18 16:02 ` Martin Liška
2020-06-18 17:18 ` Luis Machado
2020-06-18 18:34 ` Martin Liška
2020-06-18 21:24 ` Luis Machado
2020-06-24 7:25 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b743ce-b5b4-7d9c-91c5-d5528b31b518@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).