* [committed] csky: Fix up csky_setup_incoming_varargs [PR114175]
@ 2024-03-20 16:04 Jakub Jelinek
2024-03-20 17:55 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2024-03-20 16:04 UTC (permalink / raw)
To: gcc-patches
Hi!
Like for x86-64, alpha or rs6000, csky seems to be affected too.
Just visually checked differences in c23-stdarg-9.c assembly in a cross
without/with the patch, committed to trunk.
2024-03-20 Jakub Jelinek <jakub@redhat.com>
PR target/114175
* config/csky/csky.cc (csky_setup_incoming_varargs): Only skip
csky_function_arg_advance for TYPE_NO_NAMED_ARGS_STDARG_P functions
if arg.type is NULL.
--- gcc/config/csky/csky.cc.jj 2024-01-03 11:51:47.818505143 +0100
+++ gcc/config/csky/csky.cc 2024-03-20 16:09:23.765822660 +0100
@@ -2090,7 +2090,8 @@ csky_setup_incoming_varargs (cumulative_
cfun->machine->uses_anonymous_args = 1;
local_cum = *pcum;
- if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl)))
+ if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl))
+ || arg.type != NULL_TREE)
csky_function_arg_advance (local_cum_v, arg);
regs_to_push = CSKY_NPARM_REGS - local_cum.reg;
if (regs_to_push)
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [committed] csky: Fix up csky_setup_incoming_varargs [PR114175]
2024-03-20 16:04 [committed] csky: Fix up csky_setup_incoming_varargs [PR114175] Jakub Jelinek
@ 2024-03-20 17:55 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2024-03-20 17:55 UTC (permalink / raw)
To: Jakub Jelinek, gcc-patches
On 3/20/24 10:04 AM, Jakub Jelinek wrote:
> Hi!
>
> Like for x86-64, alpha or rs6000, csky seems to be affected too.
>
> Just visually checked differences in c23-stdarg-9.c assembly in a cross
> without/with the patch, committed to trunk.
>
> 2024-03-20 Jakub Jelinek <jakub@redhat.com>
>
> PR target/114175
> * config/csky/csky.cc (csky_setup_incoming_varargs): Only skip
> csky_function_arg_advance for TYPE_NO_NAMED_ARGS_STDARG_P functions
> if arg.type is NULL.
I'm not set up to do execution tests with glibc+qemu. So for csky &
nios2 we just have the the build successes.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-20 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-20 16:04 [committed] csky: Fix up csky_setup_incoming_varargs [PR114175] Jakub Jelinek
2024-03-20 17:55 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).