From: Tom de Vries <Tom_deVries@mentor.com>
To: Vladimir Makarov <vmakarov@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: patch to fix PR82353
Date: Wed, 13 Dec 2017 12:35:00 -0000 [thread overview]
Message-ID: <98df25f2-0282-7eca-f6d9-c320c023ec0d@mentor.com> (raw)
In-Reply-To: <5794f39e-42ef-66da-e7f5-270ebc54cdf2@redhat.com>
On 10/16/2017 10:38 PM, Vladimir Makarov wrote:
> This is another version of the patch to fix
>
> Â Â https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82353
>
> The patch was successfully bootstrapped on x86-64 with Go and Ada.
>
> Committed as rev. 253796.
Hi Vladimir,
AFAIU this bit of the patch makes sure that the flags register show up
in the bb_livein of the bb in which it's used (and not defined before
the use), but not in the bb_liveout of the predecessors of that bb.
I wonder if that's a compile-speed optimization, or an oversight.
[ I ran into a similar problem for target gcn here (
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83327 ) with the
spill_class hook. I've posted a tentative fix in that PR, which
piggybacks on this fix, but needed a few extra bits to make sure that
inter-bb propagation was done:
- a bit at the end of process_bb_lives to detect the liveness change and
then set live_change_p which make sure the propagation is run.
- a bit in lra_create_live_ranges_1 to unmask the registers we want to
propagate in all_hard_regs_bitmap.
]
Thanks,
- Tom
> Index: lra-lives.c
> ===================================================================
> --- lra-lives.c (revision 253685)
> +++ lra-lives.c (working copy)
> @@ -220,6 +220,9 @@ lra_intersected_live_ranges_p (lra_live_
> return false;
> }
>
> +/* The corresponding bitmaps of BB currently being processed. */
> +static bitmap bb_killed_pseudos, bb_gen_pseudos;
> +
> /* The function processing birth of hard register REGNO. It updates
> living hard regs, START_LIVING, and conflict hard regs for living
> pseudos. Conflict hard regs for the pic pseudo is not updated if
> @@ -243,6 +246,8 @@ make_hard_regno_born (int regno, bool ch
> || i != REGNO (pic_offset_table_rtx))
> #endif
> SET_HARD_REG_BIT (lra_reg_info[i].conflict_hard_regs, regno);
> + if (fixed_regs[regno])
> + bitmap_set_bit (bb_gen_pseudos, regno);
> }
>
> /* Process the death of hard register REGNO. This updates
> @@ -255,6 +260,11 @@ make_hard_regno_dead (int regno)
> return;
> sparseset_set_bit (start_dying, regno);
> CLEAR_HARD_REG_BIT (hard_regs_live, regno);
> + if (fixed_regs[regno])
> + {
> + bitmap_clear_bit (bb_gen_pseudos, regno);
> + bitmap_set_bit (bb_killed_pseudos, regno);
> + }
> }
>
> /* Mark pseudo REGNO as living at program point POINT, update conflicting
> @@ -299,9 +309,6 @@ mark_pseudo_dead (int regno, int point)
> }
> }
>
> -/* The corresponding bitmaps of BB currently being processed. */
> -static bitmap bb_killed_pseudos, bb_gen_pseudos;
> -
> /* Mark register REGNO (pseudo or hard register) in MODE as live at
> program point POINT. Update BB_GEN_PSEUDOS.
> Return TRUE if the liveness tracking sets were modified, or FALSE
>
next prev parent reply other threads:[~2017-12-13 12:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 20:39 Vladimir Makarov
2017-12-13 12:35 ` Tom de Vries [this message]
2017-12-14 17:01 ` Vladimir Makarov
2017-12-15 11:26 ` [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs Tom de Vries
2017-12-18 16:57 ` Vladimir Makarov
2018-01-08 16:52 ` Tom de Vries
2018-02-26 9:32 ` Tom de Vries
2018-02-26 11:01 ` Matthew Fortune
2018-02-26 13:46 ` Tom de Vries
2018-02-26 14:17 ` Matthew Fortune
2018-02-28 22:18 ` Matthew Fortune
-- strict thread matches above, loose matches on Subject: below --
2017-10-12 11:38 patch to fix PR82353 Uros Bizjak
2017-10-11 19:51 Vladimir Makarov
2017-10-11 21:17 ` Jakub Jelinek
2017-10-11 22:54 ` Vladimir Makarov
2017-10-12 17:05 ` Jakub Jelinek
2017-10-12 17:11 ` Vladimir Makarov
2017-10-12 17:34 ` Jakub Jelinek
2017-10-13 18:49 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98df25f2-0282-7eca-f6d9-c320c023ec0d@mentor.com \
--to=tom_devries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).