From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0D5DE3858D34 for ; Tue, 30 Apr 2024 21:00:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D5DE3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D5DE3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510850; cv=none; b=W7JmoNjEbsw06HZhZ0DkOknG/FTVF2J0Au6X1KW0s/9nF18FkkQ/sZ57JWTBjb797d1t8mLrgmgj8d/2UqXyCeKnph9e5MU3s6MkomEvG95giK7kVj9EueH2pq01AiUAgCXJ2ixoMWA8rWJ6X+1xuvwwPTYaLJTaVw3swKi3veg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510850; c=relaxed/simple; bh=B5UPyKM7Xdn7dr+7kRxYk1JI0FkeE0mx2ckdXqecVdo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xo4lvR7I5Wx2OIoHbzckZmpiZLFVRsPavNTUhce3flqkoWCogkQBT+X8Tg5pv7njCeWVfSSVXoiqGsnx62Ov4zL+EFqXBx1LavMG0bKSG697QANAYiEAeGJaLNm9lxoMEFtwb5ivn2lOkXXyIiGWiuHBnjQJwtSFsIW1EFx4wWc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714510846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KYekECfE926oWKZYDZ02W+ko93si1om3jMQzn9aZfhY=; b=bBQ3yeulzqEVc5lBxitZIKaSacGQWmQ8SjP4X5DoV8rSkaBuVh+7hB90UerYwzyto3k04Q BwK7B1wt31d/UlG8gR7DPE1a18/2Hcc8MTg4S50B/HEpdgwZ0Vhfi2YKMqmpCDT+EO6X9c ZoSf8+aThirxMH/1US1QtSx+2lU0jTk= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-mkOLKlXsOECYTKg2SiOGMA-1; Tue, 30 Apr 2024 17:00:44 -0400 X-MC-Unique: mkOLKlXsOECYTKg2SiOGMA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a0b7ebba6cso59694336d6.0 for ; Tue, 30 Apr 2024 14:00:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714510843; x=1715115643; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KYekECfE926oWKZYDZ02W+ko93si1om3jMQzn9aZfhY=; b=UHDBUHTnlE7zgcSs60klvukmvQketkO1oqN5p3ZnlMy6TZUA37ynykZJrtjMNKZefr aS9TlCmeyloVzeOLsI7IiY+EzKtDSNcjsQRrDx+bB15NOZf0Qnd4A3wlEVV8Lj3KVKUr ft3OAPNY8EAafu7jrAgD5YS3MwkFbgxAmFhrRb2n660JdXTmQOSe6HyakKJ+M938P7vy enF84XIkE9qE2oje6+DrrNZ+8b9vkTaqeU0CtOzbojneK2Etip2rJ2nHucoO5laTvAGl 0ANTmI7NbIypXfxSlyvQet3tpcj6CfDmesbkqR6QJYC5GOH3qlbsuY0VkztaMIqRiW5H 7ZlA== X-Forwarded-Encrypted: i=1; AJvYcCVTR++OHVh4qfNJVxV3zSAvIYLZbpBSi8dq5NvdkNIvkRjTtlHAc3jNoRE6cJ7yRfFAQqKbFPEfGsLnl8WHbuO+vfXVZ85+oA== X-Gm-Message-State: AOJu0YxYEB2fuP6Ee2tN068Qzd2z6h1t+GboiXfnv3jNf592BCKFSZqH iRXKSs58recgOzxV5BjnrM7xWjHOwNoP+2RM6VZ5vtHZdBCXpbCdYJNZCfIq0EbanRglfQWQJCu o9EhS9DtqOfCLiPZLBMWLd54k5e3VwWrR4xuAf3+0Ic9boRAz1MSm6IiOojfN6AU= X-Received: by 2002:ad4:4ea7:0:b0:6a0:c787:5e1d with SMTP id ed7-20020ad44ea7000000b006a0c7875e1dmr665031qvb.7.1714510843700; Tue, 30 Apr 2024 14:00:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3mLZK6yD32hQIfKE6luKuwR86iep/HNZ9/h9kkF/117ov5OQA7nbu5XcqdRZZZNV/gGJV0Q== X-Received: by 2002:ad4:4ea7:0:b0:6a0:c787:5e1d with SMTP id ed7-20020ad44ea7000000b006a0c7875e1dmr665022qvb.7.1714510843397; Tue, 30 Apr 2024 14:00:43 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id y13-20020ad445ad000000b0069b4f48003bsm4739345qvu.100.2024.04.30.14.00.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 14:00:42 -0700 (PDT) Message-ID: <98f302b6-7912-4e5c-9d21-a2cffe32b6ac@redhat.com> Date: Tue, 30 Apr 2024 17:00:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 15/26] c++: Implement __add_lvalue_reference built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240221093616.4001742-1-kmatsui@gcc.gnu.org> <20240228192843.188979-1-kmatsui@gcc.gnu.org> <20240228192843.188979-16-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240228192843.188979-16-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 11:26, Ken Matsui wrote: > This patch implements built-in trait for std::add_lvalue_reference. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __add_lvalue_reference. > * semantics.cc (finish_trait_type): Handle > CPTK_ADD_LVALUE_REFERENCE. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of > __add_lvalue_reference. > * g++.dg/ext/add_lvalue_reference.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 8 +++++++ > .../g++.dg/ext/add_lvalue_reference.C | 21 +++++++++++++++++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > 4 files changed, 33 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/add_lvalue_reference.C > > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 933c8bcbe68..9a27dca4ea3 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -48,6 +48,7 @@ > #define DEFTRAIT_TYPE_DEFAULTED > #endif > > +DEFTRAIT_TYPE (ADD_LVALUE_REFERENCE, "__add_lvalue_reference", 1) > DEFTRAIT_TYPE (ADD_POINTER, "__add_pointer", 1) > DEFTRAIT_EXPR (HAS_NOTHROW_ASSIGN, "__has_nothrow_assign", 1) > DEFTRAIT_EXPR (HAS_NOTHROW_CONSTRUCTOR, "__has_nothrow_constructor", 1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 078424dac23..05f5b62f9df 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12776,6 +12776,14 @@ finish_trait_type (cp_trait_kind kind, tree type1, tree type2, > > switch (kind) > { > + case CPTK_ADD_LVALUE_REFERENCE: > + if (VOID_TYPE_P (type1) > + || (FUNC_OR_METHOD_TYPE_P (type1) > + && (type_memfn_quals (type1) != TYPE_UNQUALIFIED > + || type_memfn_rqual (type1) != REF_QUAL_NONE))) > + return type1; > + return cp_build_reference_type (type1, /*rval=*/false); > + > case CPTK_ADD_POINTER: > if (FUNC_OR_METHOD_TYPE_P (type1) > && (type_memfn_quals (type1) != TYPE_UNQUALIFIED > diff --git a/gcc/testsuite/g++.dg/ext/add_lvalue_reference.C b/gcc/testsuite/g++.dg/ext/add_lvalue_reference.C > new file mode 100644 > index 00000000000..8fe1e0300e5 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/add_lvalue_reference.C > @@ -0,0 +1,21 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +class ClassType { }; > + > +SA(__is_same(__add_lvalue_reference(int), int&)); > +SA(__is_same(__add_lvalue_reference(int&), int&)); > +SA(__is_same(__add_lvalue_reference(const int), const int&)); > +SA(__is_same(__add_lvalue_reference(int*), int*&)); > +SA(__is_same(__add_lvalue_reference(ClassType&), ClassType&)); > +SA(__is_same(__add_lvalue_reference(ClassType), ClassType&)); > +SA(__is_same(__add_lvalue_reference(int(int)), int(&)(int))); > +SA(__is_same(__add_lvalue_reference(int&&), int&)); > +SA(__is_same(__add_lvalue_reference(ClassType&&), ClassType&)); > +SA(__is_same(__add_lvalue_reference(void), void)); > +SA(__is_same(__add_lvalue_reference(const void), const void)); > +SA(__is_same(__add_lvalue_reference(bool(int) const), bool(int) const)); > +SA(__is_same(__add_lvalue_reference(bool(int) &), bool(int) &)); > +SA(__is_same(__add_lvalue_reference(bool(int) const &&), bool(int) const &&)); > +SA(__is_same(__add_lvalue_reference(bool(int)), bool(&)(int))); > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index 85b74bd676b..3fca9cfabcc 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -2,6 +2,9 @@ > // { dg-do compile } > // Verify that __has_builtin gives the correct answer for C++ built-ins. > > +#if !__has_builtin (__add_lvalue_reference) > +# error "__has_builtin (__add_lvalue_reference) failed" > +#endif > #if !__has_builtin (__add_pointer) > # error "__has_builtin (__add_pointer) failed" > #endif