public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [committed] Remove -m8byte-align as a standard multilib on v8 port
Date: Wed, 27 Jun 2018 14:28:00 -0000	[thread overview]
Message-ID: <98fd0d37-0480-023e-af6a-cc10bea7f45a@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]


The v850 port has an option to increase alignment of objects.  However,
from my testing it looks fundamentally broken.  I suspect some kind of
dynamic stack/frame realignment is necessary for this to work properly.

As it stands using -m8byte-align can result in corrupted stack frames.

I'm leaving the option in the v8 port, but removing it from the standard
set of multilibs to be built.

Installing on the trunk,

Jeff

[-- Attachment #2: P --]
[-- Type: text/plain, Size: 1263 bytes --]

commit 0ae463d575053c83d2bfba3656a58a406787822d
Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Jun 27 14:27:44 2018 +0000

            * config/v850/t-v850 (MULTILIB_OPTIONS): Remove 8byte-align.
            (MULTILIB_DIRNAMES): Similarly.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@262185 138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index b9be9d55325..2d0fd08cb49 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2018-06-27  Jeff Law  <law@redhat.com>
+
+	* config/v850/t-v850 (MULTILIB_OPTIONS): Remove 8byte-align.
+	(MULTILIB_DIRNAMES): Similarly.
+
 2018-06-27  Eric Botcazou  <ebotcazou@adacore.com>
 
 	* gimple.h (gimple_return_retbnd): Delete.
diff --git a/gcc/config/v850/t-v850 b/gcc/config/v850/t-v850
index a7af1be3a19..984993a4fdf 100644
--- a/gcc/config/v850/t-v850
+++ b/gcc/config/v850/t-v850
@@ -17,8 +17,8 @@
 # <http://www.gnu.org/licenses/>.
 
 # Create target-specific versions of the libraries
-MULTILIB_OPTIONS  = m8byte-align mgcc-abi msoft-float
-MULTILIB_DIRNAMES =  8byte        gcc-abi  soft-float
+MULTILIB_OPTIONS  = mgcc-abi msoft-float
+MULTILIB_DIRNAMES =  gcc-abi  soft-float
 
 MULTILIB_OPTIONS  += mv850e3v5
 MULTILIB_DIRNAMES +=  v850e3v5

                 reply	other threads:[~2018-06-27 14:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98fd0d37-0480-023e-af6a-cc10bea7f45a@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).