public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH]: Remove #ifdef PCC_BITFIELD_TYPE_MATTERS check from dwarf2out.c
@ 2018-12-05 20:56 Uros Bizjak
  2018-12-05 23:44 ` Jeff Law
  0 siblings, 1 reply; 2+ messages in thread
From: Uros Bizjak @ 2018-12-05 20:56 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

This macro is always defined through defaults.h. We can remove #ifdef
check from dwarf2out.c

2018-12-05  Uros Bizjak  <ubizjak@gmail.com>

    * dwarf2out.c (field_byte_offset): Remove
    #ifdef PCC_BITFIELD_TYPE_MATTERS check.

Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.

OK for mainline?

Uros.

[-- Attachment #2: p.diff.txt --]
[-- Type: text/plain, Size: 804 bytes --]

Index: dwarf2out.c
===================================================================
--- dwarf2out.c	(revision 266788)
+++ dwarf2out.c	(working copy)
@@ -18985,7 +18985,6 @@ field_byte_offset (const_tree decl, struct vlr_con
   if (TREE_CODE (DECL_FIELD_BIT_OFFSET (decl)) != INTEGER_CST)
     return NULL;
 
-#ifdef PCC_BITFIELD_TYPE_MATTERS
   /* We used to handle only constant offsets in all cases.  Now, we handle
      properly dynamic byte offsets only when PCC bitfield type doesn't
      matter.  */
@@ -19100,7 +19099,6 @@ field_byte_offset (const_tree decl, struct vlr_con
       tree_result = wide_int_to_tree (sizetype, object_offset_in_bytes);
     }
   else
-#endif /* PCC_BITFIELD_TYPE_MATTERS */
     tree_result = byte_position (decl);
 
   if (ctx->variant_part_offset != NULL_TREE)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH]: Remove #ifdef PCC_BITFIELD_TYPE_MATTERS check from dwarf2out.c
  2018-12-05 20:56 [PATCH]: Remove #ifdef PCC_BITFIELD_TYPE_MATTERS check from dwarf2out.c Uros Bizjak
@ 2018-12-05 23:44 ` Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2018-12-05 23:44 UTC (permalink / raw)
  To: Uros Bizjak, gcc-patches

On 12/5/18 1:56 PM, Uros Bizjak wrote:
> This macro is always defined through defaults.h. We can remove #ifdef
> check from dwarf2out.c
> 
> 2018-12-05  Uros Bizjak  <ubizjak@gmail.com>
> 
>     * dwarf2out.c (field_byte_offset): Remove
>     #ifdef PCC_BITFIELD_TYPE_MATTERS check.
> 
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
> 
> OK for mainline?
OK
jeff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-05 23:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-05 20:56 [PATCH]: Remove #ifdef PCC_BITFIELD_TYPE_MATTERS check from dwarf2out.c Uros Bizjak
2018-12-05 23:44 ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).