From: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
To: richard.sandiford <richard.sandiford@arm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, rguenther <rguenther@suse.de>
Subject: Re: Re: [PATCH] DOC: Update COND_LEN document
Date: Thu, 26 Oct 2023 17:55:03 +0800 [thread overview]
Message-ID: <99BB8FA43BD7BA53+2023102617550309110023@rivai.ai> (raw)
In-Reply-To: <mptbkclka6o.fsf@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
Oh. I made a mistake here.
Forget about my last email.
https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634376.html
Here is the V2 address comments as you suggested.
Could you take a look ?
Thanks.
juzhe.zhong@rivai.ai
From: Richard Sandiford
Date: 2023-10-26 17:25
To: Juzhe-Zhong
CC: gcc-patches; rguenther
Subject: Re: [PATCH] DOC: Update COND_LEN document
Juzhe-Zhong <juzhe.zhong@rivai.ai> writes:
> As Richard's suggested. We need to adapt doc for cond_len operations.
>
> gcc/ChangeLog:
>
> * doc/md.texi: Update document.
Thanks for addressing my comment. I was thinking about the
pseudo code though. Currently it is:
for (i = 0; i < ops[4] + ops[5]; i++)
op0[i] = op1[i] ? @var{op} op2[i] : op3[i];
but I think the outcome of the discussion was that it should instead be:
for (i = 0; i < GET_MODE_NUNITS (@var{m}); i++)
op0[i] = (i < ops[4] + ops[5] && op1[i]
? @var{op} op2[i]
: op3[i]);
to match internal-fn.cc. The binary and ternary optabs would need a
similar update.
Thanks,
Richard
> ---
> gcc/doc/md.texi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi
> index daa318ee3da..dd2c26edf7b 100644
> --- a/gcc/doc/md.texi
> +++ b/gcc/doc/md.texi
> @@ -7400,6 +7400,8 @@ form of @samp{@var{op}@var{mode}2}.
> @itemx @samp{cond_len_lshr@var{mode}}
> When operand 1 is true and element index < operand 5 + operand 6, perform an operation on operands 2 and 3 and
> store the result in operand 0, otherwise store operand 4 in operand 0.
> +operand 4 should be well-defined value for reduction situation, and undefined value for some arithmetic operations
> +e.g. integer division.
> The operation only works for the operands are vectors.
>
> @smallexample
prev parent reply other threads:[~2023-10-26 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 3:43 Juzhe-Zhong
2023-10-26 9:25 ` Richard Sandiford
2023-10-26 9:44 ` juzhe.zhong
2023-10-26 9:55 ` juzhe.zhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99BB8FA43BD7BA53+2023102617550309110023@rivai.ai \
--to=juzhe.zhong@rivai.ai \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).