From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6104 invoked by alias); 25 Apr 2017 14:24:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5925 invoked by uid 89); 25 Apr 2017 14:24:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Apr 2017 14:24:38 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E2B1EA08ED; Tue, 25 Apr 2017 14:24:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E2B1EA08ED Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E2B1EA08ED Received: from localhost.localdomain (ovpn-122-222.rdu2.redhat.com [10.10.122.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76BEB7DFC0; Tue, 25 Apr 2017 14:24:33 +0000 (UTC) Subject: Re: [PATCH] avoid assuming all integers are representable in HOST_WIDE_INT (PR #80497) To: Martin Sebor , Gcc Patch List References: From: Jeff Law Message-ID: <99c3fe72-974a-7272-20e0-45022891a9a1@redhat.com> Date: Tue, 25 Apr 2017 14:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg01202.txt.bz2 On 04/24/2017 05:35 PM, Martin Sebor wrote: > Bug 80497 brings to light that my fix for PR 80364 where I corrected > the handling for int128_t was incomplete. I handled the non-constant > case but missed the INTEGER_CST case just a few lines above. The > attached patch also corrects that problem plus one more elsewhere > in the pass. > > Both of the changes in this patch seem safe enough to make even now > in GCC 7 but since they are ice-on-invalid-code perhaps it's better > to wait for 7.1? > > Martin > > gcc-80497.diff > > > PR tree-optimization/80497 - ICE at -O1 and above on valid code on x86_64-linux-gnu in tree_to_uhwi > > gcc/ChangeLog: > > PR tree-optimization/80497 > * gimple-ssa-sprintf.c (get_int_range): Avoid assuming all integer > constants are representable in HOST_WIDE_INT. > (parse_directive): Ditto. > > gcc/testsuite/ChangeLog: > > PR tree-optimization/80497 > * gcc.dg/tree-ssa/builtin-sprintf-warn-17.c: New test. OK for the trunk. Jakub's call on when it's OK for the branch -- one can easily argue this is a regression. jeff