From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 2A71F3858D32 for ; Sun, 12 Mar 2023 19:32:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A71F3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,254,1673942400"; d="scan'208";a="101317462" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 12 Mar 2023 11:32:50 -0800 IronPort-SDR: dfBxurT5QJeNlnT9jlOoUhHBr+HoCIBGuicNCU62MMcJfM3AcQWbuDdFG1R9u2XlVi8IfcGEMp RjTHP9amItMpsMzuSiiot91cSTzFEVSx811ZR2XQ+Bx4hQ4IsiJpJeHfSM3i9b3DChzgHmJG+t d5EZxSsPHmqUPr35ZSUmwcCtoJRt5jmEFeHhedtvin5399lzXIl7Q4oY9kQkJbsndLHJtXomm7 zCuqNSdtTNrgPtdPPbXMZ3F9opJRXDZUfA5YmW5aV6LXc0qJqoFW5wb2bcGSe57Mpc+U7PpwRw 61M= Message-ID: <99de2404-430d-954a-7f0c-63c98238aed1@codesourcery.com> Date: Sun, 12 Mar 2023 13:32:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] docs: Fix double 'See' in zero-length-bounds docs. Content-Language: en-US To: Bernhard Reutner-Fischer , Sean Bright , Gcc-patches References: <6D3851AF-0A1B-4E5D-B100-F63900CFFE54@gmail.com> <11A5528F-9B3F-4F35-8CEF-BA2FF28DA3DA@gmail.com> From: Sandra Loosemore In-Reply-To: <11A5528F-9B3F-4F35-8CEF-BA2FF28DA3DA@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: svr-orw-mbx-10.mgc.mentorg.com (147.34.90.210) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/12/23 01:12, Bernhard Reutner-Fischer via Gcc-patches wrote: > On 12 March 2023 03:47:08 CET, Sean Bright via Gcc-patches wrote: >> On 3/11/2023 6:39 PM, Bernhard Reutner-Fischer wrote: >>> On 11 March 2023 18:33:46 CET, Sean Bright via Gcc-patches wrote: >>>> Hi, >>>> >>>> This fixes a minor issue where the zero-length-bound docs read "See See >>>> Zero Length." >>>> >>>> gcc/ChangeLog: >>>>     * doc/invoke.texi (Warning Options): Remove errant 'See' >>>>     before @xref. >>>> --- >>>>  gcc/doc/invoke.texi | 2 +- >>>>  1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi >>>> index 3a6a97862b0..174d160dd6c 100644 >>>> --- a/gcc/doc/invoke.texi >>>> +++ b/gcc/doc/invoke.texi >>>> @@ -8345,7 +8345,7 @@ conversions the warnings @option{-Wno-int-to-pointer-cast} and >>>>  @item -Wzero-length-bounds >>>>  Warn about accesses to elements of zero-length array members that might >>>>  overlap other members of the same object.  Declaring interior zero-length >>>> -arrays is discouraged because accesses to them are undefined.  See >>>> +arrays is discouraged because accesses to them are undefined. >>>>  @xref{Zero Length}. >>> >>> I'm not a native speaker, but wouldn't it be better to talk about singular access, i.e. s/accesses/access/ in both cases? >>> >>> thanks, >> >> As a native speaker it does not feel ergonomic to use 'accesses' in this >> context but it also does not feel objectively wrong. I'm happy to >> provide a follow-up patch if you feel strongly about it. > > I'd prefer the singular but defer to the documentation maintainers. I think the patch is fine as posted, with "accesses/are". Sean, do you need somebody to push this for you? -Sandra