public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: gcc-patches@gcc.gnu.org
Cc: Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v2] libgcc: Add support for --disable-libgcov
Date: Fri, 01 Jun 2018 12:11:00 -0000	[thread overview]
Message-ID: <99e19880-9cd6-8895-5e26-21825a8f6021@prevas.dk> (raw)
In-Reply-To: <20180525213432.1125-1-rasmus.villemoes@prevas.dk>

On 2018-05-25 23:34, Rasmus Villemoes wrote:

[...]
> add an option for disabling build and install of libgcov.
> 
> 
> 2018-05-25  Rasmus Villemoes  <rasmus.villemoes@prevas.dk>
> 
> gcc/doc/
> 	* install.texi: Document --disable-libgcov.

I see I messed up that Changelog fragment, is should have been "gcc/"
and "* doc/install.texi".

Anyway, thinking a bit more about this, it might be better to use
--disable-gcov and have that also disable building the gcov tools.
There's actually already comments like

  # Install gcov if it was compiled.

and associated logic in gcc/Makefile, but I don't see how gcov could not
be compiled: This is in the install-common target, which depends on
native, which depends on $(LANGUAGES), which unconditionally contains
gcov$(exeext) and friends.

Thoughts?

Rasmus

  reply	other threads:[~2018-06-01 12:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 13:06 [PATCH] " Rasmus Villemoes
2018-05-25 16:40 ` Joseph Myers
2018-05-25 21:35   ` [PATCH v2] " Rasmus Villemoes
2018-06-01 12:11     ` Rasmus Villemoes [this message]
2018-06-11  7:26       ` [PATCH v3] add support for --disable-gcov Rasmus Villemoes
2018-06-12 21:18         ` Jeff Law
2018-06-27 19:23           ` Rainer Orth
2018-06-27 21:01             ` Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99e19880-9cd6-8895-5e26-21825a8f6021@prevas.dk \
    --to=rasmus.villemoes@prevas.dk \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).