Re: [PATCH v2 2/3] RISC-V: Add Zalrsc and Zaamo testsuite support

[Patrick O'Neill <patrick@rivosinc.com>]

On 6/7/24 16:04, Jeff Law wrote:
>
>
> On 6/3/24 3:53 PM, Patrick O'Neill wrote:
>> Convert testsuite infrastructure to use Zalrsc and Zaamo rather than A.
>>
>> gcc/testsuite/ChangeLog:
>>
>>     * gcc.target/riscv/amo-table-a-6-amo-add-1.c: Use Zaamo rather 
>> than A.
>>     * gcc.target/riscv/amo-table-a-6-amo-add-2.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-amo-add-3.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-amo-add-4.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-amo-add-5.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-1.c: Use Zalrsc 
>> rather
>>     than A.
>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-2.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-3.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-4.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-5.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-6.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-7.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-1.c: Use Zaamo 
>> rather
>>     than A.
>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-2.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-3.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-4.c: Ditto.
>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-5.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-amo-add-1.c: Add Zaamo option.
>>     * gcc.target/riscv/amo-table-ztso-amo-add-2.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-amo-add-3.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-amo-add-4.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-amo-add-5.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-1.c: Use 
>> Zalrsc rather
>>     than A.
>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-2.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-3.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-4.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-5.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-6.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-7.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-1.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-2.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-3.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-4.c: Ditto.
>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-5.c: Ditto.
>>     * lib/target-supports.exp: Add testsuite infrastructure support for
>>     Zaamo and Zalrsc.
> So there's a lot of whitespace changes going on in target-supports.exp 
> that make it harder to find the real changes.
>
> There's always a bit of a judgement call for that kind of thing. This 
> one probably goes past would generally recommend, meaning that the 
> formatting stuff would be a separate patch.
>
> A reasonable starting point would be if you're not changing the 
> function in question, then fixing formatting in it probably should be 
> a distinct patch.
>
> You probably should update the docs in sourcebuild.texi for the new 
> target-supports tests.
>
> So OK for the trunk (including the whitespace fixes) with a suitable 
> change to sourcebuild.texi.

Sorry about that - the whitespace changes snuck in when resolving a 
merge conflict and were unintentional.

I'll post a v3 with the sourcebuild.texi changes and patch 3/3 changes 
later today.

I'll split the target-supports.exp trailing whitespace removal into a 
separate patch after this series lands.

Patrick

>
> jeff