From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 34BE73858D39 for ; Mon, 10 Jun 2024 16:39:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34BE73858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34BE73858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::530 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718037571; cv=none; b=vGPUF9c1kpemkCnjVbKf93ZQyMItzpuFSjK2cObaq/4fO7YuCgXmdnJevSMHsAcgR1+wXgzSD9gF+XfJltyaod78Z2y9IR9oZ4RSAK9E1bPH+O2M6/TZKN13mh3YIK0o412gXQ00czxys1ZBzIOusfkWuntUqpPjBwiMG2zI/as= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718037571; c=relaxed/simple; bh=zL1WMBevO8HYgQOYEgJRb8BYtrrs4x7mjQ8TlKoiDOQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WsWJ2Vgkn7wlUplY5/JPnOiTCBeuoai6/4edg1uCgUIzOw+XIKMsWxCQcaDX+JOoKxp5uo8HkOjFTCPOdPWTQPbhi4Bp3CrrYsyzTVQJ6DPQsIE4uaN3SiZUo5s92op+mSJzoOtr4zAQM6FyFu/jD73vPTA0SgNy8MHagmWUQCQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-656d8b346d2so3225187a12.2 for ; Mon, 10 Jun 2024 09:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1718037568; x=1718642368; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=heu8eskLWtUFrOHbtgxZD6rN9wEjgSiJ4/wEuinb6QY=; b=3J9I0ZLTYj7janAmzN4ETmR5Fzolx7U9LDZ3IN5gACyFuXVD8yTf3S+6DWocPHaEeA 6zmhtx3EWlGh11NSkaisrWby7zw3u6tg/fF/sxlDBHF/DqFgEVih/zNKN0anmyjoDOyy BLJuRJJfg6AyO5FmJUJZ1bX8zhCN9R/1MHFZSsOfv4jMJ+Xddj6S9bKY0vq7iQTC9jkB aUtSYNToiRDUBwxW/K0TtsVv6jiuY3OiwA4Ob4XSweY7jfbK4kLA33lcqROX2m/iP9ZW ZiaTs+jJJT65SKZdtgLcBJ1GiWB2K/Mzz0ea/3GbgswsweXR7Cxz0dPXARa+3Bvthw/p u07g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718037568; x=1718642368; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=heu8eskLWtUFrOHbtgxZD6rN9wEjgSiJ4/wEuinb6QY=; b=FI+uwVinLFaAtSEJ+lcBXjR0j0xu10R6jlKrSmsxvMqRgwFGwwQLq1VLQTedBmK9QV mZYpT5zWt4m/qs0+IebVp3k3OcQVniPc2xuP01juZfbrvXB//fjdBj5onGnUKsG43U6P U/wqNhNS1Qqg2x/7ZM63PjDxLyejZG1e/juyfRjSIMLmpB4QT0IDf4+17O3ms9idynFY PNitGdRuNWGLiI7mMUEOUB/hPe3BW/aQk2PgAdN4oYUBMQPQ+uWYqQKvPNUi+Bi9mBRe 959M4sXloQLoRHCFPB7+DcYBMvtraVxMIGQ0CTHWbsP56DYvFqaf9w1zTq/2c331jDeq VbnQ== X-Forwarded-Encrypted: i=1; AJvYcCUh/qbCElMfiHH0T/DuPPmLuTjIROnVdzxnsW4UqOMpApyDvFPMSfZ3gVmVoeGGHadixld8K/WXAxpqdLcIA/fwu1W2y9opLg== X-Gm-Message-State: AOJu0Yz+17TMo4Nn0mQzk+aSz3In9t34g/NhV5lsGQTRWbsNaTrkpEhd bK3y8fpjruNy/7Hvs6KZkEofg8pOi76TH66bP2BY0KcP+rYvuNOArHg+YBZK4WU= X-Google-Smtp-Source: AGHT+IFVtOGc1QJPHyax2QodLzADuddLlAkhrK83fI5DPGDi8YBkp3+eRTuf4m1M8/5LRN+xn23wvA== X-Received: by 2002:a17:903:245:b0:1f4:5ad1:b65e with SMTP id d9443c01a7336-1f6d02f4821mr101550425ad.34.1718037567985; Mon, 10 Jun 2024 09:39:27 -0700 (PDT) Received: from [10.0.17.156] ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f71d6dd882sm13190045ad.201.2024.06.10.09.39.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 09:39:27 -0700 (PDT) Message-ID: <99e38b66-f17a-4640-8a7f-0cc82cca50fe@rivosinc.com> Date: Mon, 10 Jun 2024 09:39:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] RISC-V: Add Zalrsc and Zaamo testsuite support To: Jeff Law , gcc-patches@gcc.gnu.org Cc: palmer@dabbelt.com, gnu-toolchain@rivosinc.com References: <20240603215329.2664893-1-patrick@rivosinc.com> <20240603215329.2664893-3-patrick@rivosinc.com> <1b8c5ee3-3f1b-4925-b421-4bb7033a6151@gmail.com> Content-Language: en-US From: Patrick O'Neill In-Reply-To: <1b8c5ee3-3f1b-4925-b421-4bb7033a6151@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/7/24 16:04, Jeff Law wrote: > > > On 6/3/24 3:53 PM, Patrick O'Neill wrote: >> Convert testsuite infrastructure to use Zalrsc and Zaamo rather than A. >> >> gcc/testsuite/ChangeLog: >> >>     * gcc.target/riscv/amo-table-a-6-amo-add-1.c: Use Zaamo rather >> than A. >>     * gcc.target/riscv/amo-table-a-6-amo-add-2.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-amo-add-3.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-amo-add-4.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-amo-add-5.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-compare-exchange-1.c: Use Zalrsc >> rather >>     than A. >>     * gcc.target/riscv/amo-table-a-6-compare-exchange-2.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-compare-exchange-3.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-compare-exchange-4.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-compare-exchange-5.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-compare-exchange-6.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-compare-exchange-7.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-1.c: Use Zaamo >> rather >>     than A. >>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-2.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-3.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-4.c: Ditto. >>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-5.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-amo-add-1.c: Add Zaamo option. >>     * gcc.target/riscv/amo-table-ztso-amo-add-2.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-amo-add-3.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-amo-add-4.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-amo-add-5.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-compare-exchange-1.c: Use >> Zalrsc rather >>     than A. >>     * gcc.target/riscv/amo-table-ztso-compare-exchange-2.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-compare-exchange-3.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-compare-exchange-4.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-compare-exchange-5.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-compare-exchange-6.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-compare-exchange-7.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-1.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-2.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-3.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-4.c: Ditto. >>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-5.c: Ditto. >>     * lib/target-supports.exp: Add testsuite infrastructure support for >>     Zaamo and Zalrsc. > So there's a lot of whitespace changes going on in target-supports.exp > that make it harder to find the real changes. > > There's always a bit of a judgement call for that kind of thing. This > one probably goes past would generally recommend, meaning that the > formatting stuff would be a separate patch. > > A reasonable starting point would be if you're not changing the > function in question, then fixing formatting in it probably should be > a distinct patch. > > You probably should update the docs in sourcebuild.texi for the new > target-supports tests. > > So OK for the trunk (including the whitespace fixes) with a suitable > change to sourcebuild.texi. Sorry about that - the whitespace changes snuck in when resolving a merge conflict and were unintentional. I'll post a v3 with the sourcebuild.texi changes and patch 3/3 changes later today. I'll split the target-supports.exp trailing whitespace removal into a separate patch after this series lands. Patrick > > jeff