From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 38E6A3858D1E for ; Thu, 11 Apr 2024 13:27:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38E6A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38E6A3858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712842050; cv=pass; b=Y5px/ku7Do24ncmUOlPcFua7mA7p3yJ0clqhV9RFTyTRhmMb8NNaT/03yT6EXR2hquL4lNAP70z5p7o3hrlcA5e3LH6b9STxFgGpJU25h2x0qPSehXoS2nl2+6kJe9GF+1tSpZb/BPrVNGaGz8GPmqC+PHu8CctUrUDUvBm39ys= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712842050; c=relaxed/simple; bh=iyVv10Ti7v8H/jeYutKyMnavD/pbI12N4mgfNWpzH8w=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=h8HGtl055rXcQLlQzx0wRl7n9+dBYXwWAM4BUjbpYGysu+Vvkn5EeswOxbz7y7vgJjH6vTDaK3NBmOuaEb3AwWMukhMABpzsIOm1A7JUQIEJhR5S187q/CndDZUNNjZJf9iCYdncrXzJPQZKq+FlKtXKIC1AizrUye7nleUzFCU= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43BCPcqJ021659; Thu, 11 Apr 2024 13:27:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=vRoO8a4+LUeeDkbvDnUOJ8YdF2Bv6ybLFgUWsuWU7jk=; b=mqetXfIXVFTp/7x3rJqbC8JlXQUrBSi+5mHW8QsnYhqbaj7r24pqBzDC8vkrheuC/NIF vxcFR3T3GjDseP1njH9l9g/wzrSPxtFd3DRWcRIdqq6D4Z0iXr8KKN1xowKuOs4/SLLA 0/eWgKQXngpAtx9MU7ogrZJfOpCZUQmj/AFyCaw/C4kSTTQrbB0X7t/s9tqKJROunLLD 4O8Xvigq7Iruuyq9iqAdAjMnu5nFRX8mEbPT4nam2aVqcUMS0xOCx5dukhDwzyd6kVtK UaqjLIT69GlQItfZAUmTfGtPJC+q2VaCbxx7uuNmxKcBi1ki8oYWyTeZ0zdckEFJExmp Xg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xax0usjy0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2024 13:27:27 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43BCIeUh032407; Thu, 11 Apr 2024 13:27:26 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2168.outbound.protection.outlook.com [104.47.73.168]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xavua49hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2024 13:27:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jy88TDQf5Biakqv0rorMwgzWB5B4wyN+yXOqCV2jeUnMfQonHE8KSxw7975IPB8APmxAi00aUHR0IAkBE2NXVSk5WIOpK4PWaBaWIsH+eGnR2RXUonID0PleDTj6jISNspaxojS2tXULoTsLXkaI27qzVFEVJJyPH+ldgN39zJXaYWM8fUMdkhvtk+hXce8s3bU/lr57/v0aKobK8hb6Bca6ZohkAe6dZ8RX0tZdzOC1TEbeHp9uPMy00SgxF6XoYGVW6JhaYfo7wCaX3jVnXrR0PZPWb5oZK9YVHXOanr7V+4d3u4HpVhwaEd9ZJemVNIwoBgaUBPZde/Cqud4g/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vRoO8a4+LUeeDkbvDnUOJ8YdF2Bv6ybLFgUWsuWU7jk=; b=RakVtpM+QyPqyO09kXneFen+DnSChuhu725gq2NvAjplEoA4rAMzSh+Bh8MUtIiOv9rWZd8TFPC4m8+3GA5I6YquN8iCZ7pTvCrVGLmjqDVnMljKd6kKNgkI9ENg7DM4VVfhOOQj1ABtkne4W7XaV2IcSvt0PWse5ef5tVQd/UFq5P9DXao5Gjrh+4aobGGK3wM3PZb/IZvulte1yfFrWDrwohxkJsh3FM3d6KWtn47jKN6395GwBIX2OEu5UvbACexrMJ5Bt7Y6WTTVCEB0TS8pX+xJVd4JjiWvh1ctC4p4Fmcfw7kIPdGTe46aJhqxWI3mhmzoL8lXfvmPgJFEvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vRoO8a4+LUeeDkbvDnUOJ8YdF2Bv6ybLFgUWsuWU7jk=; b=PfbnSAf3HIIHy1Btp7DAPvhXkI/VB3LLLXuqdSJT9FJKlt26m6SUK/34HvgrqIe3DO+fRRp2vuzXyiw8o3OvVzr22SkpErpBGhiQwBMy5+ZeRl24mOKgEgbgVJeRPMsDqtElW4bOT5Giywgqdl2+NH8GB4qL7fNJiG/PpXiGKig= Received: from CY8PR10MB6538.namprd10.prod.outlook.com (2603:10b6:930:5a::17) by DS7PR10MB5023.namprd10.prod.outlook.com (2603:10b6:5:38d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Thu, 11 Apr 2024 13:27:23 +0000 Received: from CY8PR10MB6538.namprd10.prod.outlook.com ([fe80::2dae:7852:9563:b4bc]) by CY8PR10MB6538.namprd10.prod.outlook.com ([fe80::2dae:7852:9563:b4bc%6]) with mapi id 15.20.7409.042; Thu, 11 Apr 2024 13:27:23 +0000 From: Qing Zhao To: Siddhesh Poyarekar , Richard Biener , Joseph Myers CC: "uecker@tugraz.at" , Kees Cook , "isanbard@gmail.com" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH v8 2/5] Convert references with "counted_by" attributes to/from .ACCESS_WITH_SIZE. Thread-Topic: [PATCH v8 2/5] Convert references with "counted_by" attributes to/from .ACCESS_WITH_SIZE. Thread-Index: AQHagfMqFyMaRicJ4UCLPaNWmgIfh7Fh6A6AgAE7+IA= Date: Thu, 11 Apr 2024 13:27:23 +0000 Message-ID: <9A6C38D5-9B7A-4A35-AE2D-4B2B77A42C51@oracle.com> References: <20240329160703.4012941-1-qing.zhao@oracle.com> <20240329160703.4012941-3-qing.zhao@oracle.com> <4e305cb8-ae4e-301f-44fd-12de5e4811b@redhat.com> In-Reply-To: <4e305cb8-ae4e-301f-44fd-12de5e4811b@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3774.500.171.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR10MB6538:EE_|DS7PR10MB5023:EE_ x-ms-office365-filtering-correlation-id: 5146048f-8ffb-4853-6547-08dc5a2b1f40 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +MNVuFlIaYY9m9BAh9JypHS/RC855Am6ErIa5KQVwuN7+0kHaaFevHHWBlrYJ0u5MPx+jJTp0NdV+Tzs8IYCNv1kCOuNj5PgZpfc7tvWvSANYRIQXgU91kH3xHVrq4T2MfG8iuKwFJnUFRuSD1MFPmYnroRbo/WWHBIsG5UPU5f7pkS7pKCwYCKn0MHsPrZ3AjJ4i74QvbNQgOCM94gCJXve4Cl+ah7mbRaoM8BqnVakOSRWUIUPEY7gqQ79AUkcJrQyQ7k39CN3lI0paGl78rIAbxACtDGwVl0BDWlvpdReF6Jj7/bDLNfOev2vGtv5xQHHdadeJprGZt2S7GSvQpuxg8Cn2wrj5bhb/IwHnN/6GIJ7onBdgvfNBfSlJjZ6uF04Y1AYTezXYRV7w2YPLFRdmeX1BisXoWgwWP4gzTBetNvcTwODjmc4bG8O6GJjjU3wsM4sIV0wgPMepjdmSebfw1lNNWQyZuWFTbI6sBguMU7/whQX9ZpWM92TwIm2hRpvSCflScNDWXXaQw1e9Hwv7AFndPfthCsH1cL0cFJotLPSGO9UPc5cfPrZPYEN9v0JNJ148TFG/BXo9tI2NvlzyhL0gCeTZpQL4TSX6E6oE0Vp9S5lkr034anpWYnS5wbtC08darKDkxYPD7vcnT48JrXubXqq7nJXCl3I1I1bpYTbXjMpysyRs8AbvphedaG2BBMYf3hoJITN6ZvgIKvdfEW96fiERv1nWATWCm8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR10MB6538.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SxRzyyrUl4GMyV6Qcy4DRu47yD9tqFT9YyxXqwNLyWpWdZF0/mJKbj5C5AVp?= =?us-ascii?Q?J5/GqDxnrucEg1ukr3hPc27rCaggWZ/O8AqQGKwwyhZV5rgRBTbDmCzdudZP?= =?us-ascii?Q?lVLmaoWC9B9xYasej6jszDLGiL+7XUz9+l6+UqdLRbkYqjO6QDxNfz2bMTuM?= =?us-ascii?Q?F+7jvPry+PU6FMf6C84i2rP1JV8QjfjEtLy6vlsfArDnZPweK85mT1wRnV7k?= =?us-ascii?Q?bdJbzO+XiEPwM50gYM/eJFUlwRG2ywy4R5odQlFfe3DbBIR1zqzGRGeBkLXu?= =?us-ascii?Q?9gTOtXX7bI8nHHCFcxHJL4nHKp5p2IxHJVMITAdE9yVjN0LzXdcd/C2vsaQG?= =?us-ascii?Q?U2oaswuiJ4jPQblSZ1xwlGSzQd5pZHBw/0KdQxGSUtEpiANjkqkrg/giPEdU?= =?us-ascii?Q?91i9H2KGFFtjIuOEi1AzqpX9URul1waqGzi3H+1mSUGbUZxvCn4CyGhTeFR2?= =?us-ascii?Q?iHDOIBsGBy4Qn7bTDXvtC6MQFxwAGw6P20cSbq75TaliWDpJjqMPxuzF5jCR?= =?us-ascii?Q?e+ZuNOE6BhvQjbcJ3PzjJ3M4Tcn7jJea8VKt/blOpo/o5jPVoKBkM7Jkyn2z?= =?us-ascii?Q?Q2fMHIGuUTs08RWFavw3RZsYq2JmfqsLbq3Nki7CL3Eb3QMi21WciJoOekEC?= =?us-ascii?Q?m3HyhD092owx1VChkEb2O7Kpc7wVCvWAQLh4Dl1a7zNyId98OPJq7NKC/p1M?= =?us-ascii?Q?Pdxv6I/qA28vnxhuJId7L2SlD+k81M4ODDR/Wc84Ms8BwKDVWjWLBqTCeZio?= =?us-ascii?Q?FFt56EShQ4V8vQbX6KJm3hgJXfaimqSWl+UWU2ye5snjpP2OE/g3lpbRtF9d?= =?us-ascii?Q?znRNVUoA28ypzkZtwI5FBKrsRr/TWFnV4ucaOUonDmyWfDaqeCQTTp14581m?= =?us-ascii?Q?3eILHtvNOAOxhGZrzAs78P5Tq2rMMdiohGrtQdGC1bvqhPO0rwB55w8kfbfT?= =?us-ascii?Q?z6wpYfsqI/afSUB8m+kDXfmKssrhNRdm484wGzXaA6inbbeI5SPlLImhX1h7?= =?us-ascii?Q?09osqyamqxxYzBD/Z/jXmy9XwR5xUcF6U8HJGCEqt10NVeJBKIMIjIKYS0+6?= =?us-ascii?Q?t8jDZjRrfbM46FWEO7V8gE7S8zHayKboiLHQ/hRr1QnUoey++I0fLi0RaYPo?= =?us-ascii?Q?kPgJOePs6gjpaax3TIMpyaM3ykStDhXe1TZoqK47rv/O/rYvZMJNbBX71oS1?= =?us-ascii?Q?cDNQR8bqeecEIcwJtY22lCD5Gl2F2y+BBc8JQnYF8Uo0s4ekFhKRXTsT+EXo?= =?us-ascii?Q?SqB7QtiyfX1q3pWg1AUVWyoR11E9y0iLjsU3WvS2+Tv9FGUSJ79wOnXBpdUu?= =?us-ascii?Q?5dncmX1qGHrZ5Td3sAmhYBn5n0Ha85liVQeITVSheduZlhAin6jAAl8hYdC2?= =?us-ascii?Q?lh6gyPw5y/Oc6VbaA1KNVqfIuOZkze0jAAgjjl45CSblYznHQJ4y1s6JoH8p?= =?us-ascii?Q?jRXkqINth7MayZaAwSSCi+bbQkVTGsl4Yo53doofyycGMUy8zMOn/Lci1Ai4?= =?us-ascii?Q?Cc9b4pHLrV8aSZ2L3N7i90zqbuX6YRv0Pm0y/Qa98w0KDhkb2pOtTPkvwh53?= =?us-ascii?Q?YAr6sgGD9XoHSR8GhG7El0890wOOdisrQvjKdDKjzwLaNQuWJUXng4utQA4e?= =?us-ascii?Q?7YHd3SLcS7o1zOxd4O32wiI=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <6B2A25B501164444B28E2FAC604243FE@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HA3KS5JKOyKf8zyGpdqxQvcVsuDExoEsvlqpnlaQ3n6lJV49mRTVuPntKJIQZV4laYP9wewcmjb4Jnj/6HtFPSFjYBIN3nfPOmqH3cZc1ENgBS1g2jEX0Zm0COuDeULIGMf07JyOPVQW4uZ6AonvWI3R6vMSTIUt5+ol1Xxi+Q2/hgDHN25h/uUVXEc+ouIowYP8AGT5KHIoQsqh8hB6ZGL8CcgbWJB/D2K/8fVIwM1JDWNG+23egQ2N5JBDIM6eVSuYCybj5h3WNcFnZlft2cl2w0oXBkM8pYi14FhatpTkqjNTLvPF9KjK36D5aIm0xfuatwk7cSnW2DmrSDoO1k+PWPVa9hPhclvqjM7cM+ekehGkH25zHwmVmAfTwmiG7wsmiuaWAYD4VCZbcAC6PHpQ1gNoBQ1M0WvfFTErfkcn7jeTkc5Xq27SBUGSZNKlbMDuuvKTUVZirlMjTVq9itlem1tQnZC9nJdBNbt2GNO5NoKff0K1uyPjJOWbuY7LJFKLHiu0CbS6WMtJ6oLgv7cEM1tMgh5ijqIFtNH6GwPnH2R7zYOV5PKCHc9gmE/sI3b6xhK2XjTX7AVpiwv8eDgPytgEwUM2MPWim2Tt6Ak= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB6538.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5146048f-8ffb-4853-6547-08dc5a2b1f40 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2024 13:27:23.3620 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lLJ30N8iwQoKQeQLmiL0Tf9HCReccPFS74A3sCL4BxSs8LXxRgh5MM6dXtOlSK6kb6q7kW/gH/kYzlczN2hDNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5023 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-11_06,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404110098 X-Proofpoint-GUID: RJ9Oj1oT4VarmkCdSjBU31pqLOyOTtZ8 X-Proofpoint-ORIG-GUID: RJ9Oj1oT4VarmkCdSjBU31pqLOyOTtZ8 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sid and Richard, The C FE changes in this patch has been approved by Joseph. Could you please review the Middle-end change? thanks. Qing > On Apr 10, 2024, at 14:36, Joseph Myers wrote: >=20 > On Fri, 29 Mar 2024, Qing Zhao wrote: >=20 >> +/* For a SUBDATUM field of a structure or union DATUM, generate a REF t= o >> + the object that represents its counted_by per the attribute counted_= by >> + attached to this field if it's a flexible array member field, otherw= ise >> + return NULL_TREE. >> + set COUNTED_BY_TYPE to the TYPE of the counted_by field. >=20 > Use an uppercase letter at the start of a sentence, "Set". >=20 >> +static tree >> +build_counted_by_ref (tree datum, tree subdatum, tree *counted_by_type) >> +{ >> + tree type =3D TREE_TYPE (datum); >> + if (!(c_flexible_array_member_type_p (TREE_TYPE (subdatum)))) >> + return NULL_TREE; >=20 > There are redundant parentheses here around the call to=20 > c_flexible_array_member_type_p. >=20 > The C front-end changes in this patch are OK for GCC 15 (after GCC 14 has= =20 > branched, and once a version of patch 1 has also been approved) with thos= e=20 > fixes. >=20 > --=20 > Joseph S. Myers > josmyers@redhat.com >=20