From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9665 invoked by alias); 30 Oct 2010 08:07:33 -0000 Received: (qmail 9650 invoked by uid 22791); 30 Oct 2010 08:07:33 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2bthomr10.btconnect.com (HELO mail.btconnect.com) (213.123.20.128) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 30 Oct 2010 08:07:28 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2bthomr10.btconnect.com with ESMTP id AMY62482; Sat, 30 Oct 2010 09:07:25 +0100 (BST) Cc: GCC Patches , Mike Stump Message-Id: <9A74A8A1-8385-4258-B953-476DEE18E2C0@sandoe-acoustics.co.uk> From: IainS To: Richard Henderson In-Reply-To: <4CCB3644.2040408@redhat.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: [Patch darwin, debug] make debug section starts explicit. Date: Sat, 30 Oct 2010 14:36:00 -0000 References: <4CCB3644.2040408@redhat.com> X-Mirapoint-IP-Reputation: reputation=Fair-1, source=Queried, refid=tid=0001.0A0B0302.4CCBD233.002C, actions=tag X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0209.4CCBD23E.0047,ss=1,fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=single engine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg02628.txt.bz2 Hi Richard, On 29 Oct 2010, at 22:01, Richard Henderson wrote: > On 10/28/2010 11:16 AM, IainS wrote: >> * doc/tm.texi (TARGET_ASM_OUTPUT_DWARF_SECTION_START_INFO): Hook >> documentation (auto-generated). > > I think the hook is redundant with the support that we already > have for sections. > > May I suggest instead that we create allow the section structures > for each of these debug sections to be overwritten. Darwin can > then alter both the section name and notice the SECTION_DECLARED > bit in order to output that label. > > This will involve moving declaration and initialization of > debug_info_section et al to the same place where we handle > text_section. > That should be before TARGET_ASM_INIT_SECTIONS is invoked, where > darwin can install new section structures. So, IIUC, we would catch dwarf debug sections and .. install the darwin section name .. install our own hook into the section (like we have with objc) and then use that to emit the section label on the first switch? That seems a much better way (less prone to someone editing dwarf2out and forgetting to use dwarf2_section_start()). Ah well, something to consider for 4.7 ;-) ... .. there are higher priority things for this weekend. thanks for reviewing, Iain