From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1294 invoked by alias); 5 Apr 2011 17:42:43 -0000 Received: (qmail 1187 invoked by uid 22791); 5 Apr 2011 17:42:41 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RFC_ABUSE_POST,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta11.westchester.pa.mail.comcast.net (HELO QMTA11.westchester.pa.mail.comcast.net) (76.96.59.211) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Apr 2011 17:42:37 +0000 Received: from omta15.westchester.pa.mail.comcast.net ([76.96.62.87]) by QMTA11.westchester.pa.mail.comcast.net with comcast id TtUb1g0081swQuc5Btidbq; Tue, 05 Apr 2011 17:42:37 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta15.westchester.pa.mail.comcast.net with comcast id Ttia1g02s0BKwT43btibMc; Tue, 05 Apr 2011 17:42:37 +0000 Subject: Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Mike Stump In-Reply-To: Date: Tue, 05 Apr 2011 17:42:00 -0000 Cc: gcc-patches@gcc.gnu.org, Richard Guenther Content-Transfer-Encoding: quoted-printable Message-Id: <9F3CD3EC-B7DD-4DA8-BA2C-64CF6F018159@comcast.net> References: To: Rainer Orth X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00377.txt.bz2 On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: > * lto.c (promote_var): Only set VISIBILITY_HIDDEN if > HAVE_GAS_HIDDEN. This looks wrong, there are more things that have visibility than those thi= ngs that use GAS and have .hidden. Darwin I think is one of them. ? cygm= ing.h seems to be another.