From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbguseast3.qq.com (smtpbguseast3.qq.com [54.243.244.52]) by sourceware.org (Postfix) with ESMTPS id C14B83858D38 for ; Tue, 12 Sep 2023 02:33:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C14B83858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp78t1694486003t5aqqzep Received: from [10.101.11.9] ( [61.144.172.134]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 12 Sep 2023 10:33:22 +0800 (CST) X-QQ-SSF: 01400000000000C0F000000A0000000 X-QQ-FEAT: 7YFKcddXagjwkkYmN0J8fkUfAdORa0hgkxO0UOVcSnf38vjyw0/7EzE9D1kNR +74bp4f6xSfEd9tNJQrywnce3KeZfYFMcK1fT/8IRyT06LcrSFh0J2dviXy3hCr+DHvljJY fECNnvs4168RhqqoXbjStzdqEb8KFQaXt5lD9RKreGv18Bxw9xYHKXEb0nnGJLD8vsswFx2 6L6QHqjBqw4yMbQywj/C5x7f0Z9A2HI7FBFeQ5x5BYsyjv4NzyI+FA6EDEjVHj6+jC2QC4x Vtgt2/XNoLDjLIv0pV8iik6rYam4cyAM96RE4PLtOFSveDlfI3Lybpthd/QJ813leWSrefi tNtl8ZAwS4dQ0bNz58pnaeDQuvIu0O9QUhQZC7C4lT4G4LekMo= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 7430708577877533947 Message-ID: <9F63A23D4D863426+7ccedfd0-d4fe-4e8f-b06b-fe08817eabce@rivai.ai> Date: Tue, 12 Sep 2023 10:33:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Finish Typing Un-Typed Instructions and Turn on Assert Content-Language: en-US To: Edwin Lu , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, Jeff Law References: <20230911225308.2275313-1-ewlu@rivosinc.com> From: Lehua Ding In-Reply-To: <20230911225308.2275313-1-ewlu@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz6a-0 X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,FORGED_MUA_MOZILLA,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Edwin, Sorry to bother you. I have a small question for you. On 2023/9/12 6:52, Edwin Lu wrote: > --- a/gcc/config/riscv/autovec-opt.md +++ > b/gcc/config/riscv/autovec-opt.md @@ -649,7 +649,8 @@ > (define_insn_and_split "*cond_" gen_int_mode > (GET_MODE_NUNITS (mode), Pmode)}; > riscv_vector::expand_cond_len_unop (icode, ops); DONE; -}) +} > +[(set_attr "type" "vector")]) Is it necessary to add type attribute to these INSNs that exist only before split1 pass? These instructions are expanded into the pattern in vector.md after split1 pass and do not reach the sched1 pass at all. If so, I feel that these patterns cannot be added, and it is reasonable to report an error if these INSNs reach sched1 pass. Thanks. -- Best, Lehua