From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BE5AB3858288 for ; Mon, 10 Oct 2022 14:49:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE5AB3858288 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665413378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tPeQlbn14dVa6n8y3RmVrmYdETZBclLEhQvcMXSZjzc=; b=WbOznxO3f8HG0/u2lw3140gRj5EBy3nGvDdCeOv/Va9R/JE7JV1WDFiJX9k6fnGOuSsibE sg9nAlJH547q8C1JDLmXyqmZMSgfdEK5th4yPs32TUB/FMUfV0LjQHttGCqIu+wRmHeQyq Dx7vHFf/uOv36V3laoy3Lt6OhNaY4Oo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-258-DyGyyZr_NbaCIvdO2c2dUA-1; Mon, 10 Oct 2022 10:49:37 -0400 X-MC-Unique: DyGyyZr_NbaCIvdO2c2dUA-1 Received: by mail-qk1-f200.google.com with SMTP id j13-20020a05620a410d00b006e08208eb31so9379119qko.3 for ; Mon, 10 Oct 2022 07:49:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tPeQlbn14dVa6n8y3RmVrmYdETZBclLEhQvcMXSZjzc=; b=YEmOJEDi4qc+l3fK/BBwdUovSX2qkfBNNFR+AmztTtPzzCtsIVp2GjS9goo/BB8Gjy JfeTtDMVioMKdrEPzXcbhDpsIEx15d9pw0npTsMpT9/ZbXO/CoyihX+Ms/o38xFs7S3J skPakXx8o+no7tqeh7uqX1J9CrZSffL8OPhBDbNtcNmxOTtfGXx3qOutdKWqvl7Z84+N ZjdTGN3KeWF62HWIbSy/tNe5nsIAMx9cmvxmQ+cTobktnsin1P0lxkdK98oekklaf2jP JiORmBGuZDLOFQU60LBeaHkmn1rNNHjDKltPmyyKYDmjQGsAslrWlkLKVoBGHtqqen69 xlRQ== X-Gm-Message-State: ACrzQf2/5XIK9ggPImeFqfD+OJkwztHJBsfUhkmPTEDnCh+TfvMb0ysi M9YvTdgzS8+WRw0RITpLp7sBBqps1uIK+yzjaCI10UkD3mB7njXEmyHAurELKv5Hvps0mRE3VfE 0vKHr/EWx8wfusApv4w== X-Received: by 2002:a05:622a:1209:b0:35d:29b:8c4c with SMTP id y9-20020a05622a120900b0035d029b8c4cmr14864333qtx.124.1665413376267; Mon, 10 Oct 2022 07:49:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6GRfqZQKmWxPprVEdyJc0oSmfpAd8qk0NpYgw207Tzd2VXr4Ux9q6CtBpT3iWmhvGVDbBuvQ== X-Received: by 2002:a05:622a:1209:b0:35d:29b:8c4c with SMTP id y9-20020a05622a120900b0035d029b8c4cmr14864310qtx.124.1665413375810; Mon, 10 Oct 2022 07:49:35 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id k2-20020a05620a414200b006cbd92ca141sm10241535qko.133.2022.10.10.07.49.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 07:49:35 -0700 (PDT) Message-ID: <9a1d8df4-a8b1-6df4-8d97-6de88c673d31@redhat.com> Date: Mon, 10 Oct 2022 10:49:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v4] c-family: ICE with [[gnu::nocf_check]] [PR106937] To: Marek Polacek Cc: GCC Patches , Joseph Myers References: <20220929224945.90798-1-polacek@redhat.com> <1c85a5bf-82dd-772c-a960-75a495ded832@redhat.com> <986ebf27-6897-c762-ff5a-d82c465e61a8@redhat.com> <8c2a1cc2-444b-90be-f73b-ee5eb7cf69e6@redhat.com> <93969753-469e-c5d9-6563-be4bc11ba29f@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/7/22 18:16, Marek Polacek wrote: > On Fri, Oct 07, 2022 at 05:56:18PM -0400, Jason Merrill wrote: >> On 10/7/22 17:08, Marek Polacek wrote: >>> On Fri, Oct 07, 2022 at 12:17:34PM -0400, Jason Merrill wrote: >>>> On 10/6/22 22:12, Marek Polacek wrote: >>>>> On Thu, Oct 06, 2022 at 05:42:41PM -0400, Jason Merrill wrote: >>>>>> On 10/4/22 19:06, Marek Polacek wrote: >>>>>>> On Fri, Sep 30, 2022 at 09:12:24AM -0400, Jason Merrill wrote: >>>>>>>> On 9/29/22 18:49, Marek Polacek wrote: >>>>>>>>> When getting the name of an attribute, we ought to use >>>>>>>>> get_attribute_name, which handles both [[ ]] and __attribute__(()) >>>>>>>>> forms. Failure to do so may result in an ICE, like here. >>>>>>>>> >>>>>>>>> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? >>>>>>>> >>>>>>>> How do we print the attributes with this patch? Don't we also want to print >>>>>>>> the namespace, and use [[]] in the output? >>>>>>> >>>>>>> Good point, however: while the testcase indeed has an attribute >>>>>>> in the [[]] form in the typedef, here we're printing its "aka": >>>>>>> >>>>>>> warning: initialization of 'FuncPointerWithNoCfCheck' {aka 'void (__attribute__((nocf_check)) *)(void)'} from incompatible pointer type 'FuncPointer' {aka 'void (*)(void)'} >>>>>>> >>>>>>> c-pretty-print.cc doesn't seem to know how to print an [[]] attribute. >>>>>>> I could do that, but then we'd print >>>>>>> >>>>>>> aka 'void ([[nocf_check]] *)(void)' >>>>>>> >>>>>>> in the above, but that's invalid syntax! >>>>>> >>>>>> Indeed, it should be >>>>>> >>>>>> void (* [[gnu::nocf_check]])(void) >>>>> >>>>> Ok, let me fix that too, then. I've updated the description to show >>>>> what we print with the patch, and what was printed before. >>>> >>>> Oops, apparently I was wrongly assuming that the attribute appertained to >>>> the pointer. >>> >>> So was I :/. >>> >>>> Since it actually appertains to the function type, it should >>>> be >>>> >>>> void (*)(void) [[gnu::nocf_check]]. >>>> >>>> But for GCC attribute syntax, I think we want to leave the __attribute__ >>>> where it was before, as in the manual's example >>>> >>>> void (__attribute__((noreturn)) ****f) (void); >>> >>> Thanks, done here: >>> >>> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? >>> >>> -- >8 -- >>> When getting the name of an attribute, we ought to use >>> get_attribute_name, which handles both [[]] and __attribute__(()) >>> forms. Failure to do so may result in an ICE, like here. >>> >>> pp_c_attributes_display wasn't able to print the [[]] form of >>> attributes, so this patch teaches it to. >>> >>> When printing a pointer to function with a standard attribute, the attribute >>> should be printed after the parameter-list. With this patch we print: >>> >>> aka 'void (*)(int) [[gnu::nocf_check]]' >>> >>> pp_c_attributes has been unused since its introduction in r56273 so >>> this patch removes it. >>> >>> PR c++/106937 >>> >>> gcc/c-family/ChangeLog: >>> >>> * c-pretty-print.cc (pp_c_specifier_qualifier_list): Only print >>> GNU attributes here. >>> (c_pretty_printer::abstract_declarator): For a pointer to function, >>> print the standard [[]] attributes here. >>> (pp_c_attributes): Remove. >>> (pp_c_attributes_display): Print the [[]] form if appropriate. Use >>> get_attribute_name. Don't print a trailing space when printing the >>> [[]] form. >>> * c-pretty-print.h (pp_c_attributes): Remove. >>> >>> gcc/cp/ChangeLog: >>> >>> * error.cc: Include "attribs.h". >>> (dump_type_prefix): Only print GNU attributes here. >>> (dump_type_suffix): Print standard attributes here. >>> >>> gcc/testsuite/ChangeLog: >>> >>> * c-c++-common/pointer-to-fn1.c: New test. >>> --- >>> gcc/c-family/c-pretty-print.cc | 102 +++++++++++--------- >>> gcc/c-family/c-pretty-print.h | 1 - >>> gcc/cp/error.cc | 17 +++- >>> gcc/testsuite/c-c++-common/pointer-to-fn1.c | 18 ++++ >>> 4 files changed, 92 insertions(+), 46 deletions(-) >>> create mode 100644 gcc/testsuite/c-c++-common/pointer-to-fn1.c >>> >>> diff --git a/gcc/c-family/c-pretty-print.cc b/gcc/c-family/c-pretty-print.cc >>> index efa1768f4d6..349f0a07d3e 100644 >>> --- a/gcc/c-family/c-pretty-print.cc >>> +++ b/gcc/c-family/c-pretty-print.cc >>> @@ -466,7 +466,12 @@ pp_c_specifier_qualifier_list (c_pretty_printer *pp, tree t) >>> { >>> pp_c_whitespace (pp); >>> pp_c_left_paren (pp); >>> - pp_c_attributes_display (pp, TYPE_ATTRIBUTES (pointee)); >>> + /* If we're dealing with the GNU form of attributes, print this: >>> + void (__attribute__((noreturn)) *f) (); >>> + If it is the standard [[]] attribute, we'll print the attribute >>> + in c_pretty_printer::abstract_declarator. */ >>> + if (!cxx11_attribute_p (TYPE_ATTRIBUTES (pointee))) >>> + pp_c_attributes_display (pp, TYPE_ATTRIBUTES (pointee)); >>> } >>> else if (!c_dialect_cxx ()) >>> pp_c_whitespace (pp); >>> @@ -564,15 +569,26 @@ pp_c_parameter_type_list (c_pretty_printer *pp, tree t) >>> void >>> c_pretty_printer::abstract_declarator (tree t) >>> { >>> + bool fn_ptr_p = false; >>> if (TREE_CODE (t) == POINTER_TYPE) >>> { >>> if (TREE_CODE (TREE_TYPE (t)) == ARRAY_TYPE >>> || TREE_CODE (TREE_TYPE (t)) == FUNCTION_TYPE) >>> - pp_c_right_paren (this); >>> + { >>> + pp_c_right_paren (this); >>> + fn_ptr_p = true; >>> + } >>> t = TREE_TYPE (t); >>> } >>> direct_abstract_declarator (t); >>> + /* If this is the standard [[]] attribute, print >>> + void (*)() [[noreturn]]; */ >>> + if (fn_ptr_p && cxx11_attribute_p (TYPE_ATTRIBUTES (t))) >> >> Do you need to check fn_ptr_p? The attributes on a function type go here >> whether or not we were dealing with a pointer. > > I probably don't need it! Here's a version without that: > > So far all dg.exp tests passed. > > -- >8 -- > When getting the name of an attribute, we ought to use > get_attribute_name, which handles both [[]] and __attribute__(()) > forms. Failure to do so may result in an ICE, like here. > > pp_c_attributes_display wasn't able to print the [[]] form of > attributes, so this patch teaches it to. > > When printing a pointer to function with a standard attribute, the attribute > should be printed after the parameter-list. With this patch we print: > > aka 'void (*)(int) [[gnu::nocf_check]]' > > pp_c_attributes has been unused since its introduction in r56273 so > this patch removes it. > > PR c++/106937 > > gcc/c-family/ChangeLog: > > * c-pretty-print.cc (pp_c_specifier_qualifier_list): Only print > GNU attributes here. > (c_pretty_printer::abstract_declarator): For a pointer to function, > print the standard [[]] attributes here. This change now applies to all types, whereas the dump_type_suffix change only applies to functions. Maybe move this change into direct_abstract_declarator? > (pp_c_attributes): Remove. > (pp_c_attributes_display): Print the [[]] form if appropriate. Use > get_attribute_name. Don't print a trailing space when printing the > [[]] form. This is no longer accurate. > * c-pretty-print.h (pp_c_attributes): Remove. > > gcc/cp/ChangeLog: > > * error.cc: Include "attribs.h". > (dump_type_prefix): Only print GNU attributes here. > (dump_type_suffix): Print standard attributes here. See below. > > gcc/testsuite/ChangeLog: > > * c-c++-common/pointer-to-fn1.c: New test. > --- > gcc/c-family/c-pretty-print.cc | 96 ++++++++++++--------- > gcc/c-family/c-pretty-print.h | 1 - > gcc/cp/error.cc | 16 +++- > gcc/testsuite/c-c++-common/pointer-to-fn1.c | 18 ++++ > 4 files changed, 86 insertions(+), 45 deletions(-) > create mode 100644 gcc/testsuite/c-c++-common/pointer-to-fn1.c > > diff --git a/gcc/c-family/c-pretty-print.cc b/gcc/c-family/c-pretty-print.cc > index efa1768f4d6..7519b0982b7 100644 > --- a/gcc/c-family/c-pretty-print.cc > +++ b/gcc/c-family/c-pretty-print.cc > @@ -466,7 +466,12 @@ pp_c_specifier_qualifier_list (c_pretty_printer *pp, tree t) > { > pp_c_whitespace (pp); > pp_c_left_paren (pp); > - pp_c_attributes_display (pp, TYPE_ATTRIBUTES (pointee)); > + /* If we're dealing with the GNU form of attributes, print this: > + void (__attribute__((noreturn)) *f) (); > + If it is the standard [[]] attribute, we'll print the attribute > + in c_pretty_printer::abstract_declarator. */ > + if (!cxx11_attribute_p (TYPE_ATTRIBUTES (pointee))) > + pp_c_attributes_display (pp, TYPE_ATTRIBUTES (pointee)); > } > else if (!c_dialect_cxx ()) > pp_c_whitespace (pp); > @@ -573,6 +578,13 @@ c_pretty_printer::abstract_declarator (tree t) > } > > direct_abstract_declarator (t); > + /* If this is the standard [[]] attribute, print > + void (*)() [[noreturn]]; */ > + if (cxx11_attribute_p (TYPE_ATTRIBUTES (t))) > + { > + pp_space (this); > + pp_c_attributes_display (this, TYPE_ATTRIBUTES (t)); > + } > } > > /* direct-abstract-declarator: > @@ -850,32 +862,7 @@ c_pretty_printer::declaration (tree t) > pp_c_init_declarator (this, t); > } > > -/* Pretty-print ATTRIBUTES using GNU C extension syntax. */ > - > -void > -pp_c_attributes (c_pretty_printer *pp, tree attributes) > -{ > - if (attributes == NULL_TREE) > - return; > - > - pp_c_ws_string (pp, "__attribute__"); > - pp_c_left_paren (pp); > - pp_c_left_paren (pp); > - for (; attributes != NULL_TREE; attributes = TREE_CHAIN (attributes)) > - { > - pp_tree_identifier (pp, TREE_PURPOSE (attributes)); > - if (TREE_VALUE (attributes)) > - pp_c_call_argument_list (pp, TREE_VALUE (attributes)); > - > - if (TREE_CHAIN (attributes)) > - pp_separate_with (pp, ','); > - } > - pp_c_right_paren (pp); > - pp_c_right_paren (pp); > -} > - > -/* Pretty-print ATTRIBUTES using GNU C extension syntax for attributes > - marked to be displayed on disgnostic. */ > +/* Pretty-print ATTRIBUTES marked to be displayed on diagnostic. */ > > void > pp_c_attributes_display (c_pretty_printer *pp, tree a) > @@ -885,10 +872,12 @@ pp_c_attributes_display (c_pretty_printer *pp, tree a) > if (a == NULL_TREE) > return; > > + const bool std_p = cxx11_attribute_p (a); > + > for (; a != NULL_TREE; a = TREE_CHAIN (a)) > { > - const struct attribute_spec *as; > - as = lookup_attribute_spec (TREE_PURPOSE (a)); > + const struct attribute_spec *as > + = lookup_attribute_spec (get_attribute_name (a)); > if (!as || as->affects_type_identity == false) > continue; > if (c_dialect_cxx () > @@ -896,26 +885,47 @@ pp_c_attributes_display (c_pretty_printer *pp, tree a) > /* In C++ transaction_safe is printed at the end of the declarator. */ > continue; > if (is_first) > - { > - pp_c_ws_string (pp, "__attribute__"); > - pp_c_left_paren (pp); > - pp_c_left_paren (pp); > - is_first = false; > - } > + { > + if (std_p) > + { > + pp_c_left_bracket (pp); > + pp_c_left_bracket (pp); > + } > + else > + { > + pp_c_ws_string (pp, "__attribute__"); > + pp_c_left_paren (pp); > + pp_c_left_paren (pp); > + } > + is_first = false; > + } > else > - { > - pp_separate_with (pp, ','); > - } > - pp_tree_identifier (pp, TREE_PURPOSE (a)); > + pp_separate_with (pp, ','); > + tree ns; > + if (std_p && (ns = get_attribute_namespace (a))) > + { > + pp_tree_identifier (pp, ns); > + pp_colon (pp); > + pp_colon (pp); > + } > + pp_tree_identifier (pp, get_attribute_name (a)); > if (TREE_VALUE (a)) > - pp_c_call_argument_list (pp, TREE_VALUE (a)); > + pp_c_call_argument_list (pp, TREE_VALUE (a)); > } > > if (!is_first) > { > - pp_c_right_paren (pp); > - pp_c_right_paren (pp); > - pp_c_whitespace (pp); > + if (std_p) > + { > + pp_c_right_bracket (pp); > + pp_c_right_bracket (pp); > + } > + else > + { > + pp_c_right_paren (pp); > + pp_c_right_paren (pp); > + pp_c_whitespace (pp); > + } > } > } > > diff --git a/gcc/c-family/c-pretty-print.h b/gcc/c-family/c-pretty-print.h > index be86bed4fee..92674ab4d06 100644 > --- a/gcc/c-family/c-pretty-print.h > +++ b/gcc/c-family/c-pretty-print.h > @@ -119,7 +119,6 @@ void pp_c_space_for_pointer_operator (c_pretty_printer *, tree); > /* Declarations. */ > void pp_c_tree_decl_identifier (c_pretty_printer *, tree); > void pp_c_function_definition (c_pretty_printer *, tree); > -void pp_c_attributes (c_pretty_printer *, tree); > void pp_c_attributes_display (c_pretty_printer *, tree); > void pp_c_cv_qualifiers (c_pretty_printer *pp, int qualifiers, bool func_type); > void pp_c_type_qualifier_list (c_pretty_printer *, tree); > diff --git a/gcc/cp/error.cc b/gcc/cp/error.cc > index 4514c8bbb44..c5239f6caf2 100644 > --- a/gcc/cp/error.cc > +++ b/gcc/cp/error.cc > @@ -36,6 +36,7 @@ along with GCC; see the file COPYING3. If not see > #include "internal-fn.h" > #include "gcc-rich-location.h" > #include "cp-name-hint.h" > +#include "attribs.h" > > #define pp_separate_with_comma(PP) pp_cxx_separate_with (PP, ',') > #define pp_separate_with_semicolon(PP) pp_cxx_separate_with (PP, ';') > @@ -897,7 +898,12 @@ dump_type_prefix (cxx_pretty_printer *pp, tree t, int flags) > { > pp_cxx_whitespace (pp); > pp_cxx_left_paren (pp); > - pp_c_attributes_display (pp, TYPE_ATTRIBUTES (sub)); > + /* If we're dealing with the GNU form of attributes, print this: > + void (__attribute__((noreturn)) *f) (); > + If it is the standard [[]] attribute, we'll print the attribute > + in dump_type_suffix. */ > + if (!cxx11_attribute_p (TYPE_ATTRIBUTES (sub))) > + pp_c_attributes_display (pp, TYPE_ATTRIBUTES (sub)); > } > if (TYPE_PTR_P (t)) > pp_star (pp); > @@ -1027,6 +1033,14 @@ dump_type_suffix (cxx_pretty_printer *pp, tree t, int flags) > TREE_CODE (t) == FUNCTION_TYPE > && (flags & TFF_POINTER)); > dump_ref_qualifier (pp, t, flags); > + /* If this is the standard [[]] attribute, print > + void (*)() [[noreturn]]; */ > + if (cxx11_attribute_p (TYPE_ATTRIBUTES (t))) > + { > + pp_space (pp); > + pp_c_attributes_display (pp, TYPE_ATTRIBUTES (t)); > + pp->padding = pp_before; > + } This is too soon, attributes come after the exception-specifier. > if (tx_safe_fn_type_p (t)) > pp_cxx_ws_string (pp, "transaction_safe"); > dump_exception_spec (pp, TYPE_RAISES_EXCEPTIONS (t), flags); > diff --git a/gcc/testsuite/c-c++-common/pointer-to-fn1.c b/gcc/testsuite/c-c++-common/pointer-to-fn1.c > new file mode 100644 > index 00000000000..975885462e9 > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/pointer-to-fn1.c > @@ -0,0 +1,18 @@ > +/* PR c++/106937 */ > +/* { dg-options "-fcf-protection" } */ > +/* { dg-additional-options "-std=c++11 -fpermissive" { target c++ } } */ > +/* Test printing a pointer to function with attribute. */ > + > +__attribute__((nocf_check)) typedef void (*FPA1)(); > +[[gnu::nocf_check]] typedef void (*FPA2)(int); > +typedef void (*FP1)(); > +typedef void (*FP2)(int); > + > +void > +g (FP1 f1, FP2 f2) > +{ > + FPA1 p1 = f1; // { dg-warning {aka 'void \(__attribute__\(\(nocf_check\)\) \*\)\(\)'} } > + FPA2 p2 = f2; // { dg-warning {aka 'void \(\*\)\(int\) \[\[gnu::nocf_check\]\]'} } > + FP1 p3 = p1; // { dg-warning {aka 'void \(__attribute__\(\(nocf_check\)\) \*\)\(\)'} } > + FP2 p4 = p2; // { dg-warning {aka 'void \(\*\)\(int\) \[\[gnu::nocf_check\]\]'} } > +} > > base-commit: 895dd027d5dda51a95d242aec8a49a6dfa5db58d