From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id D280C3858C1F for ; Fri, 25 Aug 2023 02:19:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D280C3858C1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37P2IkC6029915; Fri, 25 Aug 2023 02:19:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : cc : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=k87/Mhb29e7SRGhVJ2eIT3+S2YpRS7auT3782e2t16Q=; b=Bsn591KoH0jV+Tynfpy5YNK48CMY+O88mq4rLFXRghjSEIkN+cxlEqyjA7Etbq1CMfPq R73yxbMz/13mJbZWzPK8dQ/bvoa/Keli5Gt2BQ0BPI0+vXsjotkRqvLyRm0+xPddit1G qvdD0xuJsLuNHS25p56Rfgn8Lri0swXPsXfytthQAzVbB/IZAA6oZwhcsSw+fuyYZ+TN r+4WpbhdFUjpJzwnSA3YvIRLVI5uv/Y6FP5F7wp8gKmD9wYL8oceU0jwRsTet7d5Gpso uWlq/qC/Uo3X5kNCOUMLL1z1OT7XQcytSWeNJsxmQ2sXvK5COmNrChbjwxG97t1U5tKD wA== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3spkdfr0wd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Aug 2023 02:19:54 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37ONteLA027316; Fri, 25 Aug 2023 02:19:53 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3sn20sv5jp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Aug 2023 02:19:53 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37P2JqJ96816300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Aug 2023 02:19:52 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5B7B858056; Fri, 25 Aug 2023 02:19:52 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DFF9F58052; Fri, 25 Aug 2023 02:19:51 +0000 (GMT) Received: from [9.61.28.223] (unknown [9.61.28.223]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 25 Aug 2023 02:19:51 +0000 (GMT) Message-ID: <9a300552-21a6-cc4c-294d-bec0c6b3739c@linux.ibm.com> Date: Thu, 24 Aug 2023 21:19:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] rs6000: Fix issue in specifying PTImode as an attribute [PR106895] Content-Language: en-US To: Michael Meissner , "Kewen.Lin" References: <460cd2bd-7c82-95d8-c58e-f32da70ab2a9@linux.vnet.ibm.com> From: Peter Bergner Cc: P Jeevitha , GCC Patches , Segher Boessenkool In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: tDmQQoETJb7RnnB7scjTOip6uHyyZGTU X-Proofpoint-GUID: tDmQQoETJb7RnnB7scjTOip6uHyyZGTU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-25_01,2023-08-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=876 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2308250017 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/24/23 12:35 PM, Michael Meissner wrote: > On Thu, Jul 20, 2023 at 10:05:28AM +0530, jeevitha wrote: >> gcc/ >> PR target/110411 >> * config/rs6000/rs6000.h (enum rs6000_builtin_type_index): Add fields >> to hold PTImode type. >> * config/rs6000/rs6000-builtin.cc (rs6000_init_builtins): Add node >> for PTImode type. > > It is good as far as it goes, but I suspect we will eventually need to extend > it. In particular, the reason people need PTImode is they need the even/odd > register layout. What you've done enables users to declare this value. Sure, it could be extended, but that is not what this patch is about. It's purely to allow the kernel team access to the guaranteed even/odd register layout for some inline asm code. Any extension would be a follow-on patch to this. On 8/9/23 3:48 AM, Kewen.Lin wrote: > IIUC, this builtin type registering makes this type expose to users, so > I wonder if we want to actually expose this type for users' uses. > If yes, we need to update the documentation (and not sure if the current > name is good enough); otherwise, I wonder if there is some existing > practice to declare a builtin type with a name which users can't actually > use and is just for shadowing a mode. Segher, Mike, Jeevitha and I talked about the patch and Segher mentioned that under some conditions, it's fine to keep the type undocumented. Hopefully he'll weigh in on whether this particular patch is one of those cases or not. Peter