From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D4FFF3858C35 for ; Tue, 14 Nov 2023 18:29:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4FFF3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4FFF3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699986546; cv=none; b=LyCenoQ4OIhcGHyXDmZGM92Ef54yrm3VmABYUZcJ2ZRPWSoBX9goGfdFuhwracIvidR6OtjWTEJk83vmY6W1DkkSXXhJq1/2HfpGPlsaXqVnI8eamrQvMY9uJNg/iPSlm1iYQC253wj/rT+ztav5VnDd3hZYXSacxA38juQVEIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699986546; c=relaxed/simple; bh=vsyHrVXjgyCDDNKIX5BgFcvNAfjVRbnvyhRXITLegwM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=d8qUApGGJ/GgwFOAjlj3+C7MifMLZ84tR9YRODOW6ntmtRuSyYLLAwmQExauPdT/pc3dY0ZSsfLTIo3N7t1y+ejbvEQak/SgB6eCJlhr9OSPVV2ZgOgLraTACky6ASXhTsW2orprqJlVYvmHo+Vu6TrDe6S+yKSsBssUl5AL1Iw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699986545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xCLyhUachW/ozrf2Lb1wNkS0ggaggzyOK7UZI2O4riw=; b=AVv76PuCgzg8JwD+4RvuvpADHZR4rLwv4/5y9rOVfVUhI6NhaouyJSumqUcyrvDn0j6B73 F6q+f4XWzvUUbsUhB16wtaoEkKKZnbbN/Ga/L7qhInvf5b6sagwMC/8N9wIM9Uf0q7qhug 9XCpXq/PJ7MrH0/Hv58YhrOAnwM7rPU= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-YkPiswBZNE6mqTOQx-gKTQ-1; Tue, 14 Nov 2023 13:29:03 -0500 X-MC-Unique: YkPiswBZNE6mqTOQx-gKTQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0085D38157A5; Tue, 14 Nov 2023 18:29:03 +0000 (UTC) Received: from [10.22.8.42] (unknown [10.22.8.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E24BC15881; Tue, 14 Nov 2023 18:29:02 +0000 (UTC) Message-ID: <9a3f05dd-5461-6df4-3c30-d5db5a6b9e8f@redhat.com> Date: Tue, 14 Nov 2023 13:29:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 1/7] df: Add DF_LIVE_SUBREG problem From: Vladimir Makarov To: Lehua Ding , Richard Biener Cc: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com, juzhe.zhong@rivai.ai References: <20231112120817.2635864-1-lehua.ding@rivai.ai> <20231112120817.2635864-2-lehua.ding@rivai.ai> <040fba3b-4f8d-f8cf-df7a-5b77ac251148@redhat.com> <1A588F107664DFA6+96d02d06-07bd-4e79-9493-5e0824d672dd@rivai.ai> <79fd4731-89ea-7d5c-371c-eff768f1a30f@redhat.com> In-Reply-To: <79fd4731-89ea-7d5c-371c-eff768f1a30f@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/23 12:18, Vladimir Makarov wrote: > > On 11/14/23 03:38, Lehua Ding wrote: >> >> >> This is perfectly fine, the code inside the live_subreg problem has a >> branch that goes through similar logic to live_reg if it finds no >> subreg inside the program. Then when the optimization level is less >> than 2, it doesn't track the subreg. By the way, I'd like to ask you >> if you have certain programs where RA has a big impact on compilation >> time to offer? Or any suggestions about it? >> > I've analyzed effect of your patches to -O2 compilation time on > compilation of some old version of combine.c.  The total GCC > compilation time increased by about 3%. I used x86_64 release mode > compiler.  Here are my more detail findings: > > RA compile time increased by 43%. > > 54% of this increase is due df_analyze time increase and 38% is due to > overall ira_color increase (assign_hard_reg execution time increased > in 50 times but still such big increase is 1/3 of overall ira_color > increase). > Sorry, due to different inlining of assign_hard_reg I reported wrong numbers for this function (for version w/o patches only assigning on the region border was taken), the compilation times for this function is basically the same. > The rest (about 10%) of overall RA increase is mostly LRA increase due > to lra_create_live_ranges. > > To see where 6% GCC compilation time increase on SPEC2017 is spent > would be more interesting but it needs a lot of time for analysis. > >