From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id 1732D3857C5B for ; Thu, 23 Jul 2020 20:12:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1732D3857C5B Received: by mail-qt1-x836.google.com with SMTP id s23so5346500qtq.12 for ; Thu, 23 Jul 2020 13:12:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p+VTPuuEWfKYHN1+6zglRikGQirjlLBSkgwKdSDo5rg=; b=CDUN6SYs1QzUia/c6/oOTjv/x0BuhLXPOB5P+hr52C9BjZ5VNR7k+mjZrJWjcAKue+ PmwYbn+IVdtN1bfuBPIEAm9iECf11mvisMqkdvVqCDpQzA5DyN9v+bGn4TOxwt0Z+QUi jC+9cO16+t/Ax2ZSErFsz88aj3JE+HUS1es4Cg0dDRvO/8IfoMPFvydYce1a6HUNU9VQ JInGFyIKnM+wytlkOM2PbDWlQ61sAcGT5TaMs8vYQSZYOq+AYMeLPexVH0BMv3hgto3l X/l8uHvi8rRVtQwiYplnCt8KRgTMOOHGqb2rfb8EOAXVG0wyraxa4HPzy+u4P+EvizrL ZNBQ== X-Gm-Message-State: AOAM53264Nzhuk1rOM7/fRZbsIYrh8bp1Z15hBCvnJeRxQHQT6+bZjd7 H8mamHcAhEdGumzzxVYanXYKhEKg X-Google-Smtp-Source: ABdhPJxBqreOE9eWXracXRQka+1tM0mdjLFZ8ZsbPmo32dTHMK30PzzgE7X2NHgxrXheRzlSCpRYVA== X-Received: by 2002:ac8:4411:: with SMTP id j17mr6038407qtn.77.1595535156298; Thu, 23 Jul 2020 13:12:36 -0700 (PDT) Received: from [192.168.0.41] (174-16-106-56.hlrn.qwest.net. [174.16.106.56]) by smtp.gmail.com with ESMTPSA id m17sm3988527qtm.92.2020.07.23.13.12.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2020 13:12:35 -0700 (PDT) Subject: Re: committed] correct memcmp expansion of constant representations containing embedded nuls (PR 95189) To: Rainer Orth , Martin Sebor via Gcc-patches References: <546f1c1e-73f3-aa20-a3be-b7bae03fff55@gmail.com> From: Martin Sebor Message-ID: <9a4b7855-2576-348d-f580-b19d0f09d828@gmail.com> Date: Thu, 23 Jul 2020 14:12:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 20:12:38 -0000 On 7/22/20 2:23 AM, Rainer Orth wrote: > Hi Martin, > >> I have committed this change in r11-2231 after Jeff approved it >> off list last Thursday. > > the new gcc.target/i386/memcpy-pr95886.c test FAILs on 32-bit x86 > (i386-pc-solaris2.11): > > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 1976943448883713" 1 > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 576467370915332609" 1 > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 578431098682540545" 1 > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 578437695685198337" 1 > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 578437695685198337" 1 > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 578437695752110593" 1 > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 578437695752306689" 1 > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 578437695752307200" 1 > +FAIL: gcc.target/i386/memcpy-pr95886.c scan-rtl-dump-times expand "const_int 578437695752307201" 2 Thanks for letting me know. The test looks for patterns that are apparently LP64-specific so I restricted it to just that data model. Martin