From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 99C2B3858C98; Thu, 4 Apr 2024 13:24:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99C2B3858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99C2B3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712237096; cv=none; b=DIr7nOVsDCx8xDalM1iuYaD8bM4eC2DuxHkdy6q8ChmOL7SihpNri0u0bqMkXGHZDohHHw1igD9NrzGPL1JawDC8TywkMdN9zIJ2TAWklHnP13tG401yaKYWJR/ArVSyFXIpHgvjO6KGhGQic4PtA7Npdcm4loRbtdbb1B5k/0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712237096; c=relaxed/simple; bh=dJNNHdKRtBUIHxZJ/A22wYss5T6IcVcMNZw6chBgCXU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=a+cl2MWbWMGhxtvmxeDDb6eHJlYPLA41P9uG/BueTlFJgyBC1wDdzv2XzCkPmQspyui63V5ZtEcuP/3yyTlTp+d4JaAeHXxhencdXusYIWQnJWNtT0c/P/qZwVKwAd99D9WiFsquXNG8sbUtOx966WUnci6rQsf/CHsEScdPyJU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 434D2RR9016824; Thu, 4 Apr 2024 13:24:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=jejGVqHhdq3Hj7yM+15luI38ZdXkxUboJDMfxl6pwrg=; b=ZygVLnn4GY1FfbbvEHrf9tVguUeL3cTiNEQe3n+9TID4ycrd08V/LvDG0oj5cNM6ilMY alGJNs80+ZCOYlSI2x8wI2kjuU0Bg+lXUOZ00IVad9A+ICrmhF6mbM43F1DVhpZkLDDU dDoZzJf+nFJbqyCxnsxO9UvK7cUZuKzH+UYHmEQc5nJrisKARVnhkxP02UL9CDcCHV96 nj1MHBwqhnBqkD2Rn04eufPRSWxvbBxe26a32WmxXL2EUZImIK3RUGeS0OXANtWtK80k oN3D7ZdLYORRtxXhCVdQZeDBKN1+tL8sjDsO4jstXQEvf+UadUe4kvajKYx7DVCvXfbq Bw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x9vr082eb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Apr 2024 13:24:53 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 434DOWPJ023160; Thu, 4 Apr 2024 13:24:53 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x9vr082e7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Apr 2024 13:24:52 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 434DOdRe003608; Thu, 4 Apr 2024 13:24:52 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3x9epycay1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Apr 2024 13:24:51 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 434DOksM29163818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Apr 2024 13:24:48 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F7E620043; Thu, 4 Apr 2024 13:24:46 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 037B020040; Thu, 4 Apr 2024 13:24:46 +0000 (GMT) Received: from [9.179.15.206] (unknown [9.179.15.206]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 4 Apr 2024 13:24:45 +0000 (GMT) Message-ID: <9a6044ce-651b-4d9d-b018-b4990b90c4d9@linux.ibm.com> Date: Thu, 4 Apr 2024 15:24:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libsanitizer: Do not mention MSan and DFSan in an error message Content-Language: en-US To: Jakub Jelinek Cc: Ilya Leoshkevich , Andreas Krebbel , gcc-patches@gcc.gnu.org, Stefan Schulze Frielinghaus , Juergen Christ References: <20240404113858.854167-1-iii@linux.ibm.com> From: Andreas Krebbel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: _hfcGtcM4CcgIyYCKsizfL74u4IADhHt X-Proofpoint-ORIG-GUID: w084GAT9IIHRg9iZNW69eFP0o_IjVT5c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-04_09,2024-04-04_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=858 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404040092 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/4/24 14:22, Jakub Jelinek wrote: > On Thu, Apr 04, 2024 at 02:19:08PM +0200, Andreas Krebbel wrote: >> On 4/4/24 13:38, Ilya Leoshkevich wrote: >>> Bootstrapped and regtested on s390x-redhat-linux. Ok for master? >>> >>> >>> libsanitizer/ChangeLog: >>> >>> * sanitizer_common/sanitizer_linux_s390.cpp (AvoidCVE_2016_2143): >>> Do not mention MSan and DFSan, which are not supported by GCC. >> >> Ok, Thanks! > > This then needs to be added to libsanitizer/LOCAL_PATCHES , otherwise > it will disappear on the next merge from upstream. > > Though, I must say I'm not entirely convinced the change is worth the > hassle on every libsanitizer merge. You are right. We will leave the message as is. Thanks! Andreas > >>> diff --git a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp >>> index 74db831b0aa..65ba825fa97 100644 >>> --- a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp >>> +++ b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp >>> @@ -212,7 +212,7 @@ void AvoidCVE_2016_2143() { >>> return; >>> Report( >>> "ERROR: Your kernel seems to be vulnerable to CVE-2016-2143. Using ASan,\n" >>> - "MSan, TSan, DFSan or LSan with such kernel can and will crash your\n" >>> + "TSan or LSan with such kernel can and will crash your\n" >>> "machine, or worse.\n" >>> "\n" >>> "If you are certain your kernel is not vulnerable (you have compiled it\n" > > Jakub >