From: Jason Merrill <jason@redhat.com>
To: Matthias Kretz <m.kretz@gsi.de>, Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2] c-family: Add __builtin_assoc_barrier
Date: Wed, 8 Sep 2021 09:44:28 -0400 [thread overview]
Message-ID: <9a9052a4-9b38-57f7-f36a-de247b6aa08e@redhat.com> (raw)
In-Reply-To: <2776155.2yzvbfQdsk@excalibur>
On 9/8/21 5:37 AM, Matthias Kretz wrote:
> On Tuesday, 7 September 2021 19:36:22 CEST Jason Merrill wrote:
>>> case PAREN_EXPR:
>>> - RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t, 0))));
>>> + if (REF_PARENTHESIZED_P (t))
>>> + RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t, 0))));
>>> + else
>>> + RETURN (RECUR (TREE_OPERAND (t, 0)));
>>
>> I think you need to build a new PAREN_EXPR in the assoc barrier case as
>> well, for it to have any effect in templates.
>
> My intent was to ignore __builtin_assoc_barrier in templates / constexpr
> evaluation since it's not affected by -fassociative-math anyway. Or do you
> mean something else?
I agree about constexpr, but why wouldn't template instantiations be
affected by -fassociative-math like any other function?
Jason
next prev parent reply other threads:[~2021-09-08 13:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 7:33 [PATCH] " Matthias Kretz
2021-07-19 12:34 ` Richard Biener
2021-07-20 20:22 ` Jason Merrill
2021-09-06 12:21 ` [PATCH v2] " Matthias Kretz
2021-09-06 12:40 ` Richard Biener
2021-09-06 12:47 ` Matthias Kretz
2021-09-06 12:59 ` Richard Biener
2021-09-06 15:15 ` Matthias Kretz
2021-09-07 17:36 ` Jason Merrill
2021-09-08 9:37 ` Matthias Kretz
2021-09-08 13:44 ` Jason Merrill [this message]
2021-09-08 13:49 ` Matthias Kretz
2021-11-11 8:49 ` [PATCH v3] " Matthias Kretz
2021-11-17 18:35 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a9052a4-9b38-57f7-f36a-de247b6aa08e@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=m.kretz@gsi.de \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).