From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 297703858414 for ; Wed, 8 Sep 2021 13:44:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 297703858414 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-8phbzUpOOjqYEMGFI2CFsA-1; Wed, 08 Sep 2021 09:44:32 -0400 X-MC-Unique: 8phbzUpOOjqYEMGFI2CFsA-1 Received: by mail-qv1-f69.google.com with SMTP id ib9-20020a0562141c8900b003671c3a1243so2396682qvb.21 for ; Wed, 08 Sep 2021 06:44:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oDhIuIesitJgSZCMfQkMA05YwATVMSovv90av7yyQb4=; b=IfWcK0VqJQbwVOewCbiIL3jUvniQjKblOJshtt2Mv0PZmWUOahH/J/0yz4V6RT0T+J GJ3CfZMObByPpHipGQC0JAWN5knd9fFxS4LLDkvNdReT2O2vTws+t0EGu/i3JE4OqbjS F7WLGzKKnmyvV7UHJdZGUsnoperW+GyaVf7/q9ka5sP7adsis4czdr/m9FFRQfWx8RN3 yRXK2CXX8nrDN4Huk0bcakKdUVhWgO9vO7N+8aNQj1ydR9b/wDYsxJmy2bWErRkPF0Zy zjKH5NmPMrLu2DKQljsBAAGaj1RQHlUrq7V34PMdtCdy/noD99PVQAH37coZPTkznvKM JkyA== X-Gm-Message-State: AOAM530yI6J1UHxUQHZJoMuZGzUyOAxNLsTJID2FriKNZ2oAI4DHF0mW JvD4L6RkwPJCvi+bx+6YkZcIkYnkhluPQMel1dJIb5CWeX3iiV+6vTRqo/O2S7gUczgWLcIF0a8 6QU/DuftOHe7ipbzM8T2BVvzpSDSNVPRhnV4INZp6VrB9TVaL9AIABytAyWBQ7h900A== X-Received: by 2002:a05:620a:294d:: with SMTP id n13mr3435010qkp.179.1631108670630; Wed, 08 Sep 2021 06:44:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmZI6542dvZbeWR9wTM8Q1zYAlHK136TV5kimYMTQvRv00ofk37orWmMGXMwHG00Dv+cJ9Rg== X-Received: by 2002:a05:620a:294d:: with SMTP id n13mr3434963qkp.179.1631108670214; Wed, 08 Sep 2021 06:44:30 -0700 (PDT) Received: from [192.168.1.149] (130-44-159-43.s11817.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id b21sm1494867qte.38.2021.09.08.06.44.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 06:44:29 -0700 (PDT) Subject: Re: [PATCH v2] c-family: Add __builtin_assoc_barrier To: Matthias Kretz , Richard Biener Cc: gcc-patches@gcc.gnu.org References: <2312888.R4OtGj9PrH@excalibur> <1911968.eP8hAHRRDn@excalibur> <2776155.2yzvbfQdsk@excalibur> From: Jason Merrill Message-ID: <9a9052a4-9b38-57f7-f36a-de247b6aa08e@redhat.com> Date: Wed, 8 Sep 2021 09:44:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <2776155.2yzvbfQdsk@excalibur> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 13:44:36 -0000 On 9/8/21 5:37 AM, Matthias Kretz wrote: > On Tuesday, 7 September 2021 19:36:22 CEST Jason Merrill wrote: >>> case PAREN_EXPR: >>> - RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t, 0)))); >>> + if (REF_PARENTHESIZED_P (t)) >>> + RETURN (finish_parenthesized_expr (RECUR (TREE_OPERAND (t, 0)))); >>> + else >>> + RETURN (RECUR (TREE_OPERAND (t, 0))); >> >> I think you need to build a new PAREN_EXPR in the assoc barrier case as >> well, for it to have any effect in templates. > > My intent was to ignore __builtin_assoc_barrier in templates / constexpr > evaluation since it's not affected by -fassociative-math anyway. Or do you > mean something else? I agree about constexpr, but why wouldn't template instantiations be affected by -fassociative-math like any other function? Jason