From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114159 invoked by alias); 14 May 2017 09:11:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 114130 invoked by uid 89); 14 May 2017 09:11:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:HE1PR07 X-HELO: sasl.smtp.pobox.com Received: from pb-smtp1.pobox.com (HELO sasl.smtp.pobox.com) (64.147.108.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 14 May 2017 09:11:34 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 50DCA7F024; Sun, 14 May 2017 05:11:35 -0400 (EDT) Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 475FC7F023; Sun, 14 May 2017 05:11:35 -0400 (EDT) Received: from [192.168.1.4] (unknown [76.215.41.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 937787F022; Sun, 14 May 2017 05:11:34 -0400 (EDT) Subject: Re: [PATCH] [i386] Recompute the frame layout less often To: Bernd Edlinger , "gcc-patches@gcc.gnu.org" References: Cc: Uros Bizjak From: Daniel Santos Message-ID: <9aa7427e-6cfc-b603-2ec4-1f0e02ae294d@pobox.com> Date: Sun, 14 May 2017 09:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: 53EFD220-3885-11E7-A385-EFB41968708C-06139138!pb-smtp1.pobox.com X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg01115.txt.bz2 On 05/14/2017 02:42 AM, Bernd Edlinger wrote: > Hi, > > > this patch uses the new TARGET_COMPUTE_FRAME_LAYOUT hook in the i386 > backend to avoid re-computing the frame layout when not really > necessary. > > It simplifies the logic in ix86_compute_frame_layout by removing > the use_fast_prologue_epilogue_nregs, which is no longer necessary, > because the frame layout can no longer change spontaneously. > > > Bootstrapped and reg-tested on x86_64-pc-linux-gnu. > Is it OK for trunk? > > > Thanks > Bernd. I think Uros is about to commit my improvements to ms to sysv abi calls, which is a large change and will conflict with your patch. I've added several new fields to struct ix86_frame that will need to be merged (and moved to i386.h). I believe that my only explicit check of crtl->stack_realign_finalized is during pro/epilogue expand, and not in ix86_compute_frame_layout. A former incarnation of my patches needed ix86_compute_frame_layout to be called *after* it was set, but I believe that is no longer the case, and so shouldn't conflict, but retesting should certainly be done. https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01338.html Thanks, Daniel