From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout11.t-online.de (mailout11.t-online.de [194.25.134.85]) by sourceware.org (Postfix) with ESMTPS id 906423875450 for ; Thu, 27 Jun 2024 01:27:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 906423875450 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=t-online.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 906423875450 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.25.134.85 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719451638; cv=none; b=YDwREbCaGISQ+40eFhwHzrjH0sZBaGeTjL/vTDkipzzkQ5G8niafrC3g5MIl2KfGAgjQec1K9ULOxAmTdM5Q5G+gI9P1whpe+GHitRfEoFGS/V3m+pGrDPXmXQxL8P3Lb0OZYFh1Uo8gEmVDK7xq+O4tUINcWO2xWBSdHJ6/kJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719451638; c=relaxed/simple; bh=S777wmrYbpBLYQUhJUWRvTWcGC+QPXGfN2A958CjHfs=; h=Message-ID:Subject:From:To:Date:MIME-Version; b=o+qlc8fzy+vbiVqbz99GGaGIZst8fWQlafjP42Ish+4RPiXjvN0xtLNrvSfgT23F2tuJJ0oV0/Js163I9xezqyGUdUNQLH34kfGIvpBkK7TfQ0lfp163YfmAeVUA46NouwnpFEcdxL+3EwtFDKoGFNupAKXT3R9LsmvFx7GEhyk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fwd87.aul.t-online.de (fwd87.aul.t-online.de [10.223.144.113]) by mailout11.t-online.de (Postfix) with SMTP id 3EE9B1604F; Thu, 27 Jun 2024 03:27:15 +0200 (CEST) Received: from localhost.localdomain ([115.165.108.210]) by fwd87.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1sMdur-0fbsqe0; Thu, 27 Jun 2024 03:27:14 +0200 Message-ID: <9ab0ed971ab0851a6d40cfe24260e3efd7bf9380.camel@t-online.de> Subject: Re: [committed] Remove compromised sh test From: Oleg Endo To: Jeff Law , "gcc-patches@gcc.gnu.org" Date: Thu, 27 Jun 2024 10:27:10 +0900 In-Reply-To: <4210b775-a58d-42e1-af2b-2bbe893f75e7@gmail.com> References: <9796ab1d-201f-4097-9cc0-cadbc5a6e499@gmail.com> <2b196d4549b15f47c61b34c8e9da09035691b960.camel@t-online.de> <5e3df9ed-dc09-4f86-8bfb-e33d11d6be6f@gmail.com> <4210b775-a58d-42e1-af2b-2bbe893f75e7@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-TOI-EXPURGATEID: 150726::1719451634-0BFFCE88-49199E48/0/0 CLEAN NORMAL X-TOI-MSGID: 1a18295f-f9e6-4023-aab5-4115a2d0fa72 X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2024-06-26 at 18:30 -0600, Jeff Law wrote: > > >=20 > >=20 > > OK, then what's the default config of your test setup / triplet? > > Can you please show the generated code that you get? Because - like I = said > > - I can't reproduce it. > test01: > sts.l pr,@-r15 ! 31 [c=3D4 l=3D2] movsi_i/10 > add #-4,r15 ! 32 [c=3D4 l=3D2] *addsi3/0 > mov.l .L3,r0 ! 26 [c=3D10 l=3D2] movsi_i/0 > jsr @r0 ! 12 [c=3D5 l=3D2] call_valuei > mov.l r6,@r15 ! 4 [c=3D4 l=3D2] movsi_i/8 > mov.l @r15,r1 ! 29 [c=3D1 l=3D2] movsi_i/5 > add r1,r0 ! 30 [c=3D4 l=3D2] *addsi3/0 > add #4,r15 ! 36 [c=3D4 l=3D2] *addsi3/0 > lds.l @r15+,pr ! 38 [c=3D1 l=3D2] movsi_i/14 > rts > nop ! 40 [c=3D0 l=3D4] *return_i >=20 >=20 > Note that there's a scheduling barrier in the RTL between insns 30 and= =20 > 36. So instructions prior to insn 36 can't be used to fill the delay slo= t. >=20 Thanks. Now I'm also seeing the same result. Needed to specify -O2 to get that. -O1 was not enough it seems. I don't know why you said that the code for this case improved -- it has not?! I think the test is still valid. The reason for the failure might be different from the original one (the scheduling barrier for whatever reason), but the end result is the same -- the last delay slot is not stuffed, although the 'add r1,r0' could go in there. I'd like to revert the removal of this test case, as it catches a valid issue. Best regards, Oleg Endo