From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id BD9FC3858D1E for ; Fri, 10 Nov 2023 23:49:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD9FC3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD9FC3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699660192; cv=none; b=OgQKmDZEn9NrNCitpslY+I4jVrD+ih0Dkk8JOUnRLoRGd1iMQqdhdo2Gj7XwEcpe3DZu3Xohvs9h6J0xNRjddhDsjBUZDupLI1nXC91+OsYCf6Wh3Bo+Ci0nIqZGcUIv0gX6LvUoXRu/0Mj8QMZX3Kn/gnC3ZWfopzj5K9X2v6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699660192; c=relaxed/simple; bh=49+WtwXeHZVnIq9WEgISSPzLJxKvEDfTA28oF9RVU3s=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Zoqcfa24vVWskHeGuvPpHIu6MTVdboWKDhu5acB+qk4ry3Edxt+sc8upvmMsD2BM8eE5iCn9QXa32qijqmKOr5JkUEXJh+BzD4rIekcKrDwYibOrh3g3tWt2iobazeq9ZUNs0ym7aO8bJW384qmZXBsQU5e+L9TzMFBDeYCRSuM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-3594560fa09so9765895ab.0 for ; Fri, 10 Nov 2023 15:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699660189; x=1700264989; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5nsvjyqicFOvSwobI+NKwZmwwgWAN3uhfWNLCpHTx5U=; b=Z/dzfsNbGTuYMtQ5ac478cJ0uzAxCQdyULcuO+OgbAjuMKJ1v+ZXOPxzOlDsUkoHtS qbwt3dIhhk8ma80ew9SC5C4o1/AZo3PkskPJoOzDsiWtUTvmZIpXYZ6EL/LgzWjT1XKt qW+Ie2osfd17mzdCcgKYrdcIMDKGVIxpBFBT7fK1UwqmwhPjdZIo2LFhvgPmJuSXShee QVstQYAegzsL2ykd/8dVIvlqAw1T6Ib5h9fIev6JC/vKLgfRjjPCSrEwx+h9xCDn8A6k aPUYp7m+5rHpvDpjcA9Md7RyJ+1iFCFQOTd87kAbvuE3l9+TDFGhTIaXVOyC3q3f+bCl GHiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699660189; x=1700264989; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5nsvjyqicFOvSwobI+NKwZmwwgWAN3uhfWNLCpHTx5U=; b=SQ08OEDkcF3HE+uBpbg/VpC7XVq6w5y/ndlxLi7N5VqLEnlULEInkqn/T6Q8VWgais cFnPojTkurKWfhLGF1lKrmG8xuM0c+d5YLVpBJdgdtdley76GnUaVwoGKi/Aipcvqyxv 85zn/yM46Ab6lXYd2jp91u7W9cTEGGbSSPxWIPFAesjv5m5sxPXecJqNe60mwN7PV1ti IZDzQtW5KsYrT84Lr/j1F/KwExf6a0KTWyStKHr/6IQ4/4kzoZ07SkP2zUdBtYBj1pG6 CWHYwwXDHylVbVz94eIrtPIowrs/MfFwd8ChL3aNLAnEvOxc+/8SCz9qsIhxpET5OQ2M iP/w== X-Gm-Message-State: AOJu0YwmSp0R64/m/Xa8ZxgCHwLbm3HPgmZEIpCHAW3kEo7oHrnLH7iF GONgM2o2bqzolKg3Kvtn/qXBVqbl3tnQIA== X-Google-Smtp-Source: AGHT+IFyCo4skeILv8YDadwiK4qR20tpp7H73e8HDm6/FnLO01cDIUEnmmKfY1y4ThdxeTjKYzjWbw== X-Received: by 2002:a05:6e02:1885:b0:359:cbff:fc50 with SMTP id o5-20020a056e02188500b00359cbfffc50mr1261745ilu.11.1699660189485; Fri, 10 Nov 2023 15:49:49 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id x16-20020a92b010000000b003506f457d70sm98308ilh.63.2023.11.10.15.49.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Nov 2023 15:49:49 -0800 (PST) Message-ID: <9ab8c5e2-806b-4ab2-a4cd-fcce2491e6d9@gmail.com> Date: Fri, 10 Nov 2023 16:49:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libgcc/m68k: Fixes for soft float Content-Language: en-US To: Keith Packard , gcc-patches@gcc.gnu.org References: <20230823021504.3864764-1-keithp@keithp.com> From: Jeff Law In-Reply-To: <20230823021504.3864764-1-keithp@keithp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/22/23 20:15, Keith Packard via Gcc-patches wrote: > Check for non-zero denorm in __adddf3. Need to check both the upper and > lower 32-bit chunks of a 64-bit float for a non-zero value when > checking to see if the value is -0. > > Fix __addsf3 when the sum exponent is exactly 0xff to ensure that > produces infinity and not nan. > > Handle converting NaN/inf values between formats. > > Handle underflow and overflow when truncating. > > Write a replacement for __fixxfsi so that it does not raise extra > exceptions during an extra conversion from long double to double. > > Signed-off-by: Keith Packard I pushed this to the trunk after fixing a few minor whitespace nits. You didn't mention the divdf change, but I'll assume that was just an oversight. I'm largely trusting your reputation on the fpgnulib changes. I won't claim to know that code at all. The assembly bits were simple enough that I could make out what you were doing relatively easily. Thanks again, Jeff