From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47218 invoked by alias); 19 Dec 2017 10:49:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 47203 invoked by uid 89); 19 Dec 2017 10:49:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Dec 2017 10:49:27 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6D126AE61; Tue, 19 Dec 2017 10:49:25 +0000 (UTC) Subject: Re: Replying to an older patch ([PATCH] Fix failing test-case) To: Sudakshina Das , "gcc-patches@gcc.gnu.org" Cc: nd , hubika@ucw.cz References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <9ae1eb49-a759-8c7e-f8fd-01e5d0f245e0@suse.cz> Date: Tue, 19 Dec 2017 10:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------0405700B655007C468E2D743" X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg01233.txt.bz2 This is a multi-part message in MIME format. --------------0405700B655007C468E2D743 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-length: 657 On 11/30/2017 12:03 PM, Sudakshina Das wrote: > https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01157.html > > This patch fixed a test case switch-case-2.c. I am seeing switch-case-1.c failing on > > arm-none-linux-gnueabihf: > FAIL: gcc.dg/tree-prof/switch-case-1.c scan-rtl-dump-times expand ";; basic block[^\\n]*count 2000" 1 (found 0 times) > > aarch64-none-linux-gnu: > FAIL: gcc.dg/tree-prof/switch-case-1.c scan-rtl-dump-times expand ";; basic block[^\\n]*count 2000" 1 (found 2 times) > > which looks pretty similar (also the same changes make it pass). Can you confirm? > > Sudi Hello. There's patch for that. Can you please test it? Martin --------------0405700B655007C468E2D743 Content-Type: text/x-patch; name="0001-Fix-another-failing-test-case.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-another-failing-test-case.patch" Content-length: 1506 >From e4570be2df2c2fd62d21bca829376670cbb96dc2 Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 19 Dec 2017 11:47:56 +0100 Subject: [PATCH] Fix another failing test-case. gcc/testsuite/ChangeLog: 2017-12-19 Martin Liska * gcc.dg/tree-prof/switch-case-1.c: Scan IPA profile dump file instead of expand in order to not mix it with expanded tree decision tree for the switch statement. --- gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c b/gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c index 6a9af083a9a..a5a430a8ed5 100644 --- a/gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c +++ b/gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c @@ -1,4 +1,4 @@ -/* { dg-options "-O2 -fdump-rtl-expand-all" } */ +/* { dg-options "-O2 -fdump-ipa-profile-all" } */ int g; __attribute__((noinline)) void foo (int n) @@ -36,5 +36,5 @@ int main () return 0; } /* autofdo cannot do that precise execution numbers */ -/* { dg-final-use-not-autofdo { scan-rtl-dump-times ";; basic block\[^\\n\]*count 4000" 2 "expand"} } */ -/* { dg-final-use-not-autofdo { scan-rtl-dump-times ";; basic block\[^\\n\]*count 2000" 1 "expand"} } */ +/* { dg-final-use-not-autofdo { scan-ipa-dump-times ";; basic block\[^\\n\]*count 4000" 2 "profile"} } */ +/* { dg-final-use-not-autofdo { scan-ipa-dump-times ";; basic block\[^\\n\]*count 2000" 1 "profile"} } */ -- 2.14.3 --------------0405700B655007C468E2D743--