From: Xi Ruoyao <xry111@mengyan1223.wang>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Cc: Matthew Fortune <mfortune@gmail.com>
Subject: Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline
Date: Fri, 25 Jun 2021 01:02:29 +0800 [thread overview]
Message-ID: <9ae500112d9c23f025576c2443c639ba0d0bbc26.camel@mengyan1223.wang> (raw)
In-Reply-To: <f7ca1d6a-0134-aea1-008b-d8b1a56709ba@gmail.com>
On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote:
>
>
> On 6/22/2021 1:05 AM, Xi Ruoyao via Gcc-patches wrote:
> > mips.exp does not support -fno-inline, causing the tests return
> > "ERROR:
> > Unrecognised option: -fno-inline for dg-options ... ".
> >
> > Use noinline attribute like other mips target tests, to workaround
> > it.
> >
> > gcc/testsuite/
> >
> > * gcc.target/mips/cfgcleanup-jalr2.c: Remove -fno-inline and
> > add
> > __attribute__((noinline)).
> > * gcc.target/mips/cfgcleanup-jalr3.c: Likewise.
> I'd like to know a bit more here. mips.exp shouldn't care about the
> options passed to the compiler and to the best of my knowledge
> -fno-inline is still a valid GCC option. So while I don't think the
> patch itself is wrong, I question if it's necessary and whether or not
> your just papering over some other issue.
There is some logic processing options in mips.exp. Some options are
overrided for multilib. It seems the mips.exp was originally designed
as:
* MIPS options should go in dg-options
* Other options should go in dg-additional-options
In d2148424165 marxin merged some dg-additional-options into dg-options,
exploited the problem.
And, the "origin" convention seems already broken: there is something
like -funroll-loops which is not a MIPS option, but accepted by mips.exp
in dg-options.
Possiblities are:
(1) this patch
(2) make mips.exp accept -fno-inline as "if it is a MIPS option"
(3) refactor mips.exp to pass everything itself doesn't know directly to
gcc
--
Xi Ruoyao <xry111@mengyan1223.wang>
next prev parent reply other threads:[~2021-06-24 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 7:05 Xi Ruoyao
2021-06-24 16:48 ` Jeff Law
2021-06-24 17:02 ` Xi Ruoyao [this message]
2021-06-25 11:13 ` Richard Sandiford
2021-06-25 13:21 ` Xi Ruoyao
2021-06-25 14:40 ` Richard Sandiford
2021-07-08 23:44 ` Jeff Law
2021-07-09 6:42 ` Xi Ruoyao
2021-07-09 11:16 ` Richard Sandiford
2021-07-23 2:21 ` Maciej W. Rozycki
2021-07-23 3:18 ` Xi Ruoyao
2021-07-23 6:01 ` Xi Ruoyao
2021-07-26 13:55 ` Richard Sandiford
2021-07-26 15:02 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae500112d9c23f025576c2443c639ba0d0bbc26.camel@mengyan1223.wang \
--to=xry111@mengyan1223.wang \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=mfortune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).