From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id BD6043858C50 for ; Tue, 14 May 2024 02:07:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD6043858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD6043858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715652445; cv=none; b=XwEx4ipW8Nz9DjAvXUda2ePhdNejtC20SgvfxBsx84StMIfAn9Ng6shV6cqzbEALREJBRK0CI5BdfRAMUwtCIpxsM77eVta/7rMquCa1/t0ep2vNEYIhxv9QyDtMGqGKixQ7OkAvh+jgp+VSjOt+d7rlIwJDAMCUMsZ1NtXlcMA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715652445; c=relaxed/simple; bh=yHc1Nsu59T4PZomHBImgzaPKfvXvjG1nQfkwsF/nEBM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WWSrKn357I0cH1uAE0cCobbZJs6C0uwbJGKYPfz0cvRzxzASSUfx9IBYZGSuKzIGLnlPuNB8ySHlBmhl+qX/tgHJFmQQA3Xhn6g8g/3hJpbaAWVYcFllQkg+GuEZSOpyr94jgNof+vTuHii9+JcuEI3EZdhslKy4NsOeobRgNDY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44E1SJBp024876; Tue, 14 May 2024 02:07:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : cc : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=KBHH3VegXpnh7ldRGsQD9wEW6mDZYQzZuUTs+fCkg3s=; b=Oa4YqBb/uPwCfBnLkJhBSGbUB4qrXQAeMb7SCdAHo6tJQe68wv6QHvy7gUFWYr+n2lAQ beXb2t5C8EalbseBvXl1fLywJcdkRbkoo7pRcLapccAFoZGCYqbwube0i5kvQq2a4kbZ 3fk5+kmMEk5YlNVUszOjKvoG9hFY5XatU6scdHQIxuU5q1YixZI5dq0/fcLr4CSgvTnD Sb6XioBlfRD7mk+bNZ5IfDf4Blkl3Capyg+c75CXxNkg4ogRTKQRvCIOtkzs/fsErEko M3jTSt1K1axWMSz2dVBD5LxGWxgGbPVAb0ZQmkTrNageXRspBH+IaUSTAkKYuqGAM4cy Dg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y3tnp8f76-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 02:07:11 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 44E27BF7015479; Tue, 14 May 2024 02:07:11 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y3tnp8f74-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 02:07:11 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 44E1RWAc006769; Tue, 14 May 2024 02:07:10 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3y2mgmas5s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 02:07:10 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 44E275fs53346776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 May 2024 02:07:07 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E7F9F2004E; Tue, 14 May 2024 02:07:04 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7605720040; Tue, 14 May 2024 02:07:03 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 14 May 2024 02:07:03 +0000 (GMT) Message-ID: <9af563af-3e3c-b313-cfef-cda2685363ec@linux.ibm.com> Date: Tue, 14 May 2024 10:06:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 5/13] rs6000, remove duplicated built-ins of vecmergl and vec_mergeh Content-Language: en-US To: Carl Love References: <6378d560-df55-4b75-be7b-93dc6b85d81a@linux.ibm.com> <20e2072f-53e9-45fc-a498-a30dd5d59c23@linux.ibm.com> Cc: gcc-patches@gcc.gnu.org, "bergner@linux.ibm.com" , Segher Boessenkool , David Edelsohn From: "Kewen.Lin" In-Reply-To: <20e2072f-53e9-45fc-a498-a30dd5d59c23@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: rcVi2Pj4gkkMS0d_FbDbWsN_FBF8PTGd X-Proofpoint-ORIG-GUID: 8Ql2hghFSCRnk1_ViL5Rb35xI0fceb_k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-13_17,2024-05-10_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 bulkscore=0 mlxlogscore=990 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405140014 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, on 2024/4/20 05:17, Carl Love wrote: > rs6000, remove duplicated built-ins of vecmergl and vec_mergeh > > The following undocumented built-ins are same as existing documented > overloaded builtins. > > const vf __builtin_vsx_xxmrghw (vf, vf); > same as vf __builtin_vec_mergeh (vf, vf); (overloaded vec_mergeh) > > const vsi __builtin_vsx_xxmrghw_4si (vsi, vsi); > same as vsi __builtin_vec_mergeh (vsi, vsi); (overloaded vec_mergeh) > > const vf __builtin_vsx_xxmrglw (vf, vf); > same as vf __builtin_vec_mergel (vf, vf); (overloaded vec_mergel) > > const vsi __builtin_vsx_xxmrglw_4si (vsi, vsi); > same as vsi __builtin_vec_mergel (vsi, vsi); (overloaded vec_mergel) > > This patch removes the duplicate built-in definitions so only the > documented built-ins will be available for use. The case statements in > rs6000_gimple_fold_builtin are removed as they are no longer needed. The > patch removes the now unused define_expands for vsx_xxmrghw_ and > vsx_xxmrglw_. Ok for trunk, thanks! BR, Kewen > > gcc/ChangeLog: > * config/rs6000/rs6000-builtins.def (__builtin_vsx_xxmrghw, > __builtin_vsx_xxmrghw_4si, __builtin_vsx_xxmrglw, > __builtin_vsx_xxmrglw_4si, __builtin_vsx_xxsel_16qi): Remove > built-in definition. > * config/rs6000/rs6000-builtin.cc (rs6000_gimple_fold_builtin): > remove case entries RS6000_BIF_XXMRGLW_4SI, > RS6000_BIF_XXMRGLW_4SF, RS6000_BIF_XXMRGHW_4SI, > RS6000_BIF_XXMRGHW_4SF. > * config/rs6000/vsx.md (vsx_xxmrghw_, vsx_xxmrglw_): > Remove unused define_expands. > --- > gcc/config/rs6000/rs6000-builtin.cc | 4 --- > gcc/config/rs6000/rs6000-builtins.def | 12 -------- > gcc/config/rs6000/vsx.md | 41 --------------------------- > 3 files changed, 57 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc > index ac9f16fe51a..f83d65b06ef 100644 > --- a/gcc/config/rs6000/rs6000-builtin.cc > +++ b/gcc/config/rs6000/rs6000-builtin.cc > @@ -2097,20 +2097,16 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator *gsi) > /* vec_mergel (integrals). */ > case RS6000_BIF_VMRGLH: > case RS6000_BIF_VMRGLW: > - case RS6000_BIF_XXMRGLW_4SI: > case RS6000_BIF_VMRGLB: > case RS6000_BIF_VEC_MERGEL_V2DI: > - case RS6000_BIF_XXMRGLW_4SF: > case RS6000_BIF_VEC_MERGEL_V2DF: > fold_mergehl_helper (gsi, stmt, 1); > return true; > /* vec_mergeh (integrals). */ > case RS6000_BIF_VMRGHH: > case RS6000_BIF_VMRGHW: > - case RS6000_BIF_XXMRGHW_4SI: > case RS6000_BIF_VMRGHB: > case RS6000_BIF_VEC_MERGEH_V2DI: > - case RS6000_BIF_XXMRGHW_4SF: > case RS6000_BIF_VEC_MERGEH_V2DF: > fold_mergehl_helper (gsi, stmt, 0); > return true; > diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def > index 5b7237a2327..d09e21a9151 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -1904,18 +1904,6 @@ > const signed int __builtin_vsx_xvtsqrtsp_fg (vf); > XVTSQRTSP_FG vsx_tsqrtv4sf2_fg {} > > - const vf __builtin_vsx_xxmrghw (vf, vf); > - XXMRGHW_4SF vsx_xxmrghw_v4sf {} > - > - const vsi __builtin_vsx_xxmrghw_4si (vsi, vsi); > - XXMRGHW_4SI vsx_xxmrghw_v4si {} > - > - const vf __builtin_vsx_xxmrglw (vf, vf); > - XXMRGLW_4SF vsx_xxmrglw_v4sf {} > - > - const vsi __builtin_vsx_xxmrglw_4si (vsi, vsi); > - XXMRGLW_4SI vsx_xxmrglw_v4si {} > - > const vsc __builtin_vsx_xxpermdi_16qi (vsc, vsc, const int<2>); > XXPERMDI_16QI vsx_xxpermdi_v16qi {} > > diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md > index 3d39ae7995f..26560ecc38a 100644 > --- a/gcc/config/rs6000/vsx.md > +++ b/gcc/config/rs6000/vsx.md > @@ -4810,47 +4810,6 @@ > } > [(set_attr "type" "vecperm")]) > > -;; V4SF/V4SI interleave > -(define_expand "vsx_xxmrghw_" > - [(set (match_operand:VSX_W 0 "vsx_register_operand" "=wa") > - (vec_select:VSX_W > - (vec_concat: > - (match_operand:VSX_W 1 "vsx_register_operand" "wa") > - (match_operand:VSX_W 2 "vsx_register_operand" "wa")) > - (parallel [(const_int 0) (const_int 4) > - (const_int 1) (const_int 5)])))] > - "VECTOR_MEM_VSX_P (mode)" > -{ > - rtx (*fun) (rtx, rtx, rtx); > - fun = BYTES_BIG_ENDIAN ? gen_altivec_vmrghw_direct_ > - : gen_altivec_vmrglw_direct_; > - if (!BYTES_BIG_ENDIAN) > - std::swap (operands[1], operands[2]); > - emit_insn (fun (operands[0], operands[1], operands[2])); > - DONE; > -} > - [(set_attr "type" "vecperm")]) > - > -(define_expand "vsx_xxmrglw_" > - [(set (match_operand:VSX_W 0 "vsx_register_operand" "=wa") > - (vec_select:VSX_W > - (vec_concat: > - (match_operand:VSX_W 1 "vsx_register_operand" "wa") > - (match_operand:VSX_W 2 "vsx_register_operand" "wa")) > - (parallel [(const_int 2) (const_int 6) > - (const_int 3) (const_int 7)])))] > - "VECTOR_MEM_VSX_P (mode)" > -{ > - rtx (*fun) (rtx, rtx, rtx); > - fun = BYTES_BIG_ENDIAN ? gen_altivec_vmrglw_direct_ > - : gen_altivec_vmrghw_direct_; > - if (!BYTES_BIG_ENDIAN) > - std::swap (operands[1], operands[2]); > - emit_insn (fun (operands[0], operands[1], operands[2])); > - DONE; > -} > - [(set_attr "type" "vecperm")]) > - > ;; Shift left double by word immediate > (define_insn "vsx_xxsldwi_" > [(set (match_operand:VSX_L 0 "vsx_register_operand" "=wa")