From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Tejas Belagod <Tejas.Belagod@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch 2/8, Arm, GCC] Add Armv8.1-M Mainline target feature +pacbti. [Was RE: [Patch 1/7, Arm, GCC] Add Armv8.1-M Mainline target feature +pacbti.]
Date: Fri, 3 Dec 2021 14:59:52 +0000 [thread overview]
Message-ID: <9afe6492-1ef2-1443-33d1-46a5ab72d6d1@foss.arm.com> (raw)
In-Reply-To: <PAXPR08MB707558EB7F0871A67A7E9574EA869@PAXPR08MB7075.eurprd08.prod.outlook.com>
On 28/10/2021 12:41, Tejas Belagod via Gcc-patches wrote:
>
>
>> -----Original Message-----
>> From: Richard Earnshaw <Richard.Earnshaw@arm.com>
>> Sent: Monday, October 11, 2021 1:29 PM
>> To: Tejas Belagod <Tejas.Belagod@arm.com>; gcc-patches@gcc.gnu.org
>> Subject: Re: [Patch 1/7, Arm, GCC] Add Armv8.1-M Mainline target feature
>> +pacbti.
>>
>> On 08/10/2021 13:17, Tejas Belagod via Gcc-patches wrote:
>>> Hi,
>>>
>>> This patch adds the -march feature +pacbti to Armv8.1-M Mainline.
>>> This feature enables pointer signing and authentication instructions
>>> on M-class architectures.
>>>
>>> Tested on arm-none-eabi. OK for trunk?
>>>
>>> 2021-10-04 Tejas Belagod <tbelagod@arm.com>
>>>
>>> gcc/Changelog:
>>>
>>> * config/arm/arm-cpus.in: Define new feature pacbti.
>>> * config/arm/arm.h (TARGET_HAVE_PACBTI): New.
>>>
>>
>> "+pacbti" needs to be documented in invoke.texi at the appropriate place.
>>
>
> Thanks for the reviews.
>
> This patch adds the -march feature +pacbti to Armv8.1-M Mainline.
> This feature enables pointer signing and authentication instructions
> on M-class architectures.
>
> 2021-10-25 Tejas Belagod <tbelagod@arm.com>
>
> gcc/Changelog:
>
> * config/arm/arm-cpus.in: Define new feature pacbti.
> * config/arm/arm.h (TARGET_HAVE_PACBTI): New.
> * doc/invoke.texi: Document new feature pacbti.
This isn't in the correct style:
gcc/Changelog:
* config/arm/arm.h (TARGET_HAVE_PACBTI): New macro.
* config/arm/arm-cpus.in (pacbti): New feature.
* doc/invoke.texi (Arm Options): Document it.
would be better.
>
>
> Tested the following configurations, OK for trunk?
>
> -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft
> -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp
> mcmodel=small and tiny
> aarch64-none-linux-gnu native test and bootstrap
>
>
>> R.
Otherwise OK.
R.
prev parent reply other threads:[~2021-12-03 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 11:41 Tejas Belagod
2021-12-03 14:59 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9afe6492-1ef2-1443-33d1-46a5ab72d6d1@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tejas.Belagod@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).