From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 88CAE3858C27 for ; Fri, 3 Dec 2021 14:59:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 88CAE3858C27 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 365EF1396; Fri, 3 Dec 2021 06:59:55 -0800 (PST) Received: from [10.57.0.71] (unknown [10.57.0.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BADD73F73B; Fri, 3 Dec 2021 06:59:53 -0800 (PST) Subject: Re: [Patch 2/8, Arm, GCC] Add Armv8.1-M Mainline target feature +pacbti. [Was RE: [Patch 1/7, Arm, GCC] Add Armv8.1-M Mainline target feature +pacbti.] To: Tejas Belagod , Richard Earnshaw , "gcc-patches@gcc.gnu.org" References: From: Richard Earnshaw Message-ID: <9afe6492-1ef2-1443-33d1-46a5ab72d6d1@foss.arm.com> Date: Fri, 3 Dec 2021 14:59:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3491.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 14:59:57 -0000 On 28/10/2021 12:41, Tejas Belagod via Gcc-patches wrote: > > >> -----Original Message----- >> From: Richard Earnshaw >> Sent: Monday, October 11, 2021 1:29 PM >> To: Tejas Belagod ; gcc-patches@gcc.gnu.org >> Subject: Re: [Patch 1/7, Arm, GCC] Add Armv8.1-M Mainline target feature >> +pacbti. >> >> On 08/10/2021 13:17, Tejas Belagod via Gcc-patches wrote: >>> Hi, >>> >>> This patch adds the -march feature +pacbti to Armv8.1-M Mainline. >>> This feature enables pointer signing and authentication instructions >>> on M-class architectures. >>> >>> Tested on arm-none-eabi. OK for trunk? >>> >>> 2021-10-04 Tejas Belagod >>> >>> gcc/Changelog: >>> >>> * config/arm/arm-cpus.in: Define new feature pacbti. >>> * config/arm/arm.h (TARGET_HAVE_PACBTI): New. >>> >> >> "+pacbti" needs to be documented in invoke.texi at the appropriate place. >> > > Thanks for the reviews. > > This patch adds the -march feature +pacbti to Armv8.1-M Mainline. > This feature enables pointer signing and authentication instructions > on M-class architectures. > > 2021-10-25 Tejas Belagod > > gcc/Changelog: > > * config/arm/arm-cpus.in: Define new feature pacbti. > * config/arm/arm.h (TARGET_HAVE_PACBTI): New. > * doc/invoke.texi: Document new feature pacbti. This isn't in the correct style: gcc/Changelog: * config/arm/arm.h (TARGET_HAVE_PACBTI): New macro. * config/arm/arm-cpus.in (pacbti): New feature. * doc/invoke.texi (Arm Options): Document it. would be better. > > > Tested the following configurations, OK for trunk? > > -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft > -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp > mcmodel=small and tiny > aarch64-none-linux-gnu native test and bootstrap > > >> R. Otherwise OK. R.