From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 3E9A53858D3C for ; Fri, 9 Jun 2023 13:29:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E9A53858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-64d44b198baso1375749b3a.0 for ; Fri, 09 Jun 2023 06:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686317385; x=1688909385; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I5KUVzdHZq47/qWUDZ3rWQbXYMp2jrbWr8Uv5bCwFBg=; b=i45IhLDSBbCFPe9DwqNYZdJdmN+3u9tZ2shAWYwsGzv/4LeFvfbHoOoLnJ3J/oYF15 PC8SzoM8ugbXSV0g9LuzzD2gSCtVq5VYopr36lBtLRDxZtFLvBjexxmj5lxfFnODWJL3 uu4SeHGt0LSYvXbwJz5yOaE80WXn8+CPw4JnG1sGN/dGIAn9iQpL8nzudyxNTRK+JAQg 97opoDhUirtweRh0dQzBFNh2ZJkob7Wyn7N0hF4FkETdSF+YQJBqJI9aZzMkLwyjfAJl rIiQpkAg+32xLMaC9aeCMd0dWi2jYVbs8CPUvDJtayS+gFyWEIOoNWq0IXzGFeDcP1Yn N9tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686317385; x=1688909385; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I5KUVzdHZq47/qWUDZ3rWQbXYMp2jrbWr8Uv5bCwFBg=; b=EQjNfMXJvHGld4pTsAAnzOkgz/lXQ8dwBc9e6kKPk3pMO2IuVZRYhHFekzxQ8flD57 kHrxUBA8Xm+p/kZOKi9PQDTPEwDguvUXLFF5kovjGuBlysM+jkpeP6p44FvcAsWJO8ar phRMqEDH5KKlpUqmeuBU4jSp0JfGF+daTkPU7MghtJeRq0bMAdP4i1+W6IzHjk4nDd5r 5CPYnUlM9u+G6hPoU7nRMsOyPdpk1l/8D/JLywzZQXVN4TqNwDBNHDuIGH3sfM5IQ1em tU0cbqjKLaeiSc3ISuOE0vUmXebUot8+DGuyzmaJUmKER6K/w0wyQeh8ORZznpomz1g7 nI2Q== X-Gm-Message-State: AC+VfDxu5Ap1v1//A4d7/hwU9lz/1JcFzOu8XJE4iNDUCN1bGHKJkYD5 JOMPm9fXjbzDh0qtzHGlwTc= X-Google-Smtp-Source: ACHHUZ6f+aZMEyXz+ro7RvowNp+HelaYCzoxbMGEUGe9o4QFl7KBpRCzbnbMmS3Oc5R6aISQW91kjw== X-Received: by 2002:a05:6a20:729a:b0:104:28d6:5db3 with SMTP id o26-20020a056a20729a00b0010428d65db3mr5922158pzk.29.1686317385339; Fri, 09 Jun 2023 06:29:45 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id w7-20020a655347000000b004ff6b744248sm2719170pgr.48.2023.06.09.06.29.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 06:29:44 -0700 (PDT) Message-ID: <9b66e5df-adeb-c6f3-8ffb-f3a9faf5b0c9@gmail.com> Date: Fri, 9 Jun 2023 07:29:43 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] testsuite: fix the condition bug in tsvc s176 Content-Language: en-US To: Richard Biener , Lehua Ding Cc: gcc-patches@gcc.gnu.org References: <20230609095745.306767-1-lehua.ding@rivai.ai> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/9/23 05:56, Richard Biener via Gcc-patches wrote: > On Fri, Jun 9, 2023 at 11:58 AM Lehua Ding wrote: >> >>> It's odd that the checksum doesn't depend on the number of iterations done ... >> >> This is because the difference between the calculated result (32063.902344) and >> the expected result (32000.000000) is small. The current check is that the result >> is considered correct as long as the `value/expected` ratio is between 0.99f and >> 1.01f. > > Oh, I see ... > >> I'm not sure if this check is enough, but I should also update the expected >> result to 32063.902344 (the same without vectorized). > > OK. > >> Best, >> Lehua >> >> gcc/testsuite/ChangeLog: >> >> * gcc.dg/vect/tsvc/tsvc.h: >> * gcc.dg/vect/tsvc/vect-tsvc-s176.c: I stitched together appropriate ChangeLog entries and pushed this to the trunk (I don't think Lehua has write access). jeff