From: Bernd Schmidt <bschmidt@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 0/9] RFC: selftests based on RTL dumps
Date: Tue, 13 Sep 2016 11:35:00 -0000 [thread overview]
Message-ID: <9b71a775-cf7c-1b14-1ce4-b146523663a3@redhat.com> (raw)
In-Reply-To: <1473706655.6782.36.camel@redhat.com>
On 09/12/2016 08:57 PM, David Malcolm wrote:
> I'm not sure I follow - this sounds like a dedicated target for
> selftesting.
>
> Would it be a separate configuration i.e. something like:
> ../src/configure --target=rtl-selftest
> or somesuch?
The way I imagine it working, the top-level Makefile would create a
selftest-gcc/ subdirectory, and run a configure line much like the above
inside it. It would live independently of the real compiler we're
building in gcc/.
That's not something I'm deciding, it needs a broader consensus. But I
feel pretty strongly that this is how things should be organized.
>>> + const char *input_dump
>>> + = ("(insn 8 0 9 2 (set (reg:DI 78)\n"
>>> + " (lshiftrt:DI (reg:DI 76)\n"
>>> + " (const_int 32 [0x20])))\n"
>>> + " ../../src/gcc/testsuite/gcc.dg/asr_div1.c:14\n"
>>> + " 641 {*aarch64_lshr_sisd_or_int_di3}\n"
>>> + " (expr_list:REG_DEAD (reg:DI 76)\n"
>>> + " (nil)))\n"
>>> + "(insn 9 8 0 2 (set (reg:SI 79)\n"
>>> + " (ashiftrt:SI (subreg:SI (reg:DI 78) 0)\n"
>>> + " (const_int 3 [0x3])))\n"
>>> + " ../../src/gcc/testsuite/gcc.dg/asr_div1.c:14\n"
>>> + " 642 {*aarch64_ashr_sisd_or_int_si3}\n"
>>> + " (expr_list:REG_DEAD (reg:DI 78)\n"
>>> + " (nil)))\n");
>>
>> I can sort of see the desire to just copy&paste dumps into this, but
>> this strikes me as really ugly. Especially if we end up using real
>> targets this hard-codes not just pattern structure but also pattern
>> names, which I think is too great a burden on target maintainers.
>
> Note that the loader now resets INSN_CODE to -1, regardless of the
> actual code passed in, to force re-recognition, and to isolate the
> dumps somewhat from changes to the .md files. So although the above
> says insn 641 and 642 (for some snapshot of the aarch64 md file), it
> gets reset to -1.
Best to find out a way to avoid including it in the strings then, to
avoid confusion.
Bernd
next prev parent reply other threads:[~2016-09-13 11:15 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 0:01 David Malcolm
2016-09-09 0:01 ` [PATCH 1/9] Introduce class rtx_reader David Malcolm
2016-09-16 22:15 ` Jeff Law
2016-09-21 17:22 ` [PATCH, v2] " David Malcolm
2016-09-21 20:44 ` Richard Sandiford
2016-09-09 0:01 ` [PATCH 8/9] final.c selftests David Malcolm
2016-09-16 21:12 ` Jeff Law
2016-09-16 21:41 ` David Malcolm
2016-09-19 21:38 ` Jeff Law
2016-09-09 0:01 ` [PATCH 3/9] selftest.h: add temp_override fixture David Malcolm
2016-09-14 22:24 ` Trevor Saunders
2016-09-16 20:37 ` Jeff Law
2016-09-09 0:01 ` [PATCH 7/9] combine.c selftests David Malcolm
2016-09-16 20:45 ` Jeff Law
2016-09-16 21:39 ` David Malcolm
2016-09-09 0:01 ` [PATCH 2/9] Add selftest::read_file David Malcolm
2016-09-16 21:19 ` Jeff Law
2016-09-09 0:01 ` [PATCH 9/9] cse.c selftests David Malcolm
2016-09-16 20:34 ` Jeff Law
2016-09-16 21:28 ` David Malcolm
2016-09-19 17:37 ` Jeff Law
2016-09-22 3:23 ` [PATCH] Introduce selftest::locate_file David Malcolm
2016-09-28 16:33 ` Jeff Law
2016-09-09 0:01 ` [PATCH 4/9] Expose forcibly_ggc_collect and run it after all selftests David Malcolm
2016-09-16 20:30 ` Jeff Law
2016-09-09 0:01 ` [PATCH 6/9] df selftests David Malcolm
2016-09-16 20:40 ` Jeff Law
2016-09-16 21:34 ` David Malcolm
2016-09-09 0:13 ` [PATCH 5/9] Introduce class function_reader David Malcolm
2016-09-16 21:31 ` Jeff Law
2016-09-16 22:04 ` David Malcolm
2016-09-19 21:39 ` Jeff Law
2016-09-12 14:14 ` [PATCH 0/9] RFC: selftests based on RTL dumps Bernd Schmidt
2016-09-12 18:59 ` David Malcolm
2016-09-13 11:35 ` Bernd Schmidt [this message]
2016-09-14 10:33 ` Bernd Schmidt
2016-09-16 20:26 ` Jeff Law
2016-09-16 21:28 ` David Malcolm
2016-09-19 17:50 ` Jeff Law
2016-09-20 14:34 ` Register numbers in RTL dumps (was Re: [PATCH 0/9] RFC: selftests based on RTL dumps) David Malcolm
2016-09-20 14:38 ` Bernd Schmidt
2016-09-20 15:26 ` Jeff Law
2016-09-20 15:38 ` Bernd Schmidt
2016-09-20 19:35 ` David Malcolm
2016-09-21 18:59 ` [PATCH] print-rtx.c: add 'h', v' and 'p' prefixes to regnos David Malcolm
2016-09-28 16:30 ` Jeff Law
2016-09-28 16:33 ` Bernd Schmidt
2016-09-28 17:11 ` Jeff Law
2016-09-28 17:19 ` Bernd Schmidt
2016-09-29 13:00 ` David Malcolm
2016-09-29 17:32 ` Jeff Law
2016-09-13 20:39 ` [PATCH 0/9] RFC: selftests based on RTL dumps Jeff Law
2016-09-14 8:44 ` Richard Biener
2016-09-16 20:16 ` Jeff Law
2016-09-16 21:27 ` David Malcolm
2016-09-19 12:21 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b71a775-cf7c-1b14-1ce4-b146523663a3@redhat.com \
--to=bschmidt@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).