From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 1F0FE3857357 for ; Thu, 4 Jan 2024 19:50:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F0FE3857357 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F0FE3857357 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704397811; cv=none; b=jn9dnNlLyKK2e/lSzPvzKjbcGgL6tkokshUwMD4b+3JJ17ihzlUNJgKs1HAcQ/HYiyMCr4CgSU00zDan+U7Ok6XQot5EKUhu/9FgFgJ7vBkzGZILNMGfCrHtn67xCQzH4P6TQeJbM3pcJ6YdqEl8PN/GnyREzXpurCf6lt14eP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704397811; c=relaxed/simple; bh=+aifDwn0iuwAw5B3PoZsVrqXOtx0/1zOSn/FvfUvzxA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NiwvhQyihhziBx2LIvQnlvpTxOgx1HKEHn3YeiDQ39FrGfRSJSktcoHmF6iW05hfiImwXfbuD9oUcQEVDiGPI69fZnY/Xax5csN39bSuIsjpGKNx1RkK5TgLwdXpLqo4elRO0CjZJSoSqSu1V2xkDZKjXJTpF8RWhRogGSz/b+s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-3606aa2c7a4so2113515ab.0 for ; Thu, 04 Jan 2024 11:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704397808; x=1705002608; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RUZweEFbkLdWMYXqKQEAVWFTSzzHpoDqDkacOJOsRso=; b=ApEiJ0WGT08uvmeC8KiD0kG0jQwuVwAs26dTdNtUjp4BB3X/Mnrzmhmwi/9E0paGPb vIfRZtPIQA747Xv49C79pJvjFguCNOnngSkYNWGgtNQN6Bm4utbVisROAAFfXv128L33 fEeJRPOyoJ0PLTataDMPrmf3GRseddYY/8DhD7EDJbXqvSBH5LfX52UnlZPjLzx/6KVR nzvemuX1Xbe0gNK+SuYPE2onluWNRvujmARH4VEyh6/GPSZPjqCmgCnkkdE3nfCLAcCC r20vI48Cw55rKLPKa49RwFNoF8kbt7c5n/3h9gWB+P08pKidPer3Pk6oZGP+ZIvdMK39 m0YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704397808; x=1705002608; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RUZweEFbkLdWMYXqKQEAVWFTSzzHpoDqDkacOJOsRso=; b=G+Xs9Lyq9f6vemipx6o1Z4/EdEC1nVAPEG/GX5xsllVygDNOadMSUj2mB4Z9IrN1U8 wdjkxpdgv/+gJdmX3A197QGk7rGpQ8+6WGgJM1g/kcsk4NDJ6o63VjaCL7rssYZUb44I hTWgo6aRM3rIigg9SILjU0qKP642oafeLHKGcIAZ1XnGsCwKjDuf+XMdfkHrcKUYvtjn DxK2Er9Z4bMXajtY99BsuzdxXEXbwsl4Ub2XB98A6GcBB3vmYDurrArVL0CXfUfCzTvN YmO5z9Ez8w2jNnn9tuqiGZXEbV/SLqHumevbpprdePukLSIzpGn7XdOgHpOVxYsWGxPb pHmg== X-Gm-Message-State: AOJu0Yz4VBKjQsfJEDODlxvWcnEZaJoiSMV68KXlVeGPqoqKgVu5Ssjs NHzB7YoqXxdu7IwI8cBfSek= X-Google-Smtp-Source: AGHT+IGG3yirT2nTiSGXAeLmlKLOKM0njicOaxL2MP/Va9Jp7dtP1h6V5u7FHijrHuKFzyxYffRSgw== X-Received: by 2002:a05:6e02:1567:b0:35f:ff56:c0fd with SMTP id k7-20020a056e02156700b0035fff56c0fdmr1369993ilu.14.1704397808214; Thu, 04 Jan 2024 11:50:08 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id c18-20020a92d3d2000000b0035fecec502esm18607ilh.57.2024.01.04.11.50.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 11:50:07 -0800 (PST) Message-ID: <9b7a45f1-a8ec-4817-ad71-20e24a4969c6@gmail.com> Date: Thu, 4 Jan 2024 12:50:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Match: Improve inverted_equal_p for bool and `^` and `==` [PR113186] Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20240101040329.3895909-1-quic_apinski@quicinc.com> From: Jeff Law In-Reply-To: <20240101040329.3895909-1-quic_apinski@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/31/23 21:03, Andrew Pinski wrote: > For boolean types, `a ^ b` is a valid form for `a != b`. This means for > gimple_bitwise_inverted_equal_p, we catch some inverted value forms. This > patch extends inverted_equal_p to allow matching of `^` with the > corresponding `==`. Note in the testcase provided we used to optimize > in GCC 12 to just `return 0` where `a == b` was used, > this allows us to do that again. > > Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > PR tree-optimized/113186 > > gcc/ChangeLog: > > * gimple-match-head.cc (gimple_bitwise_inverted_equal_p): > Match `^` with the `==` for 1bit integral types. > * match.pd (maybe_cmp): Allow for bit_xor for 1bit > integral types. > > gcc/testsuite/ChangeLog: > > * gcc.dg/tree-ssa/bitops-bool-1.c: New test. OK jeff