From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 374F43857C77 for ; Wed, 24 Jan 2024 17:24:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 374F43857C77 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 374F43857C77 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706117073; cv=none; b=j+EVqHhuEucmIdAK9i9jeHAigUOQi6Uu7Aiv+oKkL5/6MpmxAMkdkPmBR4W2fTmfbXA7QCaXI24rbjyffWCMtejcm5icNKRurc9kJcmaPxp1iL3qDr2VhxI3MIQ2sdcB6sQjaMhPuUJAK+PeyHtpKPfHFOf/LhRnPwIZ4H6DwYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706117073; c=relaxed/simple; bh=FXbusuun9RMKSfcLOeJ0S5qyIyPqDPqfhKySe/S1Wus=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Gnj9tAzXB/vcjHY866N9s5h202vRi4aX9UxBJAWPBVJQKau/gKXPHCO87Z4zB4u1JV1UErB71r31b8lzwI4FsHu/PQWDvqEVkks5A9C05EsO5xDcIjcgRV8lAR6hURfOUnFJ7XRtNDwH5UX1u93aF89aZCd9cOzOF0Dwx37nbzI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-361a1665791so20200585ab.3 for ; Wed, 24 Jan 2024 09:24:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706117070; x=1706721870; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JUTbycLhO9MTKj85oItbmDImScIRpK24hYxdyc2vE0U=; b=I4dzAMeZhcWRbKQel/jv6dYl+a4EqE0LKlaWmveuJYV784l2lio3pGi+i9tLXL/c3H tnjhyejGlAHeD/j3kjN7xQo9dB4MF4h3pIZESaTjhJOGYwVar5FjEcWTEmytBzEs9Pol eTz7NezwKv7ep8nMCSICE1tQy5sTVQxMZqVVawGFjp5iWYdxKGy8oTsOJA0/jYVAI64j uaaib3s+lI9wuuhHBF2Sp4g4K3yIgExFlkl+PzWDH7tHL79SrKnB8lTFaCtl7TIvS5Js FajK7WVGvDkpwdiYYz6P9QU9FpREJxZvnSZIf/vct542PNcGBzbZ+pk/I0xJ9aUDOMF1 6NLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706117070; x=1706721870; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JUTbycLhO9MTKj85oItbmDImScIRpK24hYxdyc2vE0U=; b=r+yHHK/9gVE2UHqBnkajOCyLDAA+jbXhtFPQ7j9ru0a+Zd0OtLeUhIS+7PN1MxWjbQ HHbHffRBQ5x9gtO5sxZwpbtKAIGqlW8V1SyEgMRr1kBpyh5yoSIs3waXdFu/qBqoPnND pSjZKOwr/UXMl2oiRb+gi5sq/t3TLg82CFe41NJqT+kqVSfqQiq5KebMlkXMfnUOvn+q 2/Ma0L5jnm5vKulMOWNJqho/G3X46Vo4zb7lo8L+ioqeLX+vVUW2y3m7TTkBiqz+2feH jvb6rEQ1TcaCJPp6DniNlKADbMEK9fg/NZ2lteUeiNHsGY2WCMcWyKh9Mw3NCi8xYOd0 l3ew== X-Gm-Message-State: AOJu0YyfxhyatNxEkDvyMNV8587qLMw+WthbJ9OLUnPOEnWqtJ4uWTwO Z7iXrN1AUjf6HL88vyMZmkYd77gKclgqeLJoMfjlkbrZW/BDhBj9 X-Google-Smtp-Source: AGHT+IHaERf9IM0LkWddecXFyIkTiqL2D8fRCbA6lmBS6guY4+ReL2tOk75bp5t5i+CrXMSjC2MlHQ== X-Received: by 2002:a92:1301:0:b0:361:a7ff:f569 with SMTP id 1-20020a921301000000b00361a7fff569mr2039314ilt.7.1706117070462; Wed, 24 Jan 2024 09:24:30 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id bk8-20020a056e02328800b00362766ea1cesm2797801ilb.44.2024.01.24.09.24.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 09:24:29 -0800 (PST) Message-ID: <9bc6a163-7fd0-4c34-a3f2-2315708fc642@gmail.com> Date: Wed, 24 Jan 2024 10:24:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] RISC-V/testsuite: Also verify if-conversion runs for pr105314.c Content-Language: en-US To: "Maciej W. Rozycki" , Andrew Pinski Cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt References: <2e8eae88-7853-4b97-bd2c-d32742c2ea16@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/24/24 04:26, Maciej W. Rozycki wrote: > On Tue, 16 Jan 2024, Maciej W. Rozycki wrote: > >>> I don't have a strong opinion on this. I certainly see Andrew's point, but >>> it's also the case that if some work earlier in the RTL or gimple pipeline >>> comes along and compromises the test, then we'd see the failure and deal with >>> it. It's pretty standard procedure. >> >> I'll be happy to add an RTL test case, also for my recent complementary >> cset-sext.c addition and maybe other if-conversion pieces recently added. >> I think that does not preclude arming pr105314.c with RTL scanning though. > > I have made a buch of testcases as we discussed at the meeting last week > and the RTL parser did not blow up, so I have now submitted them. See: > > and the next two messages (threading broke with this submission for some > reason, probably due to a glitch in my mail client I've seen from time to > time; I guess it's not worth it to get the patch series resubmitted as > they are independent from each other really and can be applied in any > order). > > I haven't heard back from Andrew beyond his initial message, so it's not > clear to me whether he maintains his objection in spite the arguments > given. Andrew? > > Do we have consensus now to move forward with this change as posted? I'd > like to get these patches ticked off ASAP. I think it should move forward. I think having the RTL tests deals with Andrew's concern and the testcase adjustment has value as well. I ACK's the RTL tests a few minutes ago and we should consider the 1/2 and 2/2 of the original OK now as well. Thanks, Jeff