From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 947AE385772D for ; Mon, 23 Oct 2023 15:28:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 947AE385772D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 947AE385772D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698074897; cv=none; b=HiuGnsKtxE7zPYSJB4jX45axpJn8CyNvxbRWLWSAFZ6aD4gGBgbo3a+6bWbH4JZs7Wt2un4RI/dhVVplJujy2+0rij2IPsksqe4icCCoE5xJQESICwokJFP3GGtSBzH0Xsqj8mIyizS2jR4rPXbXmA15Py5RcuNwNqZXrecF2SE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698074897; c=relaxed/simple; bh=RWxm/H9U4DHp8RWc5m4PmeIMl3XWPhckSWygIE2uBEY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=r6Svco70VSMTm84vocvl8KX5R1XybwOAwUwHHKSh+MBeCw2zUQX3taiQxq9S56Pu2h51UMGWGstOLabf1BYHfZGtNZT5OW/pQVxV7WvHCYBSp+gWlPfW9ChjxI2kDZRYT1BQ7CN6HRsI6x6pfGpLdaBpzuIJCIiwxZJb0GnTuSM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698074896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+eQTjuk7VabhSsP4ZkJbqpjL7NXpnn41qxhceqkDrlM=; b=K3e56VLOuU+QFynH2xhRCcW8i2fsKOQz4KsRedeXwWPUd7AJHwT9TZYNYoY/f5ov5CFudP LKL62hC+6ugrivtUzshuqEpYfjUNW7El8T7fFi6YAPB5lQHb3SOFBjxI9nF0uWX20i/ev9 a1qQ3pS6QSWsn/xn1xtM1F3VnKoqvSg= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-aNU2B8EzOmus7cMeuP9GLw-1; Mon, 23 Oct 2023 11:28:15 -0400 X-MC-Unique: aNU2B8EzOmus7cMeuP9GLw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-66d4aa946ceso68673726d6.1 for ; Mon, 23 Oct 2023 08:28:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698074894; x=1698679694; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+eQTjuk7VabhSsP4ZkJbqpjL7NXpnn41qxhceqkDrlM=; b=SK19cHyd+b7BSj2duWiK+MHOt7UGYHM5/e1LWUf+rP46mtrit+EPTsYxCSEdjJFYJO JUuZk+UkTK3ovsRZID6iyRsReGqjpcuOGeVQkoi6LYg3jCdwEuFS6PRxaevcogAqcOsw rTVgaKCPaTeP4wexStYG7vrE5ZfRXV/kS727VUPr01JVL9gzVLISz6TwkOTLhKQ8d855 H20mQ2N9p9oEEnH1y64mFAD51m73UkHwjXeaXA54PNZiRBiJ7w9OCzplFcgOC+zO5YrO Qsp+xTyFExTE6AzL/7+iDjBgoHY0eOe0Jq6bb4z1+QnfNmNko9yXd58iwMMAq0RBQ0pV aguA== X-Gm-Message-State: AOJu0YyGoTTmErmo5TTyls6NWZZMWr9SW4FUNt5rE8Et737nAVOyOgDw irm947XSHgxoyNhRPygyF1fIStimYtXujHl8MeA17CSUHpakovJcjXBRZe9cNUFmoeXvM7R2CPH n09/4lgVTsXqy1EkYzA== X-Received: by 2002:a0c:f705:0:b0:63d:580:9c68 with SMTP id w5-20020a0cf705000000b0063d05809c68mr17103589qvn.32.1698074894542; Mon, 23 Oct 2023 08:28:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBOwbctGCgwoBjKLtro8aH7kb6574A6VWLinzhYS5ekypcVgusnuPMPj0+4KVumufr3m0Gaw== X-Received: by 2002:a0c:f705:0:b0:63d:580:9c68 with SMTP id w5-20020a0cf705000000b0063d05809c68mr17103570qvn.32.1698074894296; Mon, 23 Oct 2023 08:28:14 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id d16-20020a0cea90000000b0066d0f35554asm2951717qvp.79.2023.10.23.08.28.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Oct 2023 08:28:13 -0700 (PDT) Message-ID: <9bcff148-b828-4b91-8398-1885f1469b3b@redhat.com> Date: Mon, 23 Oct 2023 11:28:13 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rust: build failure after NON_DEPENDENT_EXPR removal [PR111899] To: Thomas Schwinge , Patrick Palka , gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Faisal Abbas <90.abbasfaisal@gmail.com> References: <20231020173630.2328347-1-ppalka@redhat.com> <87msw93dsd.fsf@euler.schwinge.homeip.net> From: Jason Merrill In-Reply-To: <87msw93dsd.fsf@euler.schwinge.homeip.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/23/23 05:10, Thomas Schwinge wrote: > Hi Patrick! > > On 2023-10-20T13:36:30-0400, Patrick Palka wrote: >> Built on x86_64-pc-linux-gnu, pushed to trunk as obvious (hopefully). >> >> -- >8 -- >> >> This patch removes stray NON_DEPENDENT_EXPR checks following the removal >> of this tree code from the C++ FE. (Since this restores the build I >> supppose it means the Rust FE never creates NON_DEPENDENT_EXPR trees in >> the first place, so no further analysis is needed.) > > ACK, thanks! > > > For context: indeed, a non-trivial amount of C++ front end 'constexpr' > code was copied into the Rust front end, for implementing related Rust > functionality, mostly as part of the 2022 GSoC project > "Support for Constant Folding in Rust Frontend" (Faisal Abbas), > . > > Yes, this should eventually be cleaned up (and merged with the original > C++ front end code, as much as feasible -- which I don't know whether or > to which extent it is). It would be nice to move a lot of the constexpr code into the middle-end, but I expect that would be a significant project. Jason