From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13341 invoked by alias); 19 Mar 2008 23:43:24 -0000 Received: (qmail 13333 invoked by uid 22791); 19 Mar 2008 23:43:23 -0000 X-Spam-Check-By: sourceware.org Received: from py-out-1112.google.com (HELO py-out-1112.google.com) (64.233.166.177) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 23:43:06 +0000 Received: by py-out-1112.google.com with SMTP id d37so1123771pye.29 for ; Wed, 19 Mar 2008 16:43:04 -0700 (PDT) Received: by 10.65.135.19 with SMTP id m19mr2092830qbn.18.1205970183963; Wed, 19 Mar 2008 16:43:03 -0700 (PDT) Received: by 10.65.53.19 with HTTP; Wed, 19 Mar 2008 16:43:03 -0700 (PDT) Message-ID: <9c03c2dd0803191643w115adf4dgbdcf61f69e14c208@mail.gmail.com> Date: Thu, 20 Mar 2008 01:18:00 -0000 From: "Danny Smith" To: "Kai Tietz" Subject: Re: Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c Cc: "GCC Patches" , ktietz70@googlemail.com, NightStrike In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <9c03c2dd0803182301p777369b0jec4f854dd13909b9@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg01175.txt.bz2 On Wed, Mar 19, 2008 at 9:43 PM, Kai Tietz wrote: > "Danny Smith" wrote on 19.03.2008 07:01:25: > > > Actually., I think it makes a lot of sense to test whether the > > appropriate warning is reported. > I agree, that some testcases have to be added to test all ms versus gnu > feature set. When the initial patch is applied, we can add the additional > necessary testcases. Eg. the test for 'll', additional tests for 'I64', > 'I32', and 'I' in failure cases (ISO C, wrong type specifiers, etc). For > this patch I wanted just to have an initial set of major tests, where > others can continue on. > > > > Also, if you look again at the msdn page you will note that the field > > width flag (a glibc extensuion) is not documented. > > Indeed if you test a format like "%5m", you will see that it produces > > this as output: "m" The use of this flag should produce a warning. > You are right, I removed the 'w' flag for ms_strftime. > Hello Kai Thank you for your perseverence, Kai. The mingw32-specific changes in the latest patchset are OK for trunk Danny > Cheers, > Kai > > > > PS: NightStrike could you rerun the testsuite? Thanks in advance. > > > > | (\_/) This is Bunny. Copy and paste Bunny > | (='.'=) into your signature to help him gain > | (")_(") world domination. >