[PATCH, mingw32] Mark ".text.unlikely" as executable

[PATCH, mingw32] Mark ".text.unlikely" as executable

[Zuxy Meng]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi,

Unlike varasm.c config/i386/winnt.c lacks proper handling of the 
".text.unlikely" section and will make it writable instead of executable. 
This patch fixes PR35661. Bootstrapped and tested on i386-pc-mingw32.

PR target/35661
        *config/i386/winnt.c (i386_pe_section_type_flags): Mark 
".text.unlikely" as executable

-- 
Zuxy 

[-- Attachment #2: unlikely.diff --]
[-- Type: application/octet-stream, Size: 644 bytes --]

--- gcc\config\i386\winnt.c.orig	Thu Sep 13 10:17:51 2007
+++ gcc\config\i386\winnt.c	Sun Mar 23 02:34:12 2008
@@ -420,6 +420,15 @@ i386_pe_section_type_flags (tree decl, c
     flags = SECTION_CODE;
   else if (decl && decl_readonly_section (decl, reloc))
     flags = 0;
+  else if (current_function_decl
+	  && cfun
+	  && cfun->unlikely_text_section_name
+	  && strcmp (name, cfun->unlikely_text_section_name) == 0)
+    flags = SECTION_CODE;
+  else if (!decl
+	   && (!current_function_decl || !cfun)
+	   && strcmp (name, UNLIKELY_EXECUTED_TEXT_SECTION_NAME) == 0)
+    flags = SECTION_CODE;
   else
     {
       flags = SECTION_WRITE;

Re: [PATCH, mingw32] Mark ".text.unlikely" as executable

[Danny Smith]

On Sun, Mar 23, 2008 at 2:32 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
> Hi,
>
>  Unlike varasm.c config/i386/winnt.c lacks proper handling of the
>  ".text.unlikely" section and will make it writable instead of executable.
>  This patch fixes PR35661. Bootstrapped and tested on i386-pc-mingw32.
>
>  PR target/35661
>         *config/i386/winnt.c (i386_pe_section_type_flags): Mark
>  ".text.unlikely" as executable
>
>  --
>  Zuxy
>

Hello Zuxy
Although this Change is probably small enough to not require a
copyright assignment  to FSF, I note that you have other patches
pending (eg http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01344.html)
which are larger and which I think are legally significant.  I'm
hoping that you will continue to submit patches to gcc.

Would you be willing to assign copyright to the Free Software
Foundation, so that we could install in gcc?

Danny

Re: [PATCH, mingw32] Mark ".text.unlikely" as executable

[Zuxy Meng]

Hi,

2008/3/25, Danny Smith <dansmister@gmail.com>:
> On Sun, Mar 23, 2008 at 2:32 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
> > Hi,
> >
> >  Unlike varasm.c config/i386/winnt.c lacks proper handling of the
> >  ".text.unlikely" section and will make it writable instead of executable.
> >  This patch fixes PR35661. Bootstrapped and tested on i386-pc-mingw32.
> >
> >  PR target/35661
> >         *config/i386/winnt.c (i386_pe_section_type_flags): Mark
> >  ".text.unlikely" as executable
> >
> >  --
> >  Zuxy
> >
>
> Hello Zuxy
> Although this Change is probably small enough to not require a
> copyright assignment  to FSF, I note that you have other patches
> pending (eg http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01344.html)
> which are larger and which I think are legally significant.  I'm
> hoping that you will continue to submit patches to gcc.
>
> Would you be willing to assign copyright to the Free Software
> Foundation, so that we could install in gcc?

Sure. What should I do?
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6

Re: [PATCH, mingw32] Mark ".text.unlikely" as executable

[Danny Smith]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

On Tue, Mar 25, 2008 at 10:52 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
> Hi,
>
> 2008/3/25, Danny Smith <dansmister@gmail.com>:
>
> >
> > Would you be willing to assign copyright to the Free Software
> > Foundation, so that we could install in gcc?
>
> Sure. What should I do?
> --

Attached is the template for requesting copyright assignment forms.
Please complete and email to
address given in form.

Thanks,
Danny

[-- Attachment #2: request-assign.future --]
[-- Type: application/octet-stream, Size: 971 bytes --]

Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]


[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]


[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]


[For the copyright registration, what country are you a citizen of?]


[What year were you born?]


[Please write your email address here.]


[Please write your postal address here.]





[Which files have you changed so far, and which new files have you written
so far?]

Re: [PATCH, mingw32] Mark ".text.unlikely" as executable

[Zuxy Meng]

Hi,

2008/3/26, Danny Smith <dansmister@gmail.com>:
> On Tue, Mar 25, 2008 at 10:52 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
> > Hi,
> >
> > 2008/3/25, Danny Smith <dansmister@gmail.com>:
> >
> > >
> > > Would you be willing to assign copyright to the Free Software
> > > Foundation, so that we could install in gcc?
> >
> > Sure. What should I do?
> > --
>
> Attached is the template for requesting copyright assignment forms.
> Please complete and email to
> address given in form.

I've sent it. And what about the patch itself? Is it OK for 4.3.1?

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6

Re: [PATCH, mingw32] Mark ".text.unlikely" as executable

[Danny Smith]

On Fri, Mar 28, 2008 at 9:42 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
> Hi,
>
>  2008/3/26, Danny Smith <dansmister@gmail.com>:
>
>
> > On Tue, Mar 25, 2008 at 10:52 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
>  > > Hi,
>  > >
>  > > 2008/3/25, Danny Smith <dansmister@gmail.com>:
>  > >
>  > > >
>  > > > Would you be willing to assign copyright to the Free Software
>  > > > Foundation, so that we could install in gcc?
>  > >
>  > > Sure. What should I do?
>  > > --
>  >
>  > Attached is the template for requesting copyright assignment forms.
>  > Please complete and email to
>  > address given in form.
>
>  I've sent it. And what about the patch itself? Is it OK for 4.3.1?
>
Yes.
Danny
>
>
>  --
>  Zuxy
>  Beauty is truth,
>  While truth is beauty.
>  PGP KeyID: E8555ED6
>

Re: [PATCH, mingw32] Mark ".text.unlikely" as executable

[Zuxy Meng]

2008/3/30, Danny Smith <dansmister@gmail.com>:
> On Fri, Mar 28, 2008 at 9:42 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
> > Hi,
> >
> >  2008/3/26, Danny Smith <dansmister@gmail.com>:
> >
> >
> > > On Tue, Mar 25, 2008 at 10:52 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
> >  > > Hi,
> >  > >
> >  > > 2008/3/25, Danny Smith <dansmister@gmail.com>:
> >  > >
> >  > > >
> >  > > > Would you be willing to assign copyright to the Free Software
> >  > > > Foundation, so that we could install in gcc?
> >  > >
> >  > > Sure. What should I do?
> >  > > --
> >  >
> >  > Attached is the template for requesting copyright assignment forms.
> >  > Please complete and email to
> >  > address given in form.
> >
> >  I've sent it. And what about the patch itself? Is it OK for 4.3.1?
> >
> Yes.
> Danny

Thanks! Could somebody apply it?

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6

Re: [PATCH, mingw32] Mark ".text.unlikely" as executable

[Zuxy]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

"Zuxy Meng" <zuxy.meng@gmail.com> дÈëÏûÏ¢ 
news:a18e06b40803312029r61d10251sb15c56c41e5659bf@mail.gmail.com...
> 2008/3/30, Danny Smith <dansmister@gmail.com>:
>> On Fri, Mar 28, 2008 at 9:42 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
>> > Hi,
>> >
>> >  2008/3/26, Danny Smith <dansmister@gmail.com>:
>> >
>> >
>> > > On Tue, Mar 25, 2008 at 10:52 PM, Zuxy Meng <zuxy.meng@gmail.com> 
>> > > wrote:
>> >  > > Hi,
>> >  > >
>> >  > > 2008/3/25, Danny Smith <dansmister@gmail.com>:
>> >  > >
>> >  > > >
>> >  > > > Would you be willing to assign copyright to the Free Software
>> >  > > > Foundation, so that we could install in gcc?
>> >  > >
>> >  > > Sure. What should I do?
>> >  > > --
>> >  >
>> >  > Attached is the template for requesting copyright assignment forms.
>> >  > Please complete and email to
>> >  > address given in form.
>> >
>> >  I've sent it. And what about the patch itself? Is it OK for 4.3.1?
>> >
>> Yes.
>> Danny
>
> Thanks! Could somebody apply it?

Ping....

-- 
Zuxy 

Re: [PATCH, mingw32] Mark ".text.unlikely" as executable

[Danny Smith]

On Wed, Apr 9, 2008 at 12:47 AM, Zuxy <zuxy.meng@gmail.com> wrote:
> "Zuxy Meng" <zuxy.meng@gmail.com> дÈëÏûÏ¢
> news:a18e06b40803312029r61d10251sb15c56c41e5659bf@mail.gmail.com...
>> 2008/3/30, Danny Smith <dansmister@gmail.com>:
>>> On Fri, Mar 28, 2008 at 9:42 PM, Zuxy Meng <zuxy.meng@gmail.com> wrote:
>>> > Hi,
>>> >
>>> >  2008/3/26, Danny Smith <dansmister@gmail.com>:
>>> >
>>> >
>>> > > On Tue, Mar 25, 2008 at 10:52 PM, Zuxy Meng <zuxy.meng@gmail.com>
>>> > > wrote:
>>> >  > > Hi,
>>> >  > >
>>> >  > > 2008/3/25, Danny Smith <dansmister@gmail.com>:
>>> >  > >
>>> >  > > >
>>> >  > > > Would you be willing to assign copyright to the Free Software
>>> >  > > > Foundation, so that we could install in gcc?
>>> >  > >
>>> >  > > Sure. What should I do?
>>> >  > > --
>>> >  >
>>> >  > Attached is the template for requesting copyright assignment forms.
>>> >  > Please complete and email to
>>> >  > address given in form.
>>> >
>>> >  I've sent it. And what about the patch itself? Is it OK for 4.3.1?
>>> >
>>> Yes.
>>> Danny
>>
>> Thanks! Could somebody apply it?
>
> Ping....
>
> --
> Zuxy
>

Committed to 4_3-branch as revision 135188
Index: config/i386/winnt.c
===================================================================
--- config/i386/winnt.c	(revision 135187)
+++ config/i386/winnt.c	(working copy)
@@ -420,6 +420,15 @@
     flags = SECTION_CODE;
   else if (decl && decl_readonly_section (decl, reloc))
     flags = 0;
+  else if (current_function_decl
+	  && cfun
+	  && cfun->unlikely_text_section_name
+	  && strcmp (name, cfun->unlikely_text_section_name) == 0)
+    flags = SECTION_CODE;
+  else if (!decl
+	   && (!current_function_decl || !cfun)
+	   && strcmp (name, UNLIKELY_EXECUTED_TEXT_SECTION_NAME) == 0)
+    flags = SECTION_CODE;
   else
     {
       flags = SECTION_WRITE;


>
>
>