From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29770 invoked by alias); 16 Nov 2009 03:24:49 -0000 Received: (qmail 29755 invoked by uid 22791); 16 Nov 2009 03:24:48 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-yx0-f195.google.com (HELO mail-yx0-f195.google.com) (209.85.210.195) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Nov 2009 03:23:44 +0000 Received: by yxe33 with SMTP id 33so8709090yxe.0 for ; Sun, 15 Nov 2009 19:23:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.90.41.29 with SMTP id o29mr4000110ago.101.1258341822154; Sun, 15 Nov 2009 19:23:42 -0800 (PST) In-Reply-To: <4AFC8EC3.10502@gmail.com> References: <20091019092452.2e271791@mcgee.artheist.org> <4AFC8EC3.10502@gmail.com> Date: Mon, 16 Nov 2009 03:34:00 -0000 Message-ID: <9c03c2dd0911151923p3eeb0d3fi54434c911ae8a6ce@mail.gmail.com> Subject: Re: Libstdc++ as DLL on windows, alternative approach [was Re: cygwin patch review] From: Danny Smith To: Dave Korn Cc: Benjamin Kosnik , libstdc++@gcc.gnu.org, GCC Patches , "Aaron W. LaFramboise (GCC)" , Kai Tietz Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-11/txt/msg00753.txt.bz2 On Fri, Nov 13, 2009 at 11:40 AM, Dave Korn wrote: > Benjamin Kosnik wrote: >> From older mail thread: > > =A0Likewise. =A0I had to take some time away from this to do other stuff,= but > I've gotten back to it this week. > >> No. There is already visibility markup on libstdc++ headers for this. >> You can just put the attribute visibility bits on namespace std, and be >> done with it. >> >> Here, from include/bits/c++config.h: >> >> # define _GLIBCXX_BEGIN_NAMESPACE(X) namespace X >> _GLIBCXX_VISIBILITY_ATTR(default) > > > =A0 =A0 =A0 =A0* libstdc++-v3/include/bits/c++config (_GLIBCXX_VISIBILITY= _ATTR): On > =A0 =A0 =A0 =A0platforms that don't support visibility, allow them to dec= lare a macro > =A0 =A0 =A0 =A0_GLIBCXX_PSEUDO_VISIBILITY that is applied in place of vis= ibility. > I like the idea but the name _GLIBCXX_PSEUDO_VISIBILITY is a bit strange to me (and probably others with psuedo-dyslexia). Why not _GLIBCXX_TARGET_VISIBILITY_ATTR or (more generically) _GLIBCXX_TARGET_ACCESSIBILITY_ATTR that defaults to _GLIBCXX_VISIBILITY_ATTR. Danny