From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2083.outbound.protection.outlook.com [40.107.14.83]) by sourceware.org (Postfix) with ESMTPS id A48673858D33 for ; Wed, 22 Feb 2023 13:12:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A48673858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=clpPKoYKOSBaTwGPoKpE9/OM0z9cTVAsKW87T6NWFdM=; b=ZJxwkKJMym4MKlqoziG3h2wmLxCl8lueLVabgEPzIFCokpXuyydurEepaFPsYgrjZaJEOJ6bWfkxTVYz8MCYGw/9qjh4ri4spEHTsm1DmQyAL0JodMFlcNZTbWfcd0zndUfdIqd/QvQKZoxjQss+c6Ew3HEB/ZqGfLmzcQkimMc= Received: from AM6PR10CA0026.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::39) by AS8PR08MB10150.eurprd08.prod.outlook.com (2603:10a6:20b:62a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 13:12:33 +0000 Received: from AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::74) by AM6PR10CA0026.outlook.office365.com (2603:10a6:209:89::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.18 via Frontend Transport; Wed, 22 Feb 2023 13:12:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT003.mail.protection.outlook.com (100.127.140.227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19 via Frontend Transport; Wed, 22 Feb 2023 13:12:32 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Wed, 22 Feb 2023 13:12:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7efb55b4f5d87a81 X-CR-MTA-TID: 64aa7808 Received: from 7dc3c65d8159.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F5302980-5D5F-4C8F-853B-E36A38584D3E.1; Wed, 22 Feb 2023 13:12:26 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7dc3c65d8159.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 22 Feb 2023 13:12:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hxNGGIzogI8FL6UjWH++d59BarSzYW6xCrWNNwud0ArJHZLVBBXeuzR3W1HFOMjee2oPDdLVB18gNAqjjBW+j8W3eIYlp4jw5WyFHVBiray3AgJ+kcM6Huo5sgWqYRGP9ajfFbU3USDysLSjLlFZimHfYjsdAXtXoRMR5SXvCf9fKm+Wmk7WYduErJHJf5eLWFG8Qc7C/bSzzF0lZIgluYtmLmoALhw3QsDMfLDYlJh0qqTpWSrfecxngLC8FMU8KvAyO4z/nXF5rHf1VI+VLHpbgtiPch5dOksWJ1WC12lQ5qNHOVlKgZR7rC6XWpp5XgQEZn+RlK0A2xZE+/tvgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=clpPKoYKOSBaTwGPoKpE9/OM0z9cTVAsKW87T6NWFdM=; b=J9wmYtDDWlX8UEEMqfKlP8KZeo2NEDSH3d9ZpEuY9G7tCiPTP5bG/+YvBtPb49y1v2a0HlFJr/3M5MiNAQ0/EaXJLZhBnVoLpOsdJE1DuF8RpoKWaWh4t0Q3ooZeDmON8ZRSq1rhYU459PT02O2AAw0agkR4h6z4JKPDDI4J4FlUMRAQnybq0Q8t6gY4Xpn3eVjov1esLG20SfZ47bBEIU0rK/P/sfk7di7IUiasASiPhDBEmWJ5Q4tVTQOCGEg7SjheX7c7v/eRZ7GqgIYMdkdBwRWmyZ2S6M2NsJnJvytB/raLlk9J0I1a1fKVirQzEUTnZOVGJJRjKF1bFe4UAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=clpPKoYKOSBaTwGPoKpE9/OM0z9cTVAsKW87T6NWFdM=; b=ZJxwkKJMym4MKlqoziG3h2wmLxCl8lueLVabgEPzIFCokpXuyydurEepaFPsYgrjZaJEOJ6bWfkxTVYz8MCYGw/9qjh4ri4spEHTsm1DmQyAL0JodMFlcNZTbWfcd0zndUfdIqd/QvQKZoxjQss+c6Ew3HEB/ZqGfLmzcQkimMc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3390.eurprd08.prod.outlook.com (2603:10a6:803:7d::27) by PA4PR08MB7521.eurprd08.prod.outlook.com (2603:10a6:102:26a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 13:12:23 +0000 Received: from VI1PR08MB3390.eurprd08.prod.outlook.com ([fe80::934c:40da:b35c:60d7]) by VI1PR08MB3390.eurprd08.prod.outlook.com ([fe80::934c:40da:b35c:60d7%6]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 13:12:22 +0000 Message-ID: <9c294410-2e0d-2d40-2a89-c58bf21fea63@arm.com> Date: Wed, 22 Feb 2023 14:12:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] [arm] adjust tests for quotes around +cdecp To: Alexandre Oliva , gcc-patches@gcc.gnu.org References: <34f5c89d-9298-2ed2-95b5-faee25da0b72@arm.com> Content-Language: en-US From: Christophe Lyon In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0271.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::19) To VI1PR08MB3390.eurprd08.prod.outlook.com (2603:10a6:803:7d::27) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3390:EE_|PA4PR08MB7521:EE_|AM7EUR03FT003:EE_|AS8PR08MB10150:EE_ X-MS-Office365-Filtering-Correlation-Id: f9213c8d-dc80-456b-c543-08db14d6757b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bwwA+x40ZlS0/ey1B9O64EnLCwX4yN0U4Lew05NVj6txePPi8By5Y7bvP/2zKe6vdf1C+jmdSC9GTX85eBMsdDAyoE7q/nKekV35E2axmty0HcMx78h9kkn/k+ngTwmdW3x1ewIfvziYdupswgyz4gxPVKaYNGtrUbDYriyC6GSH1tqhQuMw1/PaLBsLJ4ML3H2G6ilfUsjcTYaAUl3+JT3pbKY1nXdAOG7yFCJByFu8zkq5Tl7UY9u3+HqZ2ipHZNX03aAeHvxjgpgg8Xr1azJMJC9uMyJWP8aYWIe5dtyTKiv4VdNAnZEFkvDoD8iQA+cDCdPL3FDCr1OBuapa4DK9GEf2vbR39YhFoMAvvM806yt5DjN9qyEtjXeSc/1gtLNnNXnGpnhnUHnQ2BEWK9pHfvhUaj7UFOGPH4iOU2p2m2pHWz0beeSrLZS2B7f+qG5mAYmAhGMaqH9rpnH+t6brgzkZ+8SPDrdDuvmvHjQxGtD+S0Csh75fJlcMhA7PK9hfAdxtR6KU8g/L4ZA3MBHczaF1ZUv+o0CDXzdQYnQix0OedyX+xsVl7QDLVzWs7VyQSUt1wAXJsCrZZNMgyFq1bsdXwVmJocPwRc2xT18BIu8znO4En2gpw9Kgd/kysZtZY8FPfZy5SzUvAR3T7XOup9FO12FfUNuc628ZMZ4gSP0XcoV5a3LjjOseUUoENA8Icz2kTsuiCkNAxDCXPcT+2B/njUL8qFUl7BdwEeA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3390.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199018)(31696002)(31686004)(38100700002)(83380400001)(86362001)(2616005)(316002)(8676002)(66476007)(5660300002)(8936002)(966005)(6486002)(478600001)(36756003)(53546011)(66946007)(41300700001)(44832011)(66556008)(2906002)(6512007)(186003)(26005)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7521 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8f77716b-4a04-47cd-cf14-08db14d66e91 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I/k8hbvKS4RfLfzU60QNphXZBkqtGws40oUcxR8EyxkUdaBCkbckdfVc1X1ngFySPDTLrIEsols02Xu9t5ViA7gLMw1E/c43UGWLWjHvoZvpnoTA7cCcfZ/jWE68BNhdCJRs5ykDaYHY9dMeeE6Ujhi1dMi1dXp4eSP/XcA+57RGhuvtJGkqGIKmXQux9CPyzCU3Kmeko7zDwkduuqXkQlfdMCnOmC3m99NZaSsxWsvnXFubZRttQdKqG79K9uRgGY1SfEM+ZVCAppsUQSpSh4tpq+RmlMrChd0cVFSOPpdgubo5N0AVHxuMjCcBtaMfuHp5m2+oKCgL/D5erQvsIxMVWDkJfCMmDmbI6z54GfzmYyq6sFdLaQ8oQb0vD2q4Gljd5vxWPnnX5jMMXahnhWAryRHtEDDAwBnKdPTEvhQof1vbV72vs/vk31uRsBET+d6+MWawsWIjtmQYvmpOJ0sePqd4rhbas4IzOuFAPojdsLl6iqPzi5B69uJLQq+t/pjRB/BpjgWeWW8UWWuhgsCY9yWJHg0Ex4vskIOXoKOuYA+vRjV8rgTnCf1dHQhx2F6QC4xXyM7wh6f+WRhOHzG3OwZMc3KCuYgYL2z3mkm2CIrvNm8/zyw7JhFwL6OFvTr/UFGWDOhcfyAtMS406NFx7ApeI5RUQlwykhwjwvpTJqexyx1mC/6QiJczzNyymgAtmTcZMEFYq3ShXYsntv/pFyfGPwXOuBkLbUvLJJ8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199018)(40470700004)(46966006)(36840700001)(31686004)(26005)(186003)(6486002)(966005)(53546011)(70206006)(40480700001)(70586007)(8676002)(36756003)(5660300002)(83380400001)(8936002)(2616005)(6506007)(6512007)(336012)(40460700003)(47076005)(478600001)(356005)(41300700001)(316002)(82310400005)(86362001)(31696002)(82740400003)(81166007)(44832011)(36860700001)(2906002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 13:12:32.9034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9213c8d-dc80-456b-c543-08db14d6757b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10150 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/22/23 13:38, Alexandre Oliva wrote: > Hello, Christophe, > > On Feb 20, 2023, Christophe Lyon wrote: > >> On 2/17/23 08:17, Alexandre Oliva via Gcc-patches wrote: >>> >>> Back when quotes were added around "+cdecp" in the "coproc must be >>> a constant immediate" error in arm-builtins.cc, tests for that message >>> lagged behind. Fixed thusly. >>> >>> Regstrapped on x86_64-linux-gnu. >>> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install? > >> It seems this changed with r12-6553-gc3782843badbf3, right? > > Yup. > >> I see this commit added quotes in several others places: are the two >> tests you fix the only ones impacted? > > https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612176.html in > asm-flag-4.c also fixed fallout from that patch, I realize now, but that > was all that came up in our testing. > > I didn't start from that patch, I was just going through test results, > investigating the failures and fixing them or at least annotating the > failures as expected. > > It is conceivable that other quoted strings appear in tests that are > skipped by all of the target variants that we test. Indeed, I went > through some arm-*-eabi variants not long ago, and these didn't come up. > So, in case you're wondering whether to look for the other strings in > the tests or somesuch, please don't assume I've already done so. > OK thanks for the clarification. (and for the other cleanup patches!) Christophe