From: Martin Sebor <msebor@gmail.com>
To: Jason Merrill <jason@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PING][PATCH] correct handling of indices into arrays with elements larger than 1 (PR c++/96511)
Date: Fri, 9 Oct 2020 08:51:47 -0600 [thread overview]
Message-ID: <9c38d110-c3d3-dda1-d04c-1ec7469dbad1@gmail.com> (raw)
In-Reply-To: <2afd847d-633b-6cc8-9766-5a7fca894869@redhat.com>
On 10/8/20 1:40 PM, Jason Merrill wrote:
> On 10/8/20 3:18 PM, Martin Sebor wrote:
>> On 10/7/20 3:01 PM, Jason Merrill wrote:
>>> On 10/7/20 4:11 PM, Martin Sebor wrote:
>> ...
>>
>>>>>>>>>>> For the various member functions, please include the comments
>>>>>>>>>>> with the definition as well as the in-class declaration.
>>>>>>>>>>
>>>>>>>>>> Only one access_ref member function is defined out-of-line:
>>>>>>>>>> offset_bounded(). I've adjusted the comment and copied it above
>>>>>>>>>> the function definition.
>>>
>>> And size_remaining, as quoted above?
>>
>> I have this in my tree:
>>
>> /* Return the maximum amount of space remaining and if non-null, set
>> argument to the minimum. */
>>
>> I'll add it when I commit the patch.
>>
>>>
>>> I also don't see a comment above the definition of offset_bounded in
>>> the new patch?
>>
>> There is a comment in the latest patch.
>>
>> ...
>>>>>>>>>> The goal of conditionals is to avoid overwhelming the user with
>>>>>>>>>> excessive numbers that may not be meaningful or even relevant
>>>>>>>>>> to the warning. I've corrected the function body, tweaked and
>>>>>>>>>> renamed the get_range function to get_offset_range to do a better
>>>>>>>>>> job of extracting ranges from the types of some nonconstant
>>>>>>>>>> expressions the front end passes it, and added a new test for
>>>>>>>>>> all this. Attached is the new revision.
>>>
>>> offset_bounded looks unchanged in the new patch. It still returns
>>> true iff either the range is a single value or one of the bounds are
>>> unrepresentable in ptrdiff_t. I'm still unclear how this corresponds
>>> to "Return true if OFFRNG is bounded to a subrange of possible offset
>>> values."
>>
>> I don't think you're looking at the latest patch. It has this:
>>
>> +/* Return true if OFFRNG is bounded to a subrange of offset values
>> + valid for the largest possible object. */
>> +
>> bool
>> access_ref::offset_bounded () const
>> {
>> - if (offrng[0] == offrng[1])
>> - return false;
>> -
>> tree min = TYPE_MIN_VALUE (ptrdiff_type_node);
>> tree max = TYPE_MAX_VALUE (ptrdiff_type_node);
>> - return offrng[0] <= wi::to_offset (min) || offrng[1] >=
>> wi::to_offset (max);
>> + return wi::to_offset (min) <= offrng[0] && offrng[1] <=
>> wi::to_offset (max);
>> }
>>
>> Here's a link to it in the archive:
>>
>> https://gcc.gnu.org/pipermail/gcc-patches/2020-September/555019.html
>> https://gcc.gnu.org/pipermail/gcc-patches/attachments/20200928/9026783a/attachment-0003.bin
>
>
> Ah, yes, there are two patches in that email; the first introduces the
> broken offset_bounded, and the second one fixes it without mentioning
> that in the ChangeLog. How about moving the fix to the first patch?
Sure, I can do that. Anything else or is the final version okay
to commit with this adjustment?
Martin
>
> Jason
>
next prev parent reply other threads:[~2020-10-09 14:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 16:19 [PATCH] " Martin Sebor
2020-08-19 15:00 ` [PING][PATCH] " Martin Sebor
2020-08-28 15:42 ` [PING 2][PATCH] " Martin Sebor
2020-09-01 19:22 ` [PATCH] " Jason Merrill
2020-09-03 18:44 ` Martin Sebor
2020-09-04 17:14 ` Jason Merrill
2020-09-14 22:01 ` Martin Sebor
2020-09-21 21:17 ` [PING][PATCH] " Martin Sebor
2020-09-22 20:05 ` Martin Sebor
2020-09-26 5:17 ` Jason Merrill
2020-09-28 22:01 ` Martin Sebor
2020-10-05 16:37 ` Martin Sebor
2020-10-07 14:26 ` Jason Merrill
2020-10-07 14:42 ` Martin Sebor
2020-10-07 15:07 ` Jason Merrill
2020-10-07 15:19 ` Martin Sebor
2020-10-07 19:28 ` Jason Merrill
2020-10-07 20:11 ` Martin Sebor
2020-10-07 21:01 ` Jason Merrill
2020-10-08 19:18 ` Martin Sebor
2020-10-08 19:40 ` Jason Merrill
2020-10-09 14:51 ` Martin Sebor [this message]
2020-10-09 15:13 ` Jason Merrill
2020-10-11 22:45 ` Martin Sebor
2020-10-12 3:44 ` Jason Merrill
2020-10-12 15:21 ` Martin Sebor
2020-10-13 9:46 ` Christophe Lyon
2020-10-13 16:59 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c38d110-c3d3-dda1-d04c-1ec7469dbad1@gmail.com \
--to=msebor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).