public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Biener <rguenther@suse.de>,
	Jakub Jelinek <jakub@redhat.com>,
	       Richard Sandiford <rdsandiford@googlemail.com>,
	       Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Subject: Re: AW: [PATCH] Add a new target hook to compute the frame layout
Date: Wed, 22 Jun 2016 18:34:00 -0000	[thread overview]
Message-ID: <9c83289a-cf9d-21a1-60ea-b305c247f47d@redhat.com> (raw)
In-Reply-To: <AM4PR0701MB2162EBD176C738F44E39426BE42C0@AM4PR0701MB2162.eurprd07.prod.outlook.com>

On 06/22/2016 01:20 AM, Bernd Edlinger wrote:
> On 06/21/16 23:29, Jeff Law wrote:
>>
>> How does this macro interact with INITIAL_FRAME_POINTER_OFFSET?
>
> That I forgot to mention:  INITIAL_FRAME_POINTER_OFFSET is just
> a single call, so whenever it is called from lra/reload the frame layout
> is really expected to change, and so it does not make a difference if the target
> computes the frame layout in TARGET_COMPUTE_FRAME_LAYOUT or in
> INITIAL_FRAME_POINTER_OFFSET.
>
> But I do not know of any targets that still use INITIAL_FRAME_POINTER_OFFSET,
> and maybe support for this target hook could be discontinued as a follow-up patch.
INITIAL_FRAME_POINTER_OFFSET is only defined in 4 ports:

./ft32/ft32.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0
./m32r/m32r.h:#define INITIAL_FRAME_POINTER_OFFSET(VAR) \
./moxie/moxie.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0
./vax/vax.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0;

However, the m32r version is actually #if 0'd out.  So it's really only 
defined in 3 ports and always to "0".  So yea, it'd be a good candidate 
to collapse away.

Jeff

  reply	other threads:[~2016-06-22 18:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 14:47 Bernd Edlinger
2016-06-21 21:30 ` Jeff Law
2016-06-22  5:12   ` Bernd Edlinger
2016-06-22  7:21     ` AW: " Bernd Edlinger
2016-06-22 18:34       ` Jeff Law [this message]
2016-06-22 18:49     ` Jeff Law
2016-06-22 20:25       ` Bernd Edlinger
2016-08-04 21:16   ` [PATCH, ARM] " Bernd Edlinger
2016-08-05  9:29     ` Richard Earnshaw (lists)
2016-08-05 12:49       ` Bernd Edlinger
2016-08-05 14:06         ` Richard Earnshaw (lists)
2016-08-05 15:23           ` Bernd Edlinger
2016-09-05 16:45           ` Bernd Edlinger
2017-05-05 15:02             ` Richard Earnshaw (lists)
2017-05-06 18:16               ` Bernd Edlinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c83289a-cf9d-21a1-60ea-b305c247f47d@redhat.com \
    --to=law@redhat.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=ramana.radhakrishnan@arm.com \
    --cc=rdsandiford@googlemail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).