From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id B17043858CDB for ; Tue, 9 Jan 2024 14:38:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B17043858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B17043858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704811129; cv=none; b=mmnbAdcAEtU93MQwfjcn7wII1xULkSRS/P+RmEmKO9a9q3rRtdsEb+/WeI25yV9FBP4RbhTh1FACDVqMSDTd8+sv6gvlO6TqYpgkvgdCWTbatmCiQ1Y4YrNnChhL/5XrxkwIhw6xi2j/5QZuqHlb6+6hjWhvHv0BH1XjyCVw2R8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704811129; c=relaxed/simple; bh=iXZPhhPaUuqhzlquMyI8sqaBYnW4rx/GD4PGb71v4Sg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WIE0Lh6+froQ0up9tO7Q6sXlPlgWAmkCCvcSh5tMfXq5DxPq7fp2ot+H83sBkE+vimrVMDiSzCdIVWsuTsh2aUQ93urFrhtI0dimLYwqv44bQTVfK0gPdWnVHtRXotR32aEfw2/QeNiHGGUKF6eUfckbT965DosA9KaqwcQXAOE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7bee874fcc2so14718839f.1 for ; Tue, 09 Jan 2024 06:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704811126; x=1705415926; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EjhDRJ54aj6Y/3yflI6WCV33ONKT78P5QBBocYXNnYg=; b=W+YlN/TxmMFD36kvNCEdOP2NwKnWzUIzskz95LxaYbaAhagzmBnVOuiAVOlO32HGuS GCoHVH57LGSu2YkYzTV0XqpoHIUqjR9CpkTYfuqeCEn7JpwxfyHlfm9z7F/fqjfvDq31 UFdoawyltjGcPIGAmdQQcNEhmtGmcZhoNt52soojchRKq99OVggHOAM0A2KtIX/lYTaU l7zn+Vea7Ed/cR7jQU3c0vBH6QmJCIoNsagcXAdyZ+lA1bzT5nuGyRW/cgMtdDXNFCEl 5PI1plj6qZ4YIhb3d/8pR+YUVD9Z4DjbB/EiFJDg4XuXr0sVXc3x3YzI6y2fhLbNcByT 4NEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704811126; x=1705415926; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EjhDRJ54aj6Y/3yflI6WCV33ONKT78P5QBBocYXNnYg=; b=gCTDaVQecbuT7BPbLOfhwyiax9nL7gz10gFyAyL00yMRRSnzvx8Mm1vWt7x4ADr3hm QuuIpYLUQR28sqUjs8BLe6yoEjsGhn1grdGIgQixLnNY9JWKRABoHPKEGm61jYcmtVwz pMBfmdeAlVCyOm/RMkjTUsEOOs2v6uH6ufGg8vuiQm8GDHyScrIO0x0rcw3PAVqJ3eBk nSi6oNjVtjCNZPV/NMWtSr9Gt2fn8zNMpuPGksiYsgOLGLa4eFWbcaXuSjaEKyCbhkUl 3qQlj21sKeTX4FPxwx6WFFkLlKenV2MrQ56wD7AwHZb8euBGRJM0Ge73BfeMWi8SDxFc Me7Q== X-Gm-Message-State: AOJu0Yx2OZwheBSfBjgQ/oH487p0mKx0WaW5Su3ukuBQRKmE34ynm63k J66TIF/FzGsvsa7dSGP85EpS+pFF6bg= X-Google-Smtp-Source: AGHT+IEybH2x0b3y+grvLmz1e6/TgVvemNeM6WhZr2JFQHOXJmt2XH1EbtklSN6hEnXCm5FC0GdiXQ== X-Received: by 2002:a5e:8b4d:0:b0:7be:427c:37da with SMTP id z13-20020a5e8b4d000000b007be427c37damr3979727iom.27.1704811125791; Tue, 09 Jan 2024 06:38:45 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id n10-20020a05663831ca00b004647af59c3dsm675707jav.16.2024.01.09.06.38.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 06:38:45 -0800 (PST) Message-ID: <9ca8e885-2d8a-4ea6-9446-deb063f0e098@gmail.com> Date: Tue, 9 Jan 2024 07:38:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS] Content-Language: en-US To: =?UTF-8?B?6ZKf5bGF5ZOy?= , gcc-patches References: <20240107003654.1629705-1-juzhe.zhong@rivai.ai> <1cfa6078-0cfc-4192-b44f-a0751babe6aa@gmail.com> <905DF2A81F1936B9+2024010807071657939231@rivai.ai> From: Jeff Law In-Reply-To: <905DF2A81F1936B9+2024010807071657939231@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/7/24 16:07, 钟居哲 wrote: > Since in the previous review from Robin, he have ever asked me change > std::max into MAX, > I thought the policy is preferring MAX instead of std::max. > > I change the codes to make them consistent but it seems I am wrong. > > So is it reasonable that I change all RVV-related codes back to use > std::max/min ? > > If yes, I can send a patch to adapt all of them in RVV related codes. If Robin asked for MAX, let's leave it as-is. It's not a hard requirement, just a general direction towards std:: when we can. It may be the case that with other codes using MAX nearby that keeping consistency is better. jeff