From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16163 invoked by alias); 3 Jul 2019 23:09:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16133 invoked by uid 89); 3 Jul 2019 23:09:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jul 2019 23:09:50 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C927368E7; Wed, 3 Jul 2019 23:09:49 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-37.rdu2.redhat.com [10.10.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id C087713ACD; Wed, 3 Jul 2019 23:09:47 +0000 (UTC) Subject: Re: [PATCH] Fix out-of-ssa with unsupported vector types (PR rtl-optimization/90756) To: Jakub Jelinek , Richard Biener , Alexandre Oliva Cc: gcc-patches@gcc.gnu.org References: <20190703075941.GU815@tucnak> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <9ca8f69a-41b6-804f-6955-6e4046160c6b@redhat.com> Date: Wed, 03 Jul 2019 23:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190703075941.GU815@tucnak> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00315.txt.bz2 On 7/3/19 1:59 AM, Jakub Jelinek wrote: > Hi! > > This weird hink has been added by Alex in r228175, it isn't clear why > nor how it ever can be correct. While say for DECL_MODE we have the problem > that for global vars when switching between functions with different ISA > selections the mode might not be ok, TYPE_MODE is stored as a raw vector > mode that a function overrides to BLKmode if that particular vector mode is > not supported. This hunk breaks that assumption and leaks unsupported > vector modes in the IL of the functions which then have no way to handle > that, but even before that happens usually it breaks because we try to > convert_mode between BLKmode and the unsupported vector mode or vice versa > on PHI nodes. > > Alex, do you remember why this has been done? > > Patch has been bootstrapped/regtested on x86_64-linux and i686-linux (the > latter didn't have SSE enabled by default), Jeff said he'll test it on many > crosses. Ok for trunk if that testing succeeds? > > 2019-07-03 Jakub Jelinek > > PR rtl-optimization/90756 > * explow.c (promote_ssa_mode): Always use TYPE_MODE, don't bypass it > for VECTOR_TYPE_P. > > * gcc.dg/pr90756.c: New test. Nothing tripped related to this patch in the various targets in my tester. jeff