From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by sourceware.org (Postfix) with ESMTPS id 7B5413858D28 for ; Tue, 23 Nov 2021 15:45:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B5413858D28 Received: from AS9PR06CA0320.eurprd06.prod.outlook.com (2603:10a6:20b:45b::33) by AM0PR08MB3041.eurprd08.prod.outlook.com (2603:10a6:208:5c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 15:45:31 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45b:cafe::ab) by AS9PR06CA0320.outlook.office365.com (2603:10a6:20b:45b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Tue, 23 Nov 2021 15:45:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Tue, 23 Nov 2021 15:45:30 +0000 Received: ("Tessian outbound de6049708a0a:v110"); Tue, 23 Nov 2021 15:45:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 30150df3c223c0ef X-CR-MTA-TID: 64aa7808 Received: from 2bc4b50ce5d7.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E90DCE45-B01B-4CAD-9B58-CB9292E374D0.1; Tue, 23 Nov 2021 15:45:18 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2bc4b50ce5d7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 Nov 2021 15:45:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lkGpy0FXMjIwXEzCYHB6a+Bza6Q8GXdzhUwvEtiPEwwWTwGGzRfEA+eKE0Ih1dgtqRKTF8m8Eg+vdlvW5SR19eHYVWBGubaGv6Qgvce9RN0I2ECerouSxQz291L0EabbULXSNQ0MD3g2wjK+V9j184TnhJ0ErvPjN+RBOxxo9nGrmQOQdckLdGa0qvWJqofo4MhNNaJYzGkfz6eWR7koH+cy6qkEzVHfifRySXK9NO/yiUeP1sXEbqzIFl0lPNMQ9f3W8LHbwFQofSWOczh9vF/fQ2hrMq3QT4ifDk4lzGZ/HUWiI5+zfjSGGoJNZzp1QLHBIJ8ODGVpjsOBel1Ycg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nSSS06bvsZLA4Ylo+ImPfX1AU+kvyuXvBLcwttyP6Xk=; b=mpxGCKcsb8yRxG4D2/CH17wC2FGp85A6Uhv+CwoNenA6Ux3grxbWp1BNgjjtKeV4NzV5J74e/6MqyerWCIPue7feUUT090mOpr+b17d5DUfyg4wiRTAn35Dh6hdls6ymzu6ufRjjuUZpqeVjZrAuyKuSb8OKTw53TaVOG6njOq4ClPyGuYY4vsK/zdww+zc+NLh8HCU7zy9ESK4o40TIr119Y+W2DjeN4Sxv5+SXE+B7lF2396ee0u03877O6aFAdHFBqqvZ2+roseAjBCPZJRLiXlYyW9knHWkqodytFGWK9AEs6WqqFNYdKGa4Tf4j5PjXEE9lkunGvjtV1KU+9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB5175.eurprd08.prod.outlook.com (2603:10a6:20b:ef::11) by AM6PR08MB4803.eurprd08.prod.outlook.com (2603:10a6:20b:c4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 15:45:07 +0000 Received: from AM6PR08MB5175.eurprd08.prod.outlook.com ([fe80::8d8f:5a4a:c1f8:c305]) by AM6PR08MB5175.eurprd08.prod.outlook.com ([fe80::8d8f:5a4a:c1f8:c305%6]) with mapi id 15.20.4713.025; Tue, 23 Nov 2021 15:45:05 +0000 Subject: Re: [PATCH 2/2][GCC] arm: Declare MVE types internally via pragma To: Richard Earnshaw References: <55ba6a8c-4dda-c023-0e93-a052e4830d06@arm.com> <342ef4e3-6013-2d67-adc8-6310febe2f52@foss.arm.com> <2a59e081-0a5f-5b9b-c398-d89c6c217822@arm.com> From: Murray Steele Cc: gcc-patches@gcc.gnu.org Message-ID: <9ccc226a-fdf7-d465-6074-b6a78d16b316@arm.com> Date: Tue, 23 Nov 2021 15:45:01 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0512.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::18) To AM6PR08MB5175.eurprd08.prod.outlook.com (2603:10a6:20b:ef::11) MIME-Version: 1.0 Received: from [10.32.99.44] (217.140.106.32) by LO4P123CA0512.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Tue, 23 Nov 2021 15:45:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f4cb2005-043c-4aa9-0837-08d9ae984743 X-MS-TrafficTypeDiagnostic: AM6PR08MB4803:|AM0PR08MB3041: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2HrO2iqpsu2TayCPB34UibIy2USejbBE1Ezr111WlOzOp+rg2dZfFZsAVWrG0MM7zwv/T1jgPjbNVlJP70LqRq0kbz66+04fDmKjPls8YYa64TI2K3xnDaFNal0386F5ME797u0H5H8aQTFSdaP1qCzXdY2eF4aRf8Ota4btmnB86cdNZnjiwewVunCSu6Y0SyKbG90TM+gMFD7gIZ/Z7NHomC7KV/ooXU6pjvcF575/QO/ESqTcTG0sar+Jqq3L3bBAhjY0vRP5a14ZEG0vf0g16LgZvu0vow31ZtgM2w+tpxxN/OOyeqxn15y0EkEyQw94DcbxTYXJUucwANB2Avi30PkMBNr3suipJjIulELghAaH+UqPEv/woDGqRXVgAPQLN0/sX2JNLkYeKhEAuTeI0uguzA0hGVrFzmm/9W65ZvaSyJA3hUz5FFuy+82lr5/HeB3eTxV0qT6Z7uS9mQ/DbirPy5PxFg46kAShCCoX+zrkN3fwNPiLZ1e4UcPnQQVup9aB4tLxe18q9NWNWME/tHtfpPlOw8zX2d3RrKEMsKNOBAFIPfYBLzbMMLjkqMY9YAyB5mOi38RHtvwciGx9jHrJWLIvJbxQpiaEtCI9WObLxKtPSmXkNo3C85NM1IIlrghjSisuBv/h+B697TyXtMx3g9kJl4jub1LX5DeyiS8P4ddUlHgdkkSeL1gc3WAxsA0fXyIgPvEcm3g4ku7xd3I7wGOZwe0Wn1AbPbA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB5175.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6486002)(8936002)(6666004)(66556008)(66476007)(66946007)(38100700002)(83380400001)(36756003)(53546011)(26005)(186003)(8676002)(86362001)(316002)(508600001)(4326008)(5660300002)(2906002)(6862004)(31686004)(31696002)(16576012)(2616005)(956004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4803 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7ddcd648-8db2-40f8-2b15-08d9ae983843 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tIpnB9gjPCw/Ye5M3rqARVzkGKbJLuRXcKqlqHeuoTj5dXHH8KLnG2lJ53RDiTmd+K+pW7qWVh9shsPdhEMoH4wWK7mD3d4OyRpWVaG7SDelb29+XtOnJnZ+IbcsF28lve2s3JzIIO76S1T6Q/iUAiLgfe/mzAiTwIXhse8ln+HgpGNObbRXk864I3N/zqM+0NfeBAOgudv63bfxEuTHcIf+Ht8RgARcM2D1lPPQTXqf8U6YH6Y1a5S7FfpPXbWAZdLqauMIMXo5GjxjwfiTA7TwBrPGf4NvfBJHRiwLe36iUXFovF+++uCgJQ+8mFOuwqRANAZrB00QfoyQTY/dHRCWNOGS8jOSMOxFRWC6dYDHn2K34mTzWjlaul+b5kTuaP2CSfezSbZtUhSQuzAMTnGmvHg3vDBhZRyt7eJSkzBc6ycvsraQGgwwi1Wqu06nG/s2BNmPC60YrL3JzyZPYC3gJYlIVomRTWyEDzfhkvmS18qg3gPw9W5S7UKIN88LJuHTJL2D14V5gnGHvMMdp4ieAKzC/bVNSAJi12j3mrDnrcoZ3tuTSSnCxyzA3TZtnDydrQ3VnK8DiE8Ma7czgZZknobMztEn2hRptV5gpcGRRsfUQxafOj2Tqjle1cDDDZqyFTcM58TLZfzRIao0yDL1OlHDjwwtfA4Ql1V2DAzKotv8UF8SsHqLxnCPxgnriS6eZTrPdKWPcTu2d/ZrSKDILyuDdPYJsvWSBue5Z44= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(336012)(26005)(956004)(316002)(70206006)(8936002)(2616005)(8676002)(82310400004)(53546011)(186003)(5660300002)(6862004)(356005)(70586007)(31686004)(81166007)(36860700001)(6666004)(83380400001)(31696002)(47076005)(16576012)(4326008)(36756003)(86362001)(2906002)(6486002)(508600001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 15:45:30.2383 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4cb2005-043c-4aa9-0837-08d9ae984743 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3041 X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 15:45:36 -0000 On 23/11/2021 14:16, Richard Earnshaw wrote: > > > On 23/11/2021 09:37, Murray Steele wrote: >> On 18/11/2021 15:45, Richard Earnshaw wrote: >> >>> >>> This is mostly OK, but can't we reduce the number of tests somewhat? For example, I think you can merge type_redef_13.c and type_redef_14.c by writing >>> >>> /* { dg-do compile } */ >>> /* { dg-require-effective-target arm_v8_1m_mve_ok } */ >>> /* { dg-add-options arm_v8_1m_mve } */ >>> >>> int uint8x16x4_t; /* { dg-message "note: previous declaration of 'uint8x16x4_t'" } */ >>> int uint16x8x2_t; /* { dg-message "note: previous declaration of 'uint16x8x2_t'" } */ >>> >>> #pragma GCC arm "arm_mve_types.h"  /* { dg-error {'uint8x16x4_t' redeclared} } */ >>>    /* { dg-error {'uint16x8x2_t' redeclared} {target *-*-*} .-1 } */ >>> >>> etc.  Note the second dg-error is anchored to the line above it (.-1). >>> >>> R. >> >> Thanks. I think if we'd like to reduce the number of tests, it would make the most >> sense to merge the test cases in the way you've described based on their implementation >> and target features. i.e. >> >> - type_redef_1.c : covers mve_pred16_t. >> - type_redef_2.c : covers single-integer-vector types. >> - type_redef_3.c : covers single-float-vector types. >> - type_redef_4.c : covers integer-vector-tuple types. >> - type_redef_5.c : covers float-vector-tuple types. >> >> The idea being that the test results for these tests should allow someone to triangulate >> the cause of the failure. For example, if tests 4 and 5 fail, it is likely due to a >> deficiency in the MVE tuple type implementation, rather than the handling of target-specific >> features. More specific tests failures can be determined by looking through log files. >> >> Thanks, >> Murray >> > > Merged files will still have the same number of tests, and the same possible test names, just from fewer source files.  So I don't think triangulation will be an issue. Ok. In that case we could merge all source files into one which covers all types. Thanks, Murray