From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=4491=J7=arm.com=Richard.Earnshaw@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id 17EB43858D34
	for <gcc-patches@gcc.gnu.org>; Thu, 22 Feb 2024 11:40:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17EB43858D34
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 17EB43858D34
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708602020; cv=none;
	b=QzA9l8nGljlJJ6FOMewp72I+43oupP50WaXlNENSeHRQGlgO/7de1eD5M7DN/NqJ8FiAImHSehuzgDtF9bJ4134qSc8rRze+hfOFI6k42YfZomSYWFwjnMciMYMFjH1c5xeCjKxmmsL23ZZfpaUyoKMzsnKxcBhqxAYc2LMXuk8=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1708602020; c=relaxed/simple;
	bh=CPtLtGANOujq9VdXsW1GLt1lHsWU4PAmyWw2H4dXq6k=;
	h=Message-ID:Date:MIME-Version:Subject:To:From; b=RLpWre2PLZXAFFm8iLxJpq8tL3gQZintFUCHJdK4UHkdo2hKcndTUXCozjd2pBB+78985HyU9v7QJCGKAgNtEyTrKyacE4TptDTjlRMiG5W24h6olltFX5OXLybkvmeOrltd5Osss/MB7PGD3fgTsjV9cHwjd54SLarR9nifQm8=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 28709DA7;
	Thu, 22 Feb 2024 03:40:57 -0800 (PST)
Received: from [10.2.78.54] (e120077-lin.cambridge.arm.com [10.2.78.54])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 88A543F73F;
	Thu, 22 Feb 2024 03:40:17 -0800 (PST)
Message-ID: <9cd85535-b65b-4be7-9d40-a4e49c72e553@arm.com>
Date: Thu, 22 Feb 2024 11:40:16 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 02/13] aarch64: The aarch64-w64-mingw32 target
 implements
To: Evgeny Karpov <Evgeny.Karpov@microsoft.com>,
 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "richard.sandiford@arm.com" <richard.sandiford@arm.com>,
 "10walls@gmail.com" <10walls@gmail.com>,
 Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
 "mark@harmstone.com" <mark@harmstone.com>,
 Zac Walker <zacwalker@microsoft.com>, Ron Riddle <Ron.Riddle@microsoft.com>,
 Radek Barton <radek.barton@microsoft.com>
References: <VI1PR83MB04314E947B1CF296708085DDF8572@VI1PR83MB0431.EURPRD83.prod.outlook.com>
 <VI1PR83MB04312A9E764DE743D605811BF8572@VI1PR83MB0431.EURPRD83.prod.outlook.com>
Content-Language: en-GB
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
In-Reply-To: <VI1PR83MB04312A9E764DE743D605811BF8572@VI1PR83MB0431.EURPRD83.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3491.7 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 21/02/2024 18:26, Evgeny Karpov wrote:
> 
+/* Available call ABIs.  */
+enum calling_abi
+{
+  AARCH64_EABI = 0,
+  MS_ABI = 1
+};
+

The convention in this file seems to be that all enum types to start with aarch64.  Also, the enumeration values should start with the name of the enumeration type in upper case, so:

enum aarch64_calling_abi
{
  AARCH64_CALLING_ABI_EABI,
  AARCH64_CALLING_ABI_MS
};

or something very much like that.

R.